Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f4867b7f-a8fb-e53a-a693-1ffb9c840e8e@intel.com>
Date:   Tue, 5 Jul 2022 16:17:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v1 1/4] bus: hisi_lpc: Don't dereference fwnode handle
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        <linux-kernel@vger.kernel.org>
CC:     <john.garry@huawei.com>
References: <20220705114312.86164-1-andriy.shevchenko@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
In-Reply-To: <20220705114312.86164-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3RRaHlTZ09Eb25JQlZpYU1IMFFDcmtuQzdXVUZZZ1NFOGVTZUZJL0UyMyta?=
 =?utf-8?B?RmZJRWNjaVhVeUxyYWFhSEVwcDE5bmRzS0FjV2t1VnI5VVMwUVFUZTZ1ZmpC?=
 =?utf-8?B?dzVWaUZPaVlCVkJwa0VUOEUxT0FmcldtZnUxT3pNdEhJbndtc21ldGkrSlNp?=
 =?utf-8?B?ck9zMjN6Uml5RnVTclh1Y3NQSy9rMlB2N3Y3NW0vUXlkZm1LVkxkK2czTVFi?=
 =?utf-8?B?N3EyZTFOS1BWSlZ1cFQybGxkN1pHT25tdDhDd3d6Sm5KOFhPL1pnQ1h2WTJQ?=
 =?utf-8?B?TzhLQWtGTmVOSG1zTDkwMkd1bGhDM0FjV1l0ZWt4dzF6T2NSWVRINW1mS3VQ?=
 =?utf-8?B?WnRzc1FXYWptV2d3RWpsMEpnU0tBZ0VEakFJUStCaUQ5d2JJcUxlUFRqd0M1?=
 =?utf-8?B?OGp1eHRwVk9LUWpqVXlKL2xvQTBzRVpxRy83QVd1eGFGbVVHeTc3ZytTWk9j?=
 =?utf-8?B?Wm9ObEJUTVUydUF5ODB4RHhYdEtoNjJ3R2JFWlJZMlFCR3o4L3pqbDYrMXBT?=
 =?utf-8?B?Vm96MHkwc05GbnArc0Nxc1lsem5XWkd0R2prVnpyMDE3ZHdmaEs4TVBpbDF1?=
 =?utf-8?B?Vk9ya3FER1pNU0tDS1RZTTIrQ1FxTFlkK0lzTEJ5MUY5UU1seXRCQ2krdW9M?=
 =?utf-8?B?MFNhb0pOZ2puZHNsVDRKb25FNW5kYjBJNCtIQ2FXVWtHdG8wKzJlYnVQVWF3?=
 =?utf-8?B?bjRmRXQ3a0dsN09zOXpzMFIvWlpoVng5bWJaRStRTU8zc09IZTVOcTFrSjcv?=
 =?utf-8?B?YTZ0ODJoQk9pM3AxbUFPaGhOejMvYlluL1k2dDhueWNsRWQ3NUhwQWg4bjgx?=
 =?utf-8?B?VHJkOTdtMEF5cmpGZjdtSi9WMklNSWRieWdFSG9COUNYeTNXYkNDR3hXQlNx?=
 =?utf-8?B?R0JCc1J3SzlSWXJOaEVFNzViV1MvZWNwU2VCYnJyWnVwS3VNL2Vtak5MbDdz?=
 =?utf-8?B?cmJSTC9ZL2dLSXphMXNzbmhuMkN1RWxJU0JSVDQvYXBKK0FWU3pHd2ZuMVpy?=
 =?utf-8?B?bHp0M2RJMGpMWFp6aGc1cmNucmRCQ2lJL01XMXFlK2gyTGdMWWY4ckxsRmNV?=
 =?utf-8?B?REFHTkprUGR3TmJiYXo1bTBqenRYWWlBVkM4cktKTjRSb1JEejN6QnF3Sm4v?=
 =?utf-8?B?dmhyOTYrZFlTdzRYSUxLM1NGamI5ajRJUGZDWW50S20yVERvMkxYdWJNUDVH?=
 =?utf-8?B?a2VkeXNWNDN6cVpKZnM0VWtGVlVHUGEvb0JiY2pWQ0tteWU0dHhhbG9ZSC8z?=
 =?utf-8?B?WGZVL0hJWnZsSFhpQkFRVWtmbk9jajFGbGlYRFU0WGtUMVRNSTB1MUp3YUo0?=
 =?utf-8?B?d3czQlJpbWoyNjNkNkRnbWVLSGlKYmtiMlBpRW1KMFpjTFY3ejQ4L3FMVVJ5?=
 =?utf-8?B?UFZFVncrZEs5ZjVxS1FxZ0c3OXF5Tm5LQkJxRmNIL2lqeDBrWVprbEsweXhk?=
 =?utf-8?B?djRVcy9EM3dUamd3NG5meVN2ZVJkN012K0VqVlpmL3N1SEFCeEhJd1FQU2N1?=
 =?utf-8?B?N0NVZVUxbzkvenBWMzhCL29LK21lbWFOZ2dZVUswMUN0ODFKK0JBL1RQblhp?=
 =?utf-8?B?aGZHeldOUmxpbklJcmJYTEIwMnVBeUdxYjE1N29zNElya1BZQ1VwMlRvZFow?=
 =?utf-8?B?US94ZTJ3VmhaOUEvNGxJOCtPV0lwZnJmRFRCZXE5N3ZzZkZQZ1kybUtaRVNj?=
 =?utf-8?B?S2RUVHlhcFhNSEUvVktJZGxWK3ZIYnJrTllEZEMxVHhZWmJHSW5GRjRQdmoz?=
 =?utf-8?B?NG0vR3F6cUhGVWYweURIekdJeThDMzlIRkxwci8wZlp6bUpseGw5UGZ2NVUz?=
 =?utf-8?B?TUk2bzNoRjB4YTV4NEI3eVYvbXNSR1hCUXNkZ2VxY3ZtT0ZKeDMxUmE3U09R?=
 =?utf-8?B?cXpqVWJ1a2FhUVk4aXQvMXlwc0ZmN2w4dW5ZZTB4eHpIWDJhKzdmd0JEdkJS?=
 =?utf-8?B?YlVLNVZoQlZKZ1NabW5xalgzZU42WGNwSU5BRTNybk1UVFlLQ1B6dXhwcDF0?=
 =?utf-8?B?VTd3Yjl5ZlovYUFmY2pYVjdpQkRNRW1hRTd3VnA0R2g1d24vb1RYR3prZVVh?=
 =?utf-8?B?QS83ZXZoMzFkYnkyUG55c05PMXdUckpQdEZTbW1DanNIbi9rMXVmUXhrZ3JF?=
 =?utf-8?B?KzBHUkdMZWlaakR6Wit4VVEvMEs2UWY4MWdWeTZsR3lKb0Z5aEdMdThFcmVV?=
 =?utf-8?B?SHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bf6ea6af-7b41-4c52-f25e-08da5e910bf1
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 14:17:09.2546
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5eYorMVhCYtZ+PG62dlxZZ2Lk0OnsZJSH5gUCmLkS1rBo5txBAbElanwzZId3u57nbYpN84IfJBLeSOBXik2jUbpETtK2mQw57iCWb1io+4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2630
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/5/2022 1:43 PM, Andy Shevchenko wrote:
> Use dev_fwnode() and acpi_fwnode_handle() instead of dereferencing
> an fwnode handle directly.
>
> While at it, reuse fwnode instead of ACPI_COMPANION().
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>


> ---
>   drivers/bus/hisi_lpc.c | 10 ++++------
>   1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index 2e564803e786..6d432a07cbba 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -347,7 +347,7 @@ static int hisi_lpc_acpi_xlat_io_res(struct acpi_device *adev,
>   	unsigned long sys_port;
>   	resource_size_t len = resource_size(res);
>   
> -	sys_port = logic_pio_trans_hwaddr(&host->fwnode, res->start, len);
> +	sys_port = logic_pio_trans_hwaddr(acpi_fwnode_handle(host), res->start, len);
>   	if (sys_port == ~0UL)
>   		return -EFAULT;
>   
> @@ -615,7 +615,6 @@ static void hisi_lpc_acpi_remove(struct device *hostdev)
>   static int hisi_lpc_probe(struct platform_device *pdev)
>   {
>   	struct device *dev = &pdev->dev;
> -	struct acpi_device *acpi_device = ACPI_COMPANION(dev);
>   	struct logic_pio_hwaddr *range;
>   	struct hisi_lpc_dev *lpcdev;
>   	resource_size_t io_end;
> @@ -637,7 +636,7 @@ static int hisi_lpc_probe(struct platform_device *pdev)
>   	if (!range)
>   		return -ENOMEM;
>   
> -	range->fwnode = dev->fwnode;
> +	range->fwnode = dev_fwnode(dev);
>   	range->flags = LOGIC_PIO_INDIRECT;
>   	range->size = PIO_INDIRECT_SIZE;
>   	range->hostdata = lpcdev;
> @@ -651,7 +650,7 @@ static int hisi_lpc_probe(struct platform_device *pdev)
>   	}
>   
>   	/* register the LPC host PIO resources */
> -	if (acpi_device)
> +	if (is_acpi_device_node(range->fwnode))
>   		ret = hisi_lpc_acpi_probe(dev);
>   	else
>   		ret = of_platform_populate(dev->of_node, NULL, NULL, dev);
> @@ -672,11 +671,10 @@ static int hisi_lpc_probe(struct platform_device *pdev)
>   static int hisi_lpc_remove(struct platform_device *pdev)
>   {
>   	struct device *dev = &pdev->dev;
> -	struct acpi_device *acpi_device = ACPI_COMPANION(dev);
>   	struct hisi_lpc_dev *lpcdev = dev_get_drvdata(dev);
>   	struct logic_pio_hwaddr *range = lpcdev->io_host;
>   
> -	if (acpi_device)
> +	if (is_acpi_device_node(range->fwnode))
>   		hisi_lpc_acpi_remove(dev);
>   	else
>   		of_platform_depopulate(dev);