Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f1d1b9e3-fa4e-53a4-8971-d4e91c0c3ebf@intel.com>
Date:   Tue, 5 Jul 2022 16:22:37 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v1 4/4] bus: hisi_lpc: Don't guard ACPI IDs with
 ACPI_PTR()
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        <linux-kernel@vger.kernel.org>
CC:     <john.garry@huawei.com>
References: <20220705114312.86164-1-andriy.shevchenko@linux.intel.com>
 <20220705114312.86164-4-andriy.shevchenko@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
In-Reply-To: <20220705114312.86164-4-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFlQNmNMbEpCZFU0Z1c0eHAyb0FnU3FNVVNmbnkzSnhpMUtSV0RRV0s1N09r?=
 =?utf-8?B?KzFPWHJ0T2F1dmtJaUVOaWFVc2NJSXowVDB6SEhzOTVsT3gyZG00aXY0TElY?=
 =?utf-8?B?QVN5NWhGVUZiU2pLTEI3amk0VlZMakZXZit3Zy9yaDI4Z2J6ZiswY3UwMkNX?=
 =?utf-8?B?cWQwcEVQUUthR2FNL094cU5BZ0NHa1J2b0VpZWZSOG1oUnNDaWhleko0VWMy?=
 =?utf-8?B?K2RCVUthYzE3SlFUcjgwL201TEh0WTNPUndTSXp4R0FQd0lJMGxXWndra3F3?=
 =?utf-8?B?WU9GUVJLOUIxTjI0dXRFOEZzNmtFbEdFelBkdnQxenc2bzZEWU9DcUF2M0FB?=
 =?utf-8?B?aDAreVBUV3d2WEEzU3c2QUlvT1V2WjZUeTE1SmV5bmJGdk02cUQ5YytMSWJp?=
 =?utf-8?B?VytqajRqMVlsWVc4U2FRS2dkcUtqdElVS2ZhdksyclhEcllwTWlJOWRnSGUr?=
 =?utf-8?B?SVZxNENzdVU5dDl6eU8wRWdBamF0cUR2REI2QkhOTVJKcVFjUm5Bb2xIMXQr?=
 =?utf-8?B?N29VeVl3d3VuZVdFaXVZbzkwSnpaQzhTWmVJNG9VNWRaWHlESDZZaUxMbUll?=
 =?utf-8?B?SE9ad1QwRllpY21MbWVNV203ZEdBcE0zb1FiRGFJcHdPdFdPMmVWalREUm1C?=
 =?utf-8?B?ZHJnWDJDeGFXY2VxbEMrVzFQZlJtOU5IL0QrN2phWm5Vd2VxNU9mS1RpQTkv?=
 =?utf-8?B?OWVGUkpTQjJoVTVhVUVVQjNVVDlSd1VuZVhESjVUUnQ1RWk0VnFpSmRuMGx3?=
 =?utf-8?B?ZE4wZXQvVVZqdEVJZXhYZC9uYmRzb3RVeUpZbXQwQVRmRThGa2t4MExIR1VW?=
 =?utf-8?B?dXZaTW1saytKTlNSTUhLb2JIWGdyOVg4eDJGaGtIRGZmR2hlVXlTbEl3Y2FP?=
 =?utf-8?B?UGRHOU5iYTFKTFdOTjR5T09WbXdjdlNiaUxLdGpSaW1aU1NieUx3UGx1SlhC?=
 =?utf-8?B?YUgxSTB1TFE4enhsUG0yM0pVbVp5OG5ibHdEOU4yUytXak1VaFFMbVNwYjBm?=
 =?utf-8?B?WVJuZWp2eHducHgxT1RmbHN0OU5LY1hxT2dwdFpHbkszTUZpUjVkSnBFNjNF?=
 =?utf-8?B?Q0JURE9hSDJVaUFndCtLdEZ5Q1NreEcxVVhCSFJwUXhQNXU4aHVvVlZnaDl3?=
 =?utf-8?B?WDRxUlNXbkdnTFVLU0hBUXhOUXc4eWdXc3pRQlhXdFo1N1g2Qjd3aGJaY2xS?=
 =?utf-8?B?bFp3MHhESEZ0czlzTkI2Q2Z6SE1URjFscG9nbktzNlp3QjNjR1pGb2hhZGV1?=
 =?utf-8?B?ejlvUVVqUXRwUFpYWFhNM1k1RkprczlrbEJ2SDhJd0NYc01YRmxKWXkrSHRE?=
 =?utf-8?B?RDJaY2RqN1lpcGM2OTBEYTFzcDJPNHZYWGZkcldwTkxZZVpEYXdEREFROUds?=
 =?utf-8?B?dGRWajZkdkQyb0tUWi84b1lJdlNlQ3NvR3dtSmdQcU1rQnNNT092bDRweEVX?=
 =?utf-8?B?TGxMVHducnJ1dlgwdUVPU3FYU3lXZnYwNitZZGtEQjEydTJCV0NXWWhEeEpT?=
 =?utf-8?B?RlJiZHVpR2xCSkJvMzFFTnpwQnpIM2hNR3JYeFdyUWJUWXd3RlVhME4waTFz?=
 =?utf-8?B?QklXQ1NpR3BDTWNKNEE2NVJLYmxmU0VHOUJ0VmUyVk1DL3h2U0daWmR6VkJW?=
 =?utf-8?B?SlIyRGtOVkhrNmovVjZad21LNmpBV3VaaEdDN3JtdHArUTIwZDJlOTZuNkdh?=
 =?utf-8?B?WmVkVDhRN3pDdnFmWUc2R1l4YnNKU3J5dVhpOTJKdHpvbGU3TThkaFlMVFNa?=
 =?utf-8?B?Ny9QZ21NclIvQ01qakxWdWJSQ25lb1U1b0kyRExSTldTR2ZsOVZwZU84eFNn?=
 =?utf-8?B?YVFnVGI4RkZucE5NcEtlOWRIS3liRW5lZDJadmdkelhsOEZNZWM5WUxha1E0?=
 =?utf-8?B?SmFyRVk4Tm13SzBPZDd1dmdXQTRXUGV3TzFYdzYxK3JsNkQ3QVpkQWxkZ3k3?=
 =?utf-8?B?Sk40Uy9Eb0R4cmk2UHFlWTdHc0tTWEptMHFkbW9GZjg1Z1BQdFk5WENUbFJL?=
 =?utf-8?B?OHAxSXhNQXlUdmRwUjFweVNucTFnQ1FNc1dOWVp6aVMzY05qSGRQYTY2Y1VT?=
 =?utf-8?B?L0x0WHlTNmtNd0drOWdpSnU4YmFoMXpzem15MHdwREg0RGRWdUZIV2RvNTZD?=
 =?utf-8?B?dzBIdnR5MWFTZVBTTExsdnZPaXd3eVpkTzFweG9GWU5sL3BvbGxwaXhnT0JG?=
 =?utf-8?B?NXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: add1a32d-b768-463e-298a-08da5e91d31b
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 14:22:43.3887
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +l7cgCK0DnH+LNZMU5un3YTAjplRmfR2G0iH54jHeYAbySdC+9AxpBlQigI9LBegAGHjLZXwf54Sl0R3iFbIn+6sMFAoUzDzK4Ggo6upF1g=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5512
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/5/2022 1:43 PM, Andy Shevchenko wrote:
> The OF is not guarded neither ACPI needs. The IDs do not depend
> to the configuration. Hence drop ACPI_PTR() from the code and
> move ID table closer to its user.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>


> ---
>   drivers/bus/hisi_lpc.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index a6513a571d7b..74f4448bff9d 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -589,11 +589,6 @@ static int hisi_lpc_acpi_probe(struct device *hostdev)
>   
>   	return ret;
>   }
> -
> -static const struct acpi_device_id hisi_lpc_acpi_match[] = {
> -	{"HISI0191"},
> -	{}
> -};
>   #else
>   static int hisi_lpc_acpi_probe(struct device *dev)
>   {
> @@ -688,11 +683,16 @@ static const struct of_device_id hisi_lpc_of_match[] = {
>   	{}
>   };
>   
> +static const struct acpi_device_id hisi_lpc_acpi_match[] = {
> +	{"HISI0191"},
> +	{}
> +};
> +
>   static struct platform_driver hisi_lpc_driver = {
>   	.driver = {
>   		.name           = DRV_NAME,
>   		.of_match_table = hisi_lpc_of_match,
> -		.acpi_match_table = ACPI_PTR(hisi_lpc_acpi_match),
> +		.acpi_match_table = hisi_lpc_acpi_match,
>   	},
>   	.probe = hisi_lpc_probe,
>   	.remove = hisi_lpc_remove,