Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1336244imw; Tue, 5 Jul 2022 07:46:25 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vwaLXLfC/clwj9jsgc0WRpCbPiUJUNdFTeHFScq0X7ebxtBVI00eM4pukPt2If1tzMeXr0 X-Received: by 2002:aa7:9206:0:b0:525:1068:c026 with SMTP id 6-20020aa79206000000b005251068c026mr42874899pfo.52.1657032384849; Tue, 05 Jul 2022 07:46:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657032384; cv=none; d=google.com; s=arc-20160816; b=ro5Iv+39tLJisfRjQpy8ulzuv2JqEl5ea0GhWl6R3r3JT9pF9HDAzLdUTOG2uz/DLh 1HHZemfIqA3qrtiUIUrnQI0mgCCvTQFMa5LGUDSTgSjlkS8B3v/QwtVwVLFfoqCvo35N CKN8vzfife3kJAz60bQWPA8BXYvKJ/r0PMF5eGzpfQ9mvkEW1Mm6l/BfRibH/kjDCkaV hIBlJQNR+W1AtKnTPjNfLrD7dvggZ37mvn42vZKfNfvqT5t8/V8SpfHjbqlTQiwKzCXf sMROwtbFk9KCqIXnj0Lhe11NhpE6PFDRRnFaF2klG9BkqivS202ELHuJXeO0KxeelRFn VcEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=VmA70OmZZDzkWbS8QB2Wvkx4rvr5zP/LtFNK+w/hUFk=; b=oGCcQoNZTLxtFUpCBn+DMexmMFx73yunNXmHd3SOOUFrmdpnF0M6STGNKGbcIfe0BC 8GimN5go39+GaRCf9NbMyYzcl6JVVsAzHmx2rBHmzf78kVAufPWo07aqzPRzoUInuCyB UZjOqHkSQvMHt1xtjmgY6f4lxCOqY8adwMMND1WIQnzvXxT85aVFpUpWP97cryTsGlXj ERxR3fnE0UYoOTDD5k7h3h7lbT4egX7axHIQHHHA40NWr96jkR4dvUAVsHL9XT9S701A i0b+50D2a1gcrzrCFi7exHuLZHXhtfwBzvSxShxi0C5TReEav9npM1UAwwjq5bTszAwE oT/Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y185-20020a638ac2000000b0040d2af22a7bsi41745674pgd.160.2022.07.05.07.46.12; Tue, 05 Jul 2022 07:46:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233132AbiGEObu (ORCPT + 99 others); Tue, 5 Jul 2022 10:31:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231181AbiGEObs (ORCPT ); Tue, 5 Jul 2022 10:31:48 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29BE921BD for ; Tue, 5 Jul 2022 07:31:48 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BA00D619C5 for ; Tue, 5 Jul 2022 14:31:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DB72C341C7; Tue, 5 Jul 2022 14:31:45 +0000 (UTC) Date: Tue, 5 Jul 2022 10:31:43 -0400 From: Steven Rostedt To: Jiapeng Chong Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/fair: fix boolreturn.cocci warning Message-ID: <20220705103143.1ea1d527@rorschach.local.home> In-Reply-To: <20220705073822.7276-1-jiapeng.chong@linux.alibaba.com> References: <20220705073822.7276-1-jiapeng.chong@linux.alibaba.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 5 Jul 2022 15:38:22 +0800 Jiapeng Chong wrote: > This was found by coccicheck: > > ./kernel/sched/fair.c:9988:9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool. > > Signed-off-by: Jiapeng Chong As your subject says "fix boolreturn.cocci warning". Can you please? That is, this change has been presented 10 times before, and every time it is nacked or ignored. The true fix is to fix boolreturn.cocci to not warn about this in existing code. Just in case it wasn't clear. NACK to this change. -- Steve