Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7b3e376e-92e0-a178-a8bc-0e985fc97504@intel.com>
Date:   Tue, 5 Jul 2022 16:38:53 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v1 2/4] bus: hisi_lpc: Use devm_platform_ioremap_resource
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        <linux-kernel@vger.kernel.org>
CC:     <john.garry@huawei.com>
References: <20220705114312.86164-1-andriy.shevchenko@linux.intel.com>
 <20220705114312.86164-2-andriy.shevchenko@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
In-Reply-To: <20220705114312.86164-2-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bGVKYWUxNFVmLzFxL0taSzhVOXV4VGRlNkpYVzJETUYvMXIzUkRXeEErTnB4?=
 =?utf-8?B?OEIyVTNPM1hFS3h2U25VQzJLaTVRQUxMU0VqQjhaNTdnanF0SUhYWklRWjFz?=
 =?utf-8?B?NzhkbEdzNExoOFdKUTNYakFMMjFDSkpncFZWOG5BUndaT1JyVDZFSDAraHdl?=
 =?utf-8?B?Mk5HdUJmTHNMbXRBQzlZdDJsck9CMnRwYmkrUEtBRnpNTlJQVlNSTGExOWcy?=
 =?utf-8?B?UnNFMmN3dEVSNStvSXNXQ2F2VjFFZTMwRG1JQnhxelBOQU93YkIzMS9XdWJj?=
 =?utf-8?B?UVpoWjVibGduVGpGWXVGNy9nWXJGeDlkYUFsdmg3WUd5RzhtRER1V2pFYXQ1?=
 =?utf-8?B?SVFqSXV2ZnFUNXVta0lDZFpCRmFTMVFkVzAxbEdhSDhLNnpMZUhMdEZUelBN?=
 =?utf-8?B?SFJqSWRNa05OQlBrYmlSUzM2OXhKdThzcHJrdjl6Vko1ejdnVTdZWVdLdjJt?=
 =?utf-8?B?U1dRUmhmZ2MvZ1NNMHV6aTNEYlBVL2l6bkZZZnlpeVduNTUwS1lWSUxRQ3Rj?=
 =?utf-8?B?bmJVb2Z1ZzAva0ozS1o0SUhGUVpJQ2t6bnByVGtoQWI0YjArZCs2MlJGcm5j?=
 =?utf-8?B?cm9TRkFhbmdHWWZkS2Q0aHhhV0R1a2RFaTRKazVBK1pZYkVpVkpNY0FhT1hH?=
 =?utf-8?B?VEtFeFdVMHJoSnR4Qnl0clZsa2RURzN2a3BjOVU2SEpDQXJMdUlIOXpyeGhY?=
 =?utf-8?B?RHBlTHVFNThjTlBJdzBZQlRNaXB1ZmtyS0JOd005NkJabFBTY1JsOVZIM3RS?=
 =?utf-8?B?OXhDaVovZ1VBRC9MZkxpY0NlcTYwZDA3dVpMYmM3MDRrSzYwdzRmcUFMaTFm?=
 =?utf-8?B?NWlMaC9IdzRBTjBtbDRzS3ZyeUY0aG5YREdYbEVmbXRwaElDUktlcFhPWUdI?=
 =?utf-8?B?dGE3a0d1ZVlNc2dNeVNnZFJNVytkSFRJSFNaSXpLNzNSMytLem1LZDFxZC9r?=
 =?utf-8?B?ZUtHN2pPTTFsUGU1ck5GLzlkZ2xoT2xrcDRIMG5Ub3J5Vk5uYndFSkViSnJ5?=
 =?utf-8?B?eUxrV0dKMzJvbUZBTmRtVXFvWS9yMDJqVVFSOVRFRlEzM1p3WUtpODlDbW1M?=
 =?utf-8?B?eVI1M3dLVDRrcEVxOGFhK0F4Z3JBNXJqR1NyU010WXA3S0RpMVpqUEs1akZW?=
 =?utf-8?B?RCtsdzNlWXZ2MU4wVDdZbXlGcDU0KzR1QlU2ZnRNOU02RUEzaThwSXVzNC9t?=
 =?utf-8?B?ZnhURnYwV3ZXa2twWjJ2UC9vWGNJdlIwUnNqdzdtbmFBV1UxUERkZVJrUkdx?=
 =?utf-8?B?ZUhBTmlHd2FyMGMvd2p3VUxmWXBOMit0cVUwM2o5TGw1RHBYMnZGdGxRcXZo?=
 =?utf-8?B?TnBPektmS3YwNWFpRkU3bzlJYVpFNTU1OWV0KzlOWGV3Q1dHby9aUjhOVFZX?=
 =?utf-8?B?TEg2bUpaS28xTi9LWW9YSWFDeG9YMUJtR2Zoa3lIcUhGVWZHTHlPOWZ2bVlF?=
 =?utf-8?B?eDlveXBGblVZeGpGNkZqU2hEV2YrOEdVZ2NXK1RxZW5NUnNidVFSZCtKV1dQ?=
 =?utf-8?B?b05SbzBPM1F1M0VnTWRLdXdQV0NrWEgwT3hCWHJMK3hKRnllQkNRRGZzSmNm?=
 =?utf-8?B?ZXNtdzBuakNDSVZRQ1hBbGRVRGRUbFBsVXRlV3ZVY0d3bVVzdDZhS1o4TjVM?=
 =?utf-8?B?cDZoV29PVzN4RTJBVkZxYlEzaXM2RnpQeDR4aUVNRFE4aVhpOVFCanhkdFYx?=
 =?utf-8?B?VEl0aFprLzByZytGeEFVQmY5aWVTdWpGY2NsWmdOd3I5dktCVU91VUxST0dP?=
 =?utf-8?B?dldsVkh6R2xMb29ySUNJZHljTWo1TkhNTnBIeHVYT3lmRlRDRmRDYkdIaVll?=
 =?utf-8?B?OWJnblhyYlRaUTg3OWRMR2tCeFMrOEtkSyt3UlFYN3FYYWlpZkdGZTVOM1gw?=
 =?utf-8?B?bklMVS9VM2phblloZVNoVnp5QjNHZUQxYkJUVlQ0NG1MaXY2M1g3ZnNLKytE?=
 =?utf-8?B?UkkzR3VMbnBuVHROa3kvMkJEREFvRlYvb3RrSGtxSFBHMDVIc2Q4M1VLZlhD?=
 =?utf-8?B?bnc3Y1JLd08zZkNNU2xKc2EvTG1OdnhyMmRaK3dvOE1zSjFuSE9XUUJXVWpi?=
 =?utf-8?B?L3lwQm5rSU4zWUNPQVdTTytnZHlNQStUSWVqeUw0a3JwbGI4RHBnM2x0WVc2?=
 =?utf-8?B?T0RxLy9uTTllNWpaLzlTekx5Q0gvejJMaGZYT3JGcnkxem5TRmFyQVp2YWdm?=
 =?utf-8?B?R3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d02f9110-6923-4add-bbee-08da5e9418cc
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 14:38:59.3097
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 44Wo+6LlO2NxBkBtmVYHasSoQa9FibyV8dXvCDsVJ2G9Z7Bofbbb+Z1RwOy7thjPygLCxhYiTzNioXCvqXW28ZOyt+gSGODncOYm2ge6XWI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4858
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/5/2022 1:43 PM, Andy Shevchenko wrote:
> The struct resource is not used for anything else, so we can simplify
> the code a bit by using the helper function.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>


> ---
>   drivers/bus/hisi_lpc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index 6d432a07cbba..03d4d96ff794 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -618,7 +618,6 @@ static int hisi_lpc_probe(struct platform_device *pdev)
>   	struct logic_pio_hwaddr *range;
>   	struct hisi_lpc_dev *lpcdev;
>   	resource_size_t io_end;
> -	struct resource *res;
>   	int ret;
>   
>   	lpcdev = devm_kzalloc(dev, sizeof(*lpcdev), GFP_KERNEL);
> @@ -627,8 +626,7 @@ static int hisi_lpc_probe(struct platform_device *pdev)
>   
>   	spin_lock_init(&lpcdev->cycle_lock);
>   
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	lpcdev->membase = devm_ioremap_resource(dev, res);
> +	lpcdev->membase = devm_platform_ioremap_resource(pdev, 0);
>   	if (IS_ERR(lpcdev->membase))
>   		return PTR_ERR(lpcdev->membase);
>