Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c89c993e-7a7a-15df-85ef-8d9b7be16b71@intel.com>
Date:   Tue, 5 Jul 2022 15:51:04 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [Intel-wired-lan] ice: Error setting promisc mode on VSI 6
 (rc=-17) @ 5.18.x
Content-Language: en-US
To:     Thorsten Leemhuis <regressions@leemhuis.info>,
        Jaroslav Pulchart <jaroslav.pulchart@gooddata.com>,
        "Siwik, Grzegorz" <grzegorz.siwik@intel.com>,
        "Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>
CC:     <intel-wired-lan@lists.osuosl.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "regressions@lists.linux.dev" <regressions@lists.linux.dev>
References: <CAK8fFZ7m-KR57M_rYX6xZN39K89O=LGooYkKsu6HKt0Bs+x6xQ@mail.gmail.com>
 <2596b2c6-71e4-543f-799f-b4b174c21f31@leemhuis.info>
 <CAK8fFZ6hS69JMtnvFnLVt9aiWEivZ9-izNgMHtB+KeAWAfaXaQ@mail.gmail.com>
 <6f52ccd2-8411-0c53-2deb-885bb1234ce5@leemhuis.info>
From:   "Wilczynski, Michal" <michal.wilczynski@intel.com>
In-Reply-To: <6f52ccd2-8411-0c53-2deb-885bb1234ce5@leemhuis.info>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZnBCNkc4OHJJTDAvNCswYjZoVlJaTzA1KzUydFZGeXR1VzBOdEI2OUphbjU3?=
 =?utf-8?B?bEJiNUorQWs5bW04c3VnNXJrcVpoNDVMaUFLSmp1WHV4NkFVS2IrVWpmeC9k?=
 =?utf-8?B?MzAxSzlKMERzYmFoZFpaOUdLb1BrbE8vbi9mWCthRTdTTVRLMGI4dFB2c2pr?=
 =?utf-8?B?OUpmWnJRVUlaSGg5WU16cFcyL3BKR1hIcnhyZytUUzRWQ2Z1WlFaNlR6LzRG?=
 =?utf-8?B?SWp1SDFkVUtidVNUZS9zMXpOYnZBY3pCdTc1R21wV1ZOTFhBMlJpVURqcFhX?=
 =?utf-8?B?RmF3VzY0Z3hSN2NFcFBUL0RTZEZWbG02bFYva2xzU05IZGVRbjNpYzlSR3hM?=
 =?utf-8?B?OTVBaXF0RFAzQjZ2L2RpWXF3bG1aNjJrblY0S0ROcWpvSk16MFNjTSthNkg5?=
 =?utf-8?B?c2RoRnl6RFBIS0hESWFZN25ZR0ozN1JQS1phcThPWXREVkI2WDUzS1ZidThz?=
 =?utf-8?B?ZkROQnphQ0F0SkIwNi9sTG9pbi9QVExjZGZ5b1FJZXBycnlXNUtBMTFSbTIv?=
 =?utf-8?B?VUdnRGJ0Nm9NTXNyRFNoK0VmSDk0MGVPNXU3QTN2cFl0N2VEeEZVQkx0RzFt?=
 =?utf-8?B?STRqUVZZZGFrL0RlRmsxVmVsM25XdVRjeGtjM3F0d3pBL0VVdjFIUWZ5Q3ky?=
 =?utf-8?B?UDA2Z2duL295bGhONUdQWHhVMFg5Tkw4d1NuVFg2a0hMbXdFbVRIa2h6bkJG?=
 =?utf-8?B?dWR6MEdiVjlDN3gzY2tCN1NuNEloTHlMeEE1U2NnaE5icjJuSDlubGdnRUFs?=
 =?utf-8?B?UTRHQXMyNDV5TVpZdDFQaFdiN2FoM0ZGWGQ5UUJlMkxNR0ZQd3g4THZ0Q0Vx?=
 =?utf-8?B?U0ZLeXZ2MHV2UnUzQWdQVURWYVhlRGl4RFprd0VlQUVwR0w4VzdNa21DcUZ2?=
 =?utf-8?B?MWEvS3RKRkViWmJuUS9nRGFyR25PMzRiK2ZsVnpqbFZQbXV1VW80S1Z1TWZn?=
 =?utf-8?B?eDJKMWxNOUlsSjNxTHhBclk2dVp3YTJMM0VseWwvbnlkUzdadEh1MGlCZWFC?=
 =?utf-8?B?N0txR3ZTNEFmdDZCc3AzcFp4SXhnZUVqV3o5cFlvVXNzY0IrRWh6YXR3Y2FW?=
 =?utf-8?B?UnprZHcxMGpJOXFnaVErS0Z3Mm1yd0ZEYnNRenU1WFFPV1BjeldHSVFHakRm?=
 =?utf-8?B?aExvWVpzSHBZNkF2b0tpQWdwaFpJOUhLYnczY3ZwZDFNRXQ0NWhPbXpuVmRm?=
 =?utf-8?B?VWpZL0dUa05LdEJrTHFJcEZZeG1DaTNVZk8yVUFvWmpzODBpMnFLWjdPajRH?=
 =?utf-8?B?cVJ1cXVYUWNMd0lieUNPUGFqUDBSYlR4VkxZcmEwbWxQdUE1WjZSa2VhM1Yv?=
 =?utf-8?B?R0d5dUdEQURNMkxKa3I4ZFVYcDFVQk9WWVFZZGhrV2dFTE9aRGF6cHdYVHNO?=
 =?utf-8?B?OUhrLzFobkZsUmVjWWhZUTB1dnJISGhBbFkvVjFyWUhQNEpkbGJySjBPUXBC?=
 =?utf-8?B?Qk41b1FJL25aZ1VkUjRzZjd3Rk9wNVM4cWR6SUFQekovQnZqQ3kvb29oNnFT?=
 =?utf-8?B?QnVMbUI2YWVGRkhXcklSOFI2dUg5RzAvSW8zTEpLRFR3VUVQR2pOeDF4QTh5?=
 =?utf-8?B?UXUwRjJwbllMbFBHQjJocStmN2JyVU1qQTFYYVpDSzVScXVwekswdGV3cXBv?=
 =?utf-8?B?ZDFaUmhLdzVncW5lK3QyajlsSzJKaGFVbytwd0hLWDJ2Mld0TThYRGthLzg3?=
 =?utf-8?B?NTRmS29YYyt2eXpSQ3IwODJjK2lGVXZLa2tSOWhuUWRFNkJYN3ppSy9IT3Fo?=
 =?utf-8?B?VmV5MWNsSjNjQ0o3cmpyUmwzZCszNEFPRDdQRnBibnBIVmRHME5XUzdwMW9J?=
 =?utf-8?B?TzNnNjJlYTBKUDNTK3E3U1A4eDd1V3FKcjJzdDhIY3hkN0w1bWp6SUg1R05j?=
 =?utf-8?B?QWpHWXpYTm16SkRSeE5QWlBmdHh6WUJqa2dHT0xyYTdEQkg4SzZlcXM2M1J5?=
 =?utf-8?B?VU1TRksrWFQ3b0NmdmRYc2p5c0lnK0E3cTRqNVFBanV4eUxUdkFqN1RBb1pS?=
 =?utf-8?B?UVVDN1c0d2FXOTN4R0YzYWkzb0tsTmZxZ0xvSmRvOVozelpXK0VVOFA1MmJz?=
 =?utf-8?B?OS91U093MnIrMzUvam1pTHljMXNQRjlIQUtkUUpYeFpvdzM0S3EwVjFwaGNH?=
 =?utf-8?B?UEpsUkxQSUlpY0hySGRuMjlUZXBMT3NnTmJYVU8xUTNpSnVzd0Y5QjIzanh3?=
 =?utf-8?B?b3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8da4a85c-2f15-49ae-cdc4-08da5e8d6b25
X-MS-Exchange-CrossTenant-AuthSource: CO6PR11MB5603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 13:51:11.0042
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /KDtk2ycZW2SLKKJ+Sk/R+4uOPOF6NztGgedePA9Pe/Y3gP3td2sgKovbnkka87Zon+TTVgS87duMOPu2VI7eCp/DKWdty4ct4Y7fCJnVSY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5135
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

Thanks for your e-mail, unfortunately my patch is not fixing this issue.

Adding Grzegorz Siwik,  since he is working on similar issue and already 
has a patch that is being tested/reviewed internally at the moment.

He can you a send patch tomorrow so you can test if it also fixes your 
problem.


BR,

Michał


On 7/5/2022 11:43 AM, Thorsten Leemhuis wrote:
> [adding Michal to the recipients]
>
> Hi, this is your Linux kernel regression tracker. Top-posting for once,
> to make this easily accessible to everyone.
>
> Intel network maintainers, help me out here please. Has anything been
> done to address this regression? It looks like Jaroslav didn't even get
> a single reply. What's up there?
>
> BTW, took a quick look into the issue and noticed a the patch "ice: Fix
> promiscuous mode not turning off" from Michal:
> https://lore.kernel.org/all/20220704131227.2966160-3-michal.wilczynski@intel.com/
>
> Is this maybe fixing this? Then it would be good to add Link and
> Reported-by tags to that patch.
>
> Or is this something else and Jaroslav needs to bisect?
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>
> P.S.: As the Linux kernel's regression tracker I deal with a lot of
> reports and sometimes miss something important when writing mails like
> this. If that's the case here, don't hesitate to tell me in a public
> reply, it's in everyone's interest to set the public record straight.
>
> #regzbot poke
>
> On 19.06.22 19:00, Jaroslav Pulchart wrote:
>> Hello,
>>
>> yes, I revert that commit. Still the promiscs cannot be set and the dmesg
>> error message changed to:
>> ---------------
>> $ ip link set em1 promisc on
>> $ dmesg
>> ...
>> ice 0000:63:00.0 em1: Error setting Multicast promiscuous mode on VSI 6
>> ...
>> ---------------
>>
>> Jaroslav P.
>>
>> ne 19. 6. 2022 v 13:51 odesílatel Thorsten Leemhuis
>> <regressions@leemhuis.info> napsal:
>>
>>> [TLDR: I'm adding this regression report to the list of tracked
>>> regressions; all text from me you find below is based on a few templates
>>> paragraphs you might have encountered already already in similar form.]
>>>
>>> Hi, this is your Linux kernel regression tracker.
>>>
>>> On 09.06.22 08:58, Jaroslav Pulchart wrote:
>>>> I'm struggling with broken network connectivity at VMs using linux
>>>> bridge at host after update of kernel from 5.17.x to 5.18.x @ Dell
>>>> R750 server with E810-XXV NICs.
>>>>
>>>> I noticed the kernel reports "Error setting promisc mode" in dmesg.
>>>>
>>>> # dmesg  | grep 'Error setting promisc'
>>>> [   24.863557] ice 0000:31:00.0: Error setting promisc mode on VSI 6 (rc=-17)
>>>> [   24.878369] ice 0000:31:00.0: Error setting promisc mode on VSI 6 (rc=-17)
>>>> [   25.045834] ice 0000:31:00.0: Error setting promisc mode on VSI 6 (rc=-17)
>>>> [   25.129840] ice 0000:b1:00.0: Error setting promisc mode on VSI 6 (rc=-17)
>>>> [   25.144440] ice 0000:b1:00.0: Error setting promisc mode on VSI 6 (rc=-17)
>>>>
>>>> # lspci -s 0000:31:00.0
>>>> 31:00.0 Ethernet controller: Intel Corporation Ethernet Controller
>>>> E810-XXV for SFP (rev 02)
>>>> # lspci -s 0000:b1:00.0
>>>> b1:00.0 Ethernet controller: Intel Corporation Ethernet Controller
>>>> E810-XXV for SFP (rev 02)
>>>>
>>>> It is easy to reproduce by:
>>>>    # ip link set em1 promisc on
>>>>    # dmesg -T | tail -n 1
>>>>    [Thu Jun  9 08:48:19 2022] ice 0000:31:00.0: Error setting promisc
>>>> mode on VSI 6 (rc=-17)
>>>>
>>>> Could it be an 'ice' driver bug introduced in the 5.18 kernel?
>>> CCing the regression mailing list, as it should be in the loop for all
>>> regressions, as explained here:
>>> https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html
>>>
>>> Jaroslav, did you try to revert the change that was suggested to you in
>>> https://lore.kernel.org/all/d993bbb6-e583-5d91-76c0-841cc5da86af@roeck-us.net/
>>> Did it help?
>>>
>>> Anyway: To be sure below issue doesn't fall through the cracks
>>> unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking
>>> bot:
>>>
>>> #regzbot ^introduced v5.17 to v5.18
>>> #regzbot title net: ice: Error setting promisc mode on VSI 6 (rc=-17) @
>>> 5.18.x
>>> #regzbot monitor
>>> https://lore.kernel.org/all/CAK8fFZ68+xZ2Z0vDWnihF8PeJKEmEwCyyF-8W9PCZJTd8zfp-A@mail.gmail.com/
>>> #regzbot monitor
>>> https://lore.kernel.org/all/CAK8fFZ61mQ3AYpdWjWtyUXzrs-RVMW61mBLrjRDXBxB-F9GzbA@mail.gmail.com/
>>> #regzbot ignore-activity
>>>
>>> This isn't a regression? This issue or a fix for it are already
>>> discussed somewhere else? It was fixed already? You want to clarify when
>>> the regression started to happen? Or point out I got the title or
>>> something else totally wrong? Then just reply -- ideally with also
>>> telling regzbot about it, as explained here:
>>> https://linux-regtracking.leemhuis.info/tracked-regression/
>>>
>>> Reminder for developers: When fixing the issue, add 'Link:' tags
>>> pointing to the report (the mail this one replied to), as the kernel's
>>> documentation call for; above page explains why this is important for
>>> tracked regressions.
>>>
>>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>>>
>>> P.S.: As the Linux kernel's regression tracker I deal with a lot of
>>> reports and sometimes miss something important when writing mails like
>>> this. If that's the case here, don't hesitate to tell me in a public
>>> reply, it's in everyone's interest to set the public record straight.
>>