Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <93547c1e-76c6-c5af-ca9b-27053a9e26a3@intel.com>
Date:   Tue, 5 Jul 2022 16:39:40 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v1 3/4] bus: hisi_lpc: Correct error code for timeout
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        <linux-kernel@vger.kernel.org>
CC:     <john.garry@huawei.com>
References: <20220705114312.86164-1-andriy.shevchenko@linux.intel.com>
 <20220705114312.86164-3-andriy.shevchenko@linux.intel.com>
From:   "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Organization: Intel Technology Poland Sp. z o. o., KRS 101882, ul. Slowackiego
 173, 80-298 Gdansk
In-Reply-To: <20220705114312.86164-3-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTBVZUxMS2t4UnY4ZHcxN3N2Rjc3bjJiblhVbVZ4MHYvTHNzN05jLzBBK2xD?=
 =?utf-8?B?dFJUcnpxaElUSFZsbUtTWXhJV0FVNS9XU01PNmZ1VTZZanduRFh0WVBmY1hx?=
 =?utf-8?B?UXNBTXlXVE5hdS91YUd2WDZoL3RaUTY4WGhTaE5GK1FuUmJHdnM4TWRPVHNH?=
 =?utf-8?B?dkZFMXV2ZkpoblFWZHZsRkdha1pucGcyZzQ0VGxvK2tHWmVRaUoxUnFQWng1?=
 =?utf-8?B?ODBIcXdGbmcyaDJPS29zeUp4ekFIdWtpYVNVVk9EMngwc3ZxcXlMSW0zaEs2?=
 =?utf-8?B?Y0lMQys4K0hYd3NQWDA0ajVuZ0RQMVpFU0ZNdWk0MEdwYmNPcXh1VXh3SUpD?=
 =?utf-8?B?ZUVpanFuVlFDS3N1ZGswek0yU3BNSlRVQ3NjSENCSmNUZzUzd0tLa2J5aDBJ?=
 =?utf-8?B?bGlrY0Zya0FvOUlFbHdqOVVYM0w2aUFEM2FCSWlLTjUzQU10UEpTR0pkUUtj?=
 =?utf-8?B?Qm9xNDdEaEI1Q0prNys4TmxhZENPUTJ3UU5HanljWExDd3VhOHRpNzFxMkQ0?=
 =?utf-8?B?RmpFM1ZrVTdmb0JCWStUMktRdFltM2RwTjBYbkQ5aldBalRkMjlIdzFQalFk?=
 =?utf-8?B?UGJ2bzBnZHpBKy9Nd0JsTklNalFRWE9tbVJDQVY1Y2NkY0xrd1JxaW5DRFlB?=
 =?utf-8?B?Y3BiaXhuZXMzZXBwYklVR2JuTXkwNHB2RVl3WElCYUV0ZGJYRUpsMk9saktj?=
 =?utf-8?B?anhkeGxMYVBldzI0ZGhPRW9WdkNwMVV3eG15eWU1aFhIQmIwOGwwcEJYRFJF?=
 =?utf-8?B?bUFydXROUy9NMWtkZVhLd0d6SllIUC9FRVErNjJPS0RSVXdnWTUwL3RCN20x?=
 =?utf-8?B?aVZoWkxNVS9XbkJTNy95YjRiTjl6ZE9VcW1LbVJYTnpDQk9aQWtWZHlpekJR?=
 =?utf-8?B?QjRKTmJtZzAwd3BMNERLRWlBSE5vdXp2MG9FWHpwZEpNaUFZV1U5c2NFNkpl?=
 =?utf-8?B?TU5HNFF4dzJWcjhTV3NCWDdSU3E5RE15UUhoNmt3L2hYSHVJTGFlSnI4Rm1T?=
 =?utf-8?B?eldmanJxcWNHd2d4RTdEMUtOYmJFdEhMWVR6RC9MdUp2ckpZZjk5L0RPSFFL?=
 =?utf-8?B?VjJ0NVg2TXVYYzFKejQxbTVOd0dWdExCeHJubm4xRlFVa2pxMEcyRnVPbkxw?=
 =?utf-8?B?WmtFdStWWGR1d0ZZSVljMzNmUGR3NDhmcDdLMVkydlNyNTlGSWJIamhyYU1Q?=
 =?utf-8?B?MnVHSFR4V3BYZXRKOFlkUlZqT0xvdCtqWDVSUlFyZXlwWE5FeXo2R1p5azM2?=
 =?utf-8?B?OVUzY2w0V2ROZ1Ewb2llSjhXYWdoUDNvb1ZaM0dYSDZqTStUZUg0TFB2RGdV?=
 =?utf-8?B?SHBSUEVWb045V05IdUdLWHFDYTZSQnRyc1JRQWJhSWJMWUZEYWowMmp4YXZI?=
 =?utf-8?B?cE16b2NTUjl4NTErMnhTeFJPV1RSM3doTEpMQXRTeWZuOEZFc25wTEFEekR1?=
 =?utf-8?B?aEpxSWlnd3JEek0zSlZSRWhpclJPdG9zanJvd09PUUZyc2JFUzVLdDgwTDBG?=
 =?utf-8?B?QVhXL3piNmRQUHlodXJzdWJpSnhUSmd6UW8vRy92YzU1N3RwOGpCYzRYcVVp?=
 =?utf-8?B?YkI2d2lkWmprUlhmSnZQajFaY2phbXZJdmdPeWFLVzJrWU85TE1pV0czQVJ6?=
 =?utf-8?B?TkY4cXA3Q2Vmb0ViU0lON1ZVNEdyZjNQYzdVQ3VyblBEYU5NNXI1US9sTVBq?=
 =?utf-8?B?SlNoSlV6ckdUZFlWaUNlUFlMNnFpbnRObzlUN3MzcmZCSjltT3dzdGdGeXZo?=
 =?utf-8?B?TUV4UUJZOHZJa0c3NUR1NHl0SWxKUXA1ODB6dXFrYU0rL2E0NWRYcjdKWTRD?=
 =?utf-8?B?RnNHQ2NHczJNZlFXWFQ1Y2I3KzJQOS9VOFhyZEJUV1ljTER4cEdFeFlSamJD?=
 =?utf-8?B?NzBENXJUZVorN1RtMjBxTEl3dzZPd2Q4R2ZTY1ZMTTJLRUZTNjAzSU4xem9Q?=
 =?utf-8?B?NnZvbFo0Y1Q1KzZFUkg4cXZoT2xsL0dhMmpyYTU2aDBkaUNqWlpmdjhLSDBP?=
 =?utf-8?B?ZlZWKyt1Y0MvZm8yUVFlUEZPUlVqRlVubDI0bm9jVFpkdFExRkFvbXJlcndt?=
 =?utf-8?B?cUUwOVpCUW1Bd3hEamNJcUdOSXkvVkNObFRMNVVHalM4d3V4UlFjVGFxNGxH?=
 =?utf-8?B?dklKYlprTUx5NjBTNm8wRDdvSzhXNC8rdit1NEVwRzdBdFZUMGVOTFlxNkxH?=
 =?utf-8?B?a3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 288144c4-506a-404d-da15-08da5e9434b4
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 14:39:46.1128
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CfvjBKBxwFqNDYwqdzWj2QseIaJbQVTNMYR94HoTp07QaTGysmVpSiSlIsMUemqsgwQm89Sp1eJ9deq0wRELL3BcCUeqT3GTEey2Sc0Zclo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2214
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/5/2022 1:43 PM, Andy Shevchenko wrote:
> The usual error code is -ETIMEDOUT, the currently used -ETIME is specific
> for timers.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>


> ---
>   drivers/bus/hisi_lpc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c
> index 03d4d96ff794..a6513a571d7b 100644
> --- a/drivers/bus/hisi_lpc.c
> +++ b/drivers/bus/hisi_lpc.c
> @@ -85,7 +85,7 @@ static int wait_lpc_idle(void __iomem *mbase, unsigned int waitcnt)
>   		ndelay(LPC_NSEC_PERWAIT);
>   	} while (--waitcnt);
>   
> -	return -ETIME;
> +	return -ETIMEDOUT;
>   }
>   
>   /*