Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Han Xu <han.xu@nxp.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Bough Chen <haibo.chen@nxp.com>,
        "ashish.kumar@nxp.com" <ashish.kumar@nxp.com>,
        "yogeshgaur.83@gmail.com" <yogeshgaur.83@gmail.com>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "singh.kuldeep87k@gmail.com" <singh.kuldeep87k@gmail.com>,
        "tudor.ambarus@microchip.com" <tudor.ambarus@microchip.com>,
        "p.yadav@ti.com" <p.yadav@ti.com>,
        "michael@walle.cc" <michael@walle.cc>,
        "miquel.raynal@bootlin.com" <miquel.raynal@bootlin.com>,
        "richard@nod.at" <richard@nod.at>,
        "vigneshr@ti.com" <vigneshr@ti.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>
CC:     "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "zhengxunli@mxic.com.tw" <zhengxunli@mxic.com.tw>
Subject: RE: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new property
 nxp,fspi-dll-slvdly
Thread-Topic: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new property
 nxp,fspi-dll-slvdly
Thread-Index: AQHYkFF0qJujufsOTUOD0eIhHoBTUq1viBIAgAALOQCAAAJgAIAAKZ1ggAAGgYCAAAdCYA==
Date:   Tue, 5 Jul 2022 14:00:37 +0000
Message-ID: <DU2PR04MB877492F346BAA10B2AA7428497819@DU2PR04MB8774.eurprd04.prod.outlook.com>
References: <1657012303-6464-1-git-send-email-haibo.chen@nxp.com>
 <1657012303-6464-7-git-send-email-haibo.chen@nxp.com>
 <ef676df1-77e0-b8ee-3950-97eade8ddd5b@linaro.org>
 <VI1PR04MB40167A70FBE772DF91047A4190819@VI1PR04MB4016.eurprd04.prod.outlook.com>
 <59d360ef-5374-c7a7-2995-854ab3715b25@linaro.org>
 <DU2PR04MB87747C9A8F18D8300461D6B197819@DU2PR04MB8774.eurprd04.prod.outlook.com>
 <f33ad190-f5c7-d9fa-088b-5538ab1f4d59@linaro.org>
In-Reply-To: <f33ad190-f5c7-d9fa-088b-5538ab1f4d59@linaro.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vJgDtwWxtyN0I6VWpHsG+BDes+WIBHtppQFkf0gTDf0D2Euef52QfDbCqc62?=
 =?us-ascii?Q?O7iRxaL0P81PFq3mUyIFI2KEqoWQpxTaifaavYOPYKVSyJ3PCcRdWGNKkeva?=
 =?us-ascii?Q?jnc9ApprbB1BfhHYzIXDZ5ehUEN1db3AN0j18GSp28LWnOxSbmDoD7y8zCrr?=
 =?us-ascii?Q?sThDoAdILo1alRF/NDpDQf5eyCxP3vRybuh4+o/aWxQ9jpSxdd09+WTlw06g?=
 =?us-ascii?Q?olUG0FFP9DAYbPfQZXQplgZpGyYDyjjFOkJkw1XoY/z1dG6auSzRG4yIxd9W?=
 =?us-ascii?Q?jUX5BGqzXQ8uRkPfa+AAkYKtVEBw40Azy+dBl/FVsctik45b/eSz29U+Pw/l?=
 =?us-ascii?Q?WR0v1X3G4il2AtYi0ZwKx35UEushUVVE6k+NV7WWccOK7sr+CLKECtnOAdZG?=
 =?us-ascii?Q?GA4NF/tzAJVOrNo1D56FA5dzWWkkSoLwcXmXhg/hUazSTx/nFKFofMbtQyda?=
 =?us-ascii?Q?ZjKxKObHZE/bCb70/lXaBCe8n4FI9luhTWVsNkH/nnJpPlO38O12JKP/vHTi?=
 =?us-ascii?Q?obBhcmt3eB6W0BkBLP5Y2zbHFydWo1EB3dGT1oxc3chWcTvjrOU64MBe2yae?=
 =?us-ascii?Q?IUIlZUZ3ZNeGunzyDQfIYDehbKcqFoD26Den7KO7WNT/OW9LONzU8mdX3VTm?=
 =?us-ascii?Q?/S6PpgQYYUeIe4yGQkXjw67uy0+3r92/Fb47JgzAAXqwZSX8xNyor/ZybPX8?=
 =?us-ascii?Q?Gs5p3VmwYni/D1BZu+59E+gTmTO4vcleTsPHI9ZkbiLZXIvdzstLH/S23Gp6?=
 =?us-ascii?Q?6x5fnE5lya7M+YxJ8SxBOcEBu+QAhlQOG8Y/DqbkmhxMe21kiapCckJirwLY?=
 =?us-ascii?Q?PlJ4SY0vNuebsA03HjioDAkMC+/YbrhBWPfSxatWUncUbpMvWWv/wVoAmJnd?=
 =?us-ascii?Q?OshGyX7yPscDTFqQCYgGeMk1m+oLqpsmQI4xYFP6j88FheSNGLHcYE6YJx4/?=
 =?us-ascii?Q?VDsAkmB9LuVDyEnOsdBz/qGkR4P9ygHHfFkfIqYTu0T7qiSx2TuUe5HKM1cD?=
 =?us-ascii?Q?v5iY/dTTa3N6s/hXj15w6Gd/mB3ZeSnIpNGoFrxqpfE0o1sqDOXf0HMy58VK?=
 =?us-ascii?Q?2xHGtpHfyjDbHC1hf28EWY2jYQeAfbeJEGSuPHfdmV5M648PHRzddVm2WSa6?=
 =?us-ascii?Q?dMt6Nivkg8hlaM86nPE/xDIx5Mxx8+/ixpBKD9yu+kt9yp7x+3hdX5Ah4mAx?=
 =?us-ascii?Q?PmZRCAOh6MfJ7gr6G/wDNI3cUM5b/ngkDzcEVYkzPYfGIzdbrOg6EhfFT8jL?=
 =?us-ascii?Q?Ru3vZZ+1LxfkCnvwbqrfRZx2jtABcVq84N+lAzjUwAUMQz3vTKZEdQBypFNm?=
 =?us-ascii?Q?YrKmR0wHkFTRA21LE9ep5FjZ+FgGJnll4w/i36a+7s2l2jXO11IuU9hnPYjo?=
 =?us-ascii?Q?nnmXRJ2kuS78G1kcmOaJsoGTHzeuEghm5S3P+gWCD67LPagS/SpB6eo+cnQW?=
 =?us-ascii?Q?l6KiySzBGQkIWq2wIIhDNMXyZI2P971u4wysasG7Goyq0v2w7eEQFM5CKYmJ?=
 =?us-ascii?Q?XDd9ceadowp13kaqALgfhGl+jjfxRyg2ISIgUWmzGHWpN+FH3A1FCXbHeZZc?=
 =?us-ascii?Q?BhakO19Q3+YtMbPomek=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a5fd2f1a-8373-4ad0-2e9a-08da5e8ebd16
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2022 14:00:37.6748
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bCwaOY20+9RpApNwbl/jfdpVrk8jRvU4ldeBc9payoShnsE3sLN4N4HWXWF5Ps+d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8821
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


>-----Original Message-----
>From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Sent: Tuesday, July 5, 2022 8:29 AM
>To: Han Xu <han.xu@nxp.com>; Bough Chen <haibo.chen@nxp.com>;
>ashish.kumar@nxp.com; yogeshgaur.83@gmail.com; broonie@kernel.org;
>robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
>singh.kuldeep87k@gmail.com; tudor.ambarus@microchip.com; p.yadav@ti.com;
>michael@walle.cc; miquel.raynal@bootlin.com; richard@nod.at; vigneshr@ti.c=
om;
>shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de
>Cc: linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org;
>devicetree@vger.kernel.org; linux-mtd@lists.infradead.org; festevam@gmail.=
com;
>dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org;
>zhengxunli@mxic.com.tw
>Subject: Re: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new prope=
rty
>nxp,fspi-dll-slvdly
>
>On 05/07/2022 15:19, Han Xu wrote:
>>>>>> +  nxp,fspi-dll-slvdly:
>>>>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>>>>> +    description: |
>>>>>> +      Specify the DLL slave line delay value.
>>>>>
>>>>> What are the units?
>>>>
>>>> Do you mean here need to give more detail explain about this properity=
?
>>>>
>>>> How about change like this?
>>>>    Specify the DLL slave line delay value. The delay target for slave =
delay line is:
>>> ((nxp,fspi-dll-slvdly+1) * 1/32 * clock cycle of reference clock (seria=
l root clock).
>>>
>>> This would be good.
>>>
>>>> The range of this value is 0~16.
>>>
>>> This needs to go to schema instead as "maximum: 16".
>>>
>>> But still the question is - what are the units used in this "delay"? ms=
? us?
>>
>> HI Krzysztof,
>>
>> According to the formula, the range should be 0~15, 16 should do nothing=
 or no
>delay.
>
>Sure, just add some constraint.
>
>>
>> The unit should be clock phase. In other words, the delay can be in rang=
e of
>1/32~1/2 clock cycle.
>
>So we probably misunderstood each other... looking at the driver it also e=
xplains
>the confusing. You encoded here register value which is pretty often wrong
>approach.
>
>This should be instead meaningful value for the user of the bindings, so u=
sually
>using one of property units:
>https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub=
.com
>%2Fdevicetree-org%2Fdt-
>schema%2Fblob%2Fmain%2Fdtschema%2Fschemas%2Fproperty-
>units.yaml&amp;data=3D05%7C01%7Chan.xu%40nxp.com%7C0ffe3d706e064f14382
>108da5e8a5add%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6379262
>45564450475%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV
>2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=3DQ4
>SfVnBN%2BQ0vYKJzRf%2FXZkCA1WGyPV9doFcb%2BLSKx4w%3D&amp;reserved=3D0
>
>I think you could use here clock cycles or clock phase, but then it has to=
 be obvious
>it is that unit.

Hi Krzysztof,=20

Let me clarify it, in the document a term "delay cell" was used to descript=
 this register bit. Each delay cell equals "1/32 clock phase", so the unit =
of delay cell is clock phase. The value user need set in DT just number to =
define how many delay cells needed.

>
>Best regards,
>Krzysztof