Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Jul 2022 16:07:27 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Michael Walle <michael@walle.cc>
Cc:     Han Xu <han.xu@nxp.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Bough Chen <haibo.chen@nxp.com>, ashish.kumar@nxp.com,
        yogeshgaur.83@gmail.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, singh.kuldeep87k@gmail.com,
        tudor.ambarus@microchip.com, p.yadav@ti.com,
        miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
        festevam@gmail.com, dl-linux-imx <linux-imx@nxp.com>,
        linux-arm-kernel@lists.infradead.org, zhengxunli@mxic.com.tw
Subject: Re: [PATCH 07/11] dt-bindings: spi: spi-nxp-fspi: add a new property
 nxp,fspi-dll-slvdly
Message-ID: <YsRTryAlyJjm9A9+@sirena.org.uk>
References: <ef676df1-77e0-b8ee-3950-97eade8ddd5b@linaro.org>
 <VI1PR04MB40167A70FBE772DF91047A4190819@VI1PR04MB4016.eurprd04.prod.outlook.com>
 <59d360ef-5374-c7a7-2995-854ab3715b25@linaro.org>
 <DU2PR04MB87747C9A8F18D8300461D6B197819@DU2PR04MB8774.eurprd04.prod.outlook.com>
 <f33ad190-f5c7-d9fa-088b-5538ab1f4d59@linaro.org>
 <DU2PR04MB877492F346BAA10B2AA7428497819@DU2PR04MB8774.eurprd04.prod.outlook.com>
 <62f113a0cdb0d58bf04ab0b274912eb7@walle.cc>
 <be521f90-97ce-c61d-d7d6-8f2bde24d824@linaro.org>
 <20220705145226.tarpvub6bh67tj63@umbrella>
 <d4a69511eea5195b2ee7726bda5a8a33@walle.cc>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4udQM6FbAizsjM/e"
Content-Disposition: inline
In-Reply-To: <d4a69511eea5195b2ee7726bda5a8a33@walle.cc>
Precedence: bulk


--4udQM6FbAizsjM/e
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 05, 2022 at 04:58:40PM +0200, Michael Walle wrote:
> Am 2022-07-05 16:52, schrieb Han Xu:

> > IMO, use the unit "-degrees" makes it more complicate. Personaly I would
> > calculate how many clock cycle delay needed, such as 1/4 clock cycle or
> > half
> > clock cycle. Using degree brings extra calculation.

> What is the extra calculation here? For hardware engineer who has to
> specify this, it is easier to give the delay in clock phase (in degrees)
> rather than reading the documentation and transform that into a value
> given in 1/32 part of a clock, that should be part of the driver.

IME if it's a hardware engineer specifying things by the time they get
as far as a software engineer they'll often have been turned into "write
these values to these registers".

--4udQM6FbAizsjM/e
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLEU68ACgkQJNaLcl1U
h9Bu8Af9EyBCmFmk3mzR3XypchGxUzMgpzu2lp5Y+4noP+jzxwkCC3HmaqS24VvW
ft41g07lerfiYg2kCb86XMAlb5nXgdc1gaEAYS8tSRgiurRz/h1k1hq7sq2TGVr3
AfWFGc5K/k3oPRjMEfgrC+ozTPuEV6UNC4nOANcB7S6fXNT4IHIw2K/gN6iNcoZW
iaygnVrlyXUCEOiR+vy+lBZU3xKJkw0zblwhobVpxJC3PhDIybaJPSB2i/BHJgQM
BpcI3Axig8k6h15SZQzbO7KkHzRtw0SdAEUyDNsmqkhN4Hrm3oHZj27LIV4BFl80
YmBtn2mAnbCpa1u65sUZvTfFHSzMAQ==
=DJMN
-----END PGP SIGNATURE-----

--4udQM6FbAizsjM/e--