Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d6b52455-87d6-2125-55ce-bdc7aa522085@intel.com>
Date:   Tue, 5 Jul 2022 18:14:54 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.10.0
Subject: Re: [PATCH v3 1/1] ASoC: Intel: catpt: remove duplicating driver data
 retrieval
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
CC:     Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
        Bard Liao <yung-chuan.liao@linux.intel.com>,
        Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
        Kai Vehmanen <kai.vehmanen@linux.intel.com>,
        Mark Brown <broonie@kernel.org>,
        "Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
References: <20220705155813.75917-1-andriy.shevchenko@linux.intel.com>
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <20220705155813.75917-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MkxEWE9Fb2loM0VNR3FKUGxYUXY4WVp2d05QK1cwdzRGNjlsdkRwV09XcjRE?=
 =?utf-8?B?aGJ3cWNKN0RCZHFhb3oveDI5emF1VTljVWJIZy8vOGpjOWw2Q0dRQVg1eWxY?=
 =?utf-8?B?Q3Z2OXdYajlKTWwwbCt3NGtYN2ZCRGJFMG1tYVlWb3ZpT2ZlN05JUUF4amVB?=
 =?utf-8?B?d2NhTG9aZ2N5RkdwWUJoOUlxU0M3OFJSOGR0Z1haYzI2dnY4cVZ0Wlp3dk0y?=
 =?utf-8?B?ekdZc3haeHJnVytLaUZwcjFZenVuMldWaDRMamFQcGJmRUwwUDFsWkoxajlM?=
 =?utf-8?B?aVpaTHVqcHhsQlJVTDlWb1ZISm9TYlFMWmtJSThXYXA1RThkTkxINFUwejgr?=
 =?utf-8?B?NlczK1ZNYkhLK0xBL2hQVzBpcWxxNVRReldHaURWWG9NUmxiVVpFeVNqcWIr?=
 =?utf-8?B?Z2owZWM5WXU5ZXlFME1ON3RaME5zTHZhN0lwSUpweUZoVUw0dVZobHl3b0ls?=
 =?utf-8?B?bTIwbVAzT1k4SzVlakFCQ05xenhCem5PVHNpYkJjOXNwZ0RHQzVmREplOXdB?=
 =?utf-8?B?aUlERzJLU09WWVYzOGYwaVI0VXgrN1IxZWkvZ3JBU05RdWFoV01WQWx4MFI3?=
 =?utf-8?B?cHFPWE9CNmVocE5FYUdXd253ekdSMVRGUXNlSVhONk5qZXI5R1FXNTlCeFdu?=
 =?utf-8?B?NUZKRkdYSnlWRVNCd0ZySGk1cTZmbVNYQTJtZWJrNlBFOEpTRlREQStjT1Bs?=
 =?utf-8?B?YnVvaDBmZkNSZDYyTElIQ0VHTkJ3QmV0M0VPcU5nQkFKZHF6Yk45amxobEt2?=
 =?utf-8?B?UlM0dG9LUEczMWtjTTBnbTQ2cVF0b3FSUEc5d24vT20yLzh4U25mMnJBcDZ2?=
 =?utf-8?B?dDBkRWVlVDZEVHU1aDk5dkU0aXRzTER1d3JoejBtbkwvRE5xZDhZS3ZKZ01L?=
 =?utf-8?B?N3FHN0gzcy9WbWMyaSsrUUhubGlsbDhzYW1tQVVsK1ZkMklMU2dWNUdTellH?=
 =?utf-8?B?MDg0YTVaVTRudTY5TlZtVGwxUnVLcitjS0lQNWZsbEZmOW1RSG4xSjROa0Vj?=
 =?utf-8?B?aElLeVVKcUJpOGdSeFBLSUQwSnlwV0VZWENZVG52NXM5U2FDcnN4UDE4WGZT?=
 =?utf-8?B?eHJqckxHT3FmZlRGSStBUTJFOWkvZ1lKais4UlFiajFaN0dldDl6TWdseVc4?=
 =?utf-8?B?S0VkNzBVYmhWa1EwdEdKQ2NBWHlTNUFILytJdkxwRmpTdlE5aGlLaDRQUG1n?=
 =?utf-8?B?RmI3OHZYc2QrckR5Ti9NMWZScUlTNEk3VzVvREZiQk5lb0VNZzA0VHF3aEhB?=
 =?utf-8?B?VTIvbHVISG1JamhVc2RwaDAzaWM2aGRvVjljNHJ4b1R1djdNcGdZK0JzbHBP?=
 =?utf-8?B?WXdmOUNiY0FlZU1ueEVUZTFJajZ0eGtKeXk0V3gxWkJ6ZnM5VkRVSmtxRUpq?=
 =?utf-8?B?YVY3UGlLa21Jbm93aDU5MkNQZmhiVU15Zjh0eHllSldOMTdjbHZJQ21VNDhP?=
 =?utf-8?B?a2JpVHJtNEMxS0V3b1NYM2hUUEtJWTBNbTV1aVdwbmNzbHR2Wm1KTEswWisy?=
 =?utf-8?B?eEkwUVhxRmlkd0dXZUordXZaOTZmQTZUaHgvcmZ5dklXcWFEa2dROFRUczQ3?=
 =?utf-8?B?VHRmcXRuQXpCN2hoSjQ0Q2tMbzErU3I5YitqQjR2ZVNTVmw4S0V1amZqM09k?=
 =?utf-8?B?TUt6RVo1bk9yQWVxQmZsNTE5MHhXbFlpUUFXdEhscmgvZkU1ZW5GVWxPSjBX?=
 =?utf-8?B?dExnNDJyVXVlemtCOEhlUjdMdGROanFWRHNWVkpQeE9iZEo5eU5yS1BGeVUr?=
 =?utf-8?B?anZKbFdOdUxRTDhMSG9vaHZ6QjBYYVo3Tktrc3FyVFQ4TnNpNm1hVi92Uno5?=
 =?utf-8?B?RnFSUFg4OEpqVjJmZDZtQ0ovN1FBUzQ5TENyQ2dIRWZKOHhYZTBILzBib2s5?=
 =?utf-8?B?eWRXVVBHdmlPS1BQa2d5VGIwUWU3bVBFdWlHMk9vL1ZoQzdLWmFsMVNvOHYv?=
 =?utf-8?B?bEFqeE5UNXpnSWhhb3hTRk15WjlSMFBBVEZ5L2tFOVF5Y3h5aEo2NGhnMnpy?=
 =?utf-8?B?blJUVU5Wc0pUWW9IaHV2U1N6c1Fpd2pxSnRqUzNwVFg0U3pUQVlXcUtFci9F?=
 =?utf-8?B?U203cVdyN2hxVDJXWndyWWRiMUFRWFE5YVd1cWp1QzIwZmlKeDVpeDZMUjd6?=
 =?utf-8?B?T0dTc1krYTRwK1l1SUdGNjJzMlptWnJ4UE9KZjBCRVdjdDNsK29DL3A5NTdP?=
 =?utf-8?B?V3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 784e72e7-3cb7-4943-f98c-08da5ea1834e
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 16:15:01.4113
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ObuhvZ9BmqYmQRyasM7xcW8K30TaHWfocRTbBlx87dSZt63QBMsRwH/UwsPn4kTYejN4nDVo+sOK9y2RMp5BGZ7gtGl6NxnQixxRSzm8lww=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3469
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-07-05 5:58 PM, Andy Shevchenko wrote:
> device_get_match_data() in ACPI case calls similar to acpi_match_device().
> Hence there is no need to duplicate the call. Just assign what is in
> the id->driver_data.


Thanks for the patch! Change looks good:

Acked-by: Cezary Rojewski <cezary.rojewski@intel.com>

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v3: moved spec assignment closer to its user (Péter, Czarek)
>   sound/soc/intel/catpt/device.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/sound/soc/intel/catpt/device.c b/sound/soc/intel/catpt/device.c
> index 85a34e37316d..d48a71d2cf1e 100644
> --- a/sound/soc/intel/catpt/device.c
> +++ b/sound/soc/intel/catpt/device.c
> @@ -254,14 +254,11 @@ static int catpt_acpi_probe(struct platform_device *pdev)
>   		return -ENODEV;
>   	}
>   
> -	spec = device_get_match_data(dev);
> -	if (!spec)
> -		return -ENODEV;
> -
>   	cdev = devm_kzalloc(dev, sizeof(*cdev), GFP_KERNEL);
>   	if (!cdev)
>   		return -ENOMEM;
>   
> +	spec = (const struct catpt_spec *)id->driver_data;
>   	catpt_dev_init(cdev, dev, spec);
>   
>   	/* map DSP bar address */