Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220705163136.2278662-1-vincent.knecht@mailoo.org> <20220705163136.2278662-7-vincent.knecht@mailoo.org>
In-Reply-To: <20220705163136.2278662-7-vincent.knecht@mailoo.org>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Tue, 5 Jul 2022 20:56:16 +0200
Message-ID: <CAHp75VfrROx1oM54x1Bc8+zLkPi6-ivxPtFS2ECyPPLKsYFd1g@mail.gmail.com>
Subject: Re: [PATCH v3 6/6] leds: is31fl319x: Add support for is31fl319{0,1,3} chips
To:     Vincent Knecht <vincent.knecht@mailoo.org>
Cc:     Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        "H. Nikolaus Schaller" <hns@goldelico.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jul 5, 2022 at 6:32 PM Vincent Knecht <vincent.knecht@mailoo.org> w=
rote:
>
> Set specific chipset structs values for is31fl319{0,1,3}
> so that those chips can actually work.
> Datasheets:
> https://lumissil.com/assets/pdf/core/IS31FL3190_DS.pdf
> https://lumissil.com/assets/pdf/core/IS31FL3191_DS.pdf
> https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf
> https://lumissil.com/assets/pdf/core/IS31FL3196_DS.pdf
> https://lumissil.com/assets/pdf/core/IS31FL3199_DS.pdf

...

Two comments as per previous patch reviews.

...

> +       struct is31fl319x_led *led =3D container_of(cdev, struct is31fl31=
9x_led,
> +                                                 cdev);

One line?

...

> +               ret =3D regmap_read(is31->regmap, IS31FL3190_PWM(i), &pwm=
_value);

> +               dev_dbg(&is31->client->dev, "%s read %d: ret=3D%d: %d\n",
> +                       __func__, i, ret, pwm_value);

regmap has tracepoints Do you need to duplicate it with slow printk()?

...

> +static inline int is31fl3190_microamp_to_cs(struct device *dev, u32 micr=
oamp)
> +{
> +       switch (microamp) {
> +       case 5000:
> +               return IS31FL3190_CURRENT_5_mA;
> +       case 10000:
> +               return IS31FL3190_CURRENT_10_mA;
> +       case 17500:
> +               return IS31FL3190_CURRENT_17dot5_mA;
> +       case 30000:
> +               return IS31FL3190_CURRENT_30_mA;
> +       case 42000:
> +               return IS31FL3190_CURRENT_42_mA;
> +       default:
> +               dev_warn(dev, "Unsupported current value: %d, using 5000 =
=C2=B5A!\n", microamp);
> +       }
> +
> +       return IS31FL3190_CURRENT_5_mA;

It's more consistent to return directly from the default case.

> +}

--=20
With Best Regards,
Andy Shevchenko