Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp1659494imw; Tue, 5 Jul 2022 13:14:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sDvGct7AJHshfQLk9FfFssYdrrrseHtP9yJ5Bjt2IbNdD9kB3+p134QbreEpJ9ptJLLth9 X-Received: by 2002:a17:90b:3802:b0:1ed:2434:eb44 with SMTP id mq2-20020a17090b380200b001ed2434eb44mr46096009pjb.85.1657052098245; Tue, 05 Jul 2022 13:14:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657052098; cv=none; d=google.com; s=arc-20160816; b=CTtSjpWIySaPuyuikyhcu18HkdnBerFH2mT4AkcM3duX+cjuhNe5psEgiHsVZ31XFl yqQgoBJ8BmOO07Cm4nVMvN5K9mEezfWN3HjSbL/ytG3wxl7VZU5x4W1ht96J0yhXbhPd 4lTIhJyWRj6Iy2Pu/gMh4GehYhUdurr6tggrHzvxz591+MmsuvtxEEKwuTNcyXsNfWVN A9G3KjxLcGzVlHbk2U0Va5wUCYnaW47CvHWTbrn/cMTdUj4il9j/3qnGJLyAzJAFTjO2 avp0D9dBro/+RhNyhyP/wpxQrE8Deko8XPMSmHrEJhSs9aaB2JJ4SK5WRJ11dkMC5Ya0 /fjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=BxbTn0CECdrZXETflGt2gGDbEAPGwlDhM6o4bF0C3yE=; b=eglfzOh2HC3/0U5hQ/k2Wl1g3iHQzKDrl5S68UBFVF/LIk3PdXz2OOU60jguexNQNm CRz97bhcjVUnbZFTlGt0LlOsOBqYhD54g3y0x9uhrYE4ICZZo8WFkcYfezKSSyaXDhys kCV331HS8cLmwuSqi2uhcheBB6yT7THRNJbUdoAPMVgnMPoql5laIZmvAKGMEWEmWl8t +CufjDx623cG6YU28w/IehtKm79ykIp/fs1Ly0tTam2ALy7kmdTuahUWXqoX9CMcBXub na/4CiNSMgnZi35gsWw+JufYNoyV64feHt/8kZTgz3Rt+S3lxA+5I7LC7Loef97Ih/sR YvAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Fdw6fzHT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z8-20020a170902d54800b0016bee11cc4csi5546215plf.51.2022.07.05.13.14.47; Tue, 05 Jul 2022 13:14:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Fdw6fzHT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232476AbiGETqF (ORCPT + 99 others); Tue, 5 Jul 2022 15:46:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43690 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229849AbiGETqE (ORCPT ); Tue, 5 Jul 2022 15:46:04 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83D4519C3D for ; Tue, 5 Jul 2022 12:46:03 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id j1-20020a17090aeb0100b001ef777a7befso5495829pjz.0 for ; Tue, 05 Jul 2022 12:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BxbTn0CECdrZXETflGt2gGDbEAPGwlDhM6o4bF0C3yE=; b=Fdw6fzHTpa73THj5FbnWvsryc9rX9O54EvNLbsmVn8I2OqAr35tJitYbGgkTDKBqwq 195R0eKEaHXRMxRuYaHFdey6D6R5j8lnecgTglFyJ5u2Sxa3BV4KDrjhCQAvy5hAQg8K NnBaFDbUCRr+zIrvGQ+p6HSLSFQaA0+G69is3GhXEycNbYxDTyVmSHm6CKVwEkAAf3W9 ZXJwspvQ0f/RvRrlmkvyyMdu3f5U+LsH/zsrrmzN7VXBxi7qGUR9D5olyg+R0ZD5o8kg 69JxKMa050Xl4PspweOy03E95RIAvogwR8rcssCIiTyYyhCItPBpf5TS4xfl8gplnW4F g81w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BxbTn0CECdrZXETflGt2gGDbEAPGwlDhM6o4bF0C3yE=; b=UqthwgPC8eB4h16xhjgx+vc7OlvzoK61GOg1UlAEhDP0XdF1j/VQ3uWLq10rd23rNc Oi33+ohTpEM8ksOEo/thwebpbfqZhZ7ZBju1IpiukOlw1s5ky/lO/jq0vPVnoG2WlUgY YC477UC77RBCQ54fyIk+1yNwZ5fV1DLdU6XluNFiewpxsnnDx3nEx0CLG5X3+ODth5RJ 0Vd6KS/PHRYbQXR7pYQ43apatFY8Y9T+LTausH3phpBSObz+rinvWKSVYJ/u7M1zMUjP GxLhrAOWXhW3U6aIPB9t/TUpYsk9g19Og3XWsfQ0fA4LJaFlSQPBd5z2VTbjEz9GRtRl zWaw== X-Gm-Message-State: AJIora/dmS00CaBaAzLACkqsco8laDxOHokJiBg9B9ugonnvVwCo8UEZ 773qFkuDjEeZBFEEALr02r6tYiUnfSi8aciqZQTwpmbJ X-Received: by 2002:a17:902:ab8a:b0:16a:7cf2:a394 with SMTP id f10-20020a170902ab8a00b0016a7cf2a394mr41982956plr.26.1657050363017; Tue, 05 Jul 2022 12:46:03 -0700 (PDT) MIME-Version: 1.0 References: <20220616174840.1202070-1-shy828301@gmail.com> <20220703161422.71e0c7316cca0442c682fcaf@linux-foundation.org> In-Reply-To: <20220703161422.71e0c7316cca0442c682fcaf@linux-foundation.org> From: Yang Shi Date: Tue, 5 Jul 2022 12:45:50 -0700 Message-ID: Subject: Re: [mm-unstable v5 PATCH 0/7] Cleanup transhuge_xxx helpers To: Andrew Morton Cc: Vlastimil Babka , "Kirill A. Shutemov" , Matthew Wilcox , "Zach O'Keefe" , Miaohe Lin , Linux MM , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 3, 2022 at 4:14 PM Andrew Morton wrote: > > On Thu, 16 Jun 2022 10:48:33 -0700 Yang Shi wrote: > > > This series is the follow-up of the discussion about cleaning up transhuge_xxx > > helpers at https://lore.kernel.org/linux-mm/627a71f8-e879-69a5-ceb3-fc8d29d2f7f1@suse.cz/. > > > > THP has a bunch of helpers that do VMA sanity check for different paths, they > > do the similar checks for the most callsites and have a lot duplicate codes. > > And it is confusing what helpers should be used at what conditions. > > > > This series reorganized and cleaned up the code so that we could consolidate > > all the checks into hugepage_vma_check(). > > > > The transhuge_vma_enabled(), transparent_hugepage_active() and > > __transparent_hugepage_enabled() are killed by this series. > > I plan to move this into mm-stable later this week, along with two fixups: > > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-thp-kill-transparent_hugepage_active-fix.patch > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/mm-thp-kill-transparent_hugepage_active-fix-fix.patch Looks good to me. Thanks for the heads up.