Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Jul 2022 22:36:02 +0200
From:   Pavel Machek <pavel@denx.de>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 4.9 05/29] usbnet: make sure no NULL pointer is passed
 through
Message-ID: <20220705203601.GA3184@amd>
References: <20220705115605.742248854@linuxfoundation.org>
 <20220705115605.903898317@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc"
Content-Disposition: inline
In-Reply-To: <20220705115605.903898317@linuxfoundation.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk


--C7zPtVaVf+AK4Oqc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> From: Oliver Neukum <oneukum@suse.com>
>=20
> commit 6c22fce07c97f765af1808ec3be007847e0b47d1 upstream.
>=20
> Coverity reports:
>=20
> ** CID 751368:  Null pointer dereferences  (FORWARD_NULL)
> /drivers/net/usb/usbnet.c: 1925 in __usbnet_read_cmd()
>=20
> _________________________________________________________________________=
_______________________________

There's something wrong here. Changelog is cut, so signed-offs are
missing. It is wrong in git, too.

There's something wrong with the whitespace in the patch (indentation
by 4 spaces instead of tab), too.

Best regards,
								Pavel
							=09
> --- a/drivers/net/usb/usbnet.c
> +++ b/drivers/net/usb/usbnet.c
> @@ -1960,8 +1960,13 @@ static int __usbnet_read_cmd(struct usbn
>  	err =3D usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0),
>  			      cmd, reqtype, value, index, buf, size,
>  			      USB_CTRL_GET_TIMEOUT);
> -	if (err > 0 && err <=3D size)
> -		memcpy(data, buf, err);
> +	if (err > 0 && err <=3D size) {
> +        if (data)
> +            memcpy(data, buf, err);
> +        else
> +            netdev_dbg(dev->net,
> +                "Huh? Data requested but thrown away.\n");
> +    }
>  	kfree(buf);
>  out:
>  	return err;
> @@ -1982,7 +1987,13 @@ static int __usbnet_write_cmd(struct usb
>  		buf =3D kmemdup(data, size, GFP_KERNEL);
>  		if (!buf)
>  			goto out;
> -	}
> +	} else {
> +        if (size) {
> +            WARN_ON_ONCE(1);
> +            err =3D -EINVAL;
> +            goto out;
> +        }
> +    }
> =20
>  	err =3D usb_control_msg(dev->udev, usb_sndctrlpipe(dev->udev, 0),
>  			      cmd, reqtype, value, index, buf, size,
>=20

--=20
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

--C7zPtVaVf+AK4Oqc
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAmLEoLEACgkQMOfwapXb+vIZqwCfX0mpHAw+0dynaI7ZHL1Nxgdg
fK8AnidRkrzg/vEgwd4aM0QcENMUoVx6
=arxU
-----END PGP SIGNATURE-----

--C7zPtVaVf+AK4Oqc--