Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Jul 2022 14:38:27 -0600
From:   Rob Herring <robh@kernel.org>
To:     Lino Sanfilippo <LinoSanfilippo@gmx.de>
Cc:     linux-kernel@vger.kernel.org, ilpo.jarvinen@linux.intel.com,
        vz@mleia.com, devicetree@vger.kernel.org,
        Lino Sanfilippo <l.sanfilippo@kunbus.com>,
        linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org,
        andriy.shevchenko@linux.intel.com, p.rosenberger@kunbus.com,
        krzysztof.kozlowski+dt@linaro.org, lukas@wunner.de,
        jirislaby@kernel.org, robh+dt@kernel.org,
        gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 5/9] dt_bindings: rs485: Correct delay values
Message-ID: <20220705203827.GA2583869-robh@kernel.org>
References: <20220703170039.2058202-1-LinoSanfilippo@gmx.de>
 <20220703170039.2058202-6-LinoSanfilippo@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220703170039.2058202-6-LinoSanfilippo@gmx.de>
Precedence: bulk

On Sun, 03 Jul 2022 19:00:35 +0200, Lino Sanfilippo wrote:
> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> 
> Currently the documentation claims that a maximum of 1000 msecs is allowed
> for RTS delays. However nothing actually checks the values read from device
> tree/ACPI and so it is possible to set much higher values.
> 
> There is already a maximum of 100 ms enforced for RTS delays that are set
> via the uart TIOCSRS485 ioctl. To be consistent with that use the same
> limit for DT/ACPI values.
> 
> Although this change is visible to userspace the risk of breaking anything
> when reducing the max delays from 1000 to 100 ms should be very low, since
> 100 ms is already a very high maximum for delays that are usually rather in
> the usecs range.
> 
> Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
> ---
>  Documentation/devicetree/bindings/serial/rs485.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>