Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <725b7b32d65b4026313f658954f9f7ad31bd2c64.camel@kernel.org>
Subject: Re: [PATCH v7 0/4] tracing/probes: allow no event name input when
 create group
From:   Tom Zanussi <zanussi@kernel.org>
To:     Linyu Yuan <quic_linyyuan@quicinc.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Masami Hiramatsu <mhiramat@kernel.org>
Cc:     linux-kernel@vger.kernel.org
Date:   Tue, 05 Jul 2022 16:46:32 -0500
In-Reply-To: <1656296348-16111-1-git-send-email-quic_linyyuan@quicinc.com>
References: <1656296348-16111-1-git-send-email-quic_linyyuan@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.1-0ubuntu1 
MIME-Version: 1.0
Precedence: bulk

Hi Yuan,

On Mon, 2022-06-27 at 10:19 +0800, Linyu Yuan wrote:
> take kprobe event as example, when create a group of events,
> p[:[GRP/]EVENT] [MOD:]KSYM[+OFFS]|KADDR [FETCHARGS],
> according to this format, we must input EVENT name,
>=20
> this change allow only GRP/ input, EVENT name auto generate from
> KSYM,
> p[:[GRP/][EVENT]] [MOD:]KSYM[+OFFS]|KADDR [FETCHARGS]
>=20
> similar change apply to eprobe and uprobe.

Thanks for making those changes!

For the series,

Reviewed-by: Tom Zanussi <zanussi@kernel.org>

Tom

>=20
> V2: (v1:
> https://lore.kernel.org/lkml/1651397651-30454-1-git-send-email-quic_linyy=
uan@quicinc.com/
> )
> =C2=A0=C2=A0=C2=A0 fix remove comment in V1 patch1,
> =C2=A0=C2=A0=C2=A0 remove v1 patch2 as it is NACK.
>=20
> v3: (v2 :
> https://lore.kernel.org/lkml/1653795294-19764-1-git-send-email-quic_linyy=
uan@quicinc.com/
> )
> =C2=A0=C2=A0=C2=A0 add selftest cases for kprobe and eprobe event,
> =C2=A0=C2=A0=C2=A0 remove macro used in v1,v2,
> =C2=A0=C2=A0=C2=A0 change location to generate eprobe event name.
>=20
> v4: (v3 :
> https://lore.kernel.org/lkml/1653978552-18637-1-git-send-email-quic_linyy=
uan@quicinc.com/
> )
> =C2=A0=C2=A0=C2=A0 fix comment of kprobe/eprobe test case.
>=20
> v5: (v4:
> https://lore.kernel.org/lkml/1654171861-24014-1-git-send-email-quic_linyy=
uan@quicinc.com/
> )
> =C2=A0=C2=A0=C2=A0 for eprobe, when only input a "SYSTEM.", it is invalid=
.
> =C2=A0=C2=A0=C2=A0 add Acked-by from Masami Hiramatsu (Google) <mhiramat@=
kernel.org>
>=20
> v6: (v5:
> https://lore.kernel.org/lkml/1655168698-19898-1-git-send-email-quic_linyy=
uan@quicinc.com/
> )
> =C2=A0=C2=A0=C2=A0 change some code order according review comment from T=
om Zanussi,
> =C2=A0=C2=A0=C2=A0 some minor changes.
>=20
> v7: (v6:
> https://lore.kernel.org/lkml/1655776787-18133-1-git-send-email-quic_linyy=
uan@quicinc.com/
> )
> =C2=A0=C2=A0=C2=A0 move log index to a separate patch according review co=
mment
>=20
> Linyu Yuan (4):
> =C2=A0 tracing: eprobe: add missing log index
> =C2=A0 tracing: eprobe: remove duplicate is_good_name() operation
> =C2=A0 tracing: auto generate event name when create a group of events
> =C2=A0 selftests/ftrace: add test case for GRP/ only input
>=20
> =C2=A0Documentation/trace/kprobetrace.rst=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 8 +++-=
---
> =C2=A0Documentation/trace/uprobetracer.rst=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 8 +++----
> =C2=A0kernel/trace/trace.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 8 +++-=
---
> =C2=A0kernel/trace/trace_dynevent.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0 |=C2=A0 2 +-
> =C2=A0kernel/trace/trace_eprobe.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 | 28 +++++++++++-
> ----------
> =C2=A0kernel/trace/trace_kprobe.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 | 16 ++++++++----
> -
> =C2=A0kernel/trace/trace_probe.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0 4 ++++
> =C2=A0kernel/trace/trace_uprobe.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0 | 12 ++++++----
> =C2=A0.../ftrace/test.d/dynevent/add_remove_eprobe.tc=C2=A0=C2=A0=C2=A0 |=
=C2=A0 9 ++++++-
> =C2=A0.../ftrace/test.d/dynevent/add_remove_kprobe.tc=C2=A0=C2=A0=C2=A0 |=
=C2=A0 7 ++++++
> =C2=A010 files changed, 64 insertions(+), 38 deletions(-)
>=20