Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Jul 2022 14:40:59 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
CC:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Naohiro Aota <naohiro.aota@wdc.com>,
        Johannes Thumshirn <jth@kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] zonefs: Call page_address() on page acquired with
 GFP_KERNEL flag
Message-ID: <YsSv656Uc873foaA@iweiny-desk3>
References: <20220705142202.24603-1-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220705142202.24603-1-fmdefrancesco@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fZ44w4Aiwpi4i6S0o7bONXWAbCW2JX5RCaJNxVvM94lIpBVZycLydSb6Zc4r?=
 =?us-ascii?Q?V+TgBXF1E0roF+SZIntfqsxUfV6JpsIbkhKQB5gXFKvIvoDWkFKysLWwxvuu?=
 =?us-ascii?Q?g4A+7Yl5IQv5RJSJgVbONGQYP+Ik4FL0u4Cp3uhjK/Pzovx+AlxSvN1K9r4q?=
 =?us-ascii?Q?/thHH3l431moN5OwiyaaUXfZSJWNiqpyjTPG+vB4+wwxaFS23liIWf0DrXUo?=
 =?us-ascii?Q?VkHRDr/k7ZVvZWMGyeU6iR7LLcPINz5pNma7OSrGMOAqWz2l5oXGSAse7GXv?=
 =?us-ascii?Q?utHC5G1bsMZ56I95J7iP4EbtLebBLdSRjpMEig24I4ITfzOi5DpO9TPtiEMg?=
 =?us-ascii?Q?Vs+c8N6QtRHG++RoZFdGl0OxxfCdhr4u5/+UftCeBJdOFjN+7bfjF2x2njTv?=
 =?us-ascii?Q?/8kuzt66d9n8kMHr4EHuCUj1TWpSk2sOH4LXNhLVTCU7Bay5L08rMFUhAEWL?=
 =?us-ascii?Q?Vj3qgAMeAXl6rvffSOCX9jKWKAMRI3UadUKR5HbdYTXwjCJekb40RkWpjSUQ?=
 =?us-ascii?Q?SkFALHeLe5ieGXhmL6RggIEeUaH3qsMyJYewGymGJC+yugLaZL5XHc0v0zd1?=
 =?us-ascii?Q?X4myOb9CmSRWadctRkXzEclMYcL14HS+yW0jSDTG/bpzmKIus0XOmM0qvyJa?=
 =?us-ascii?Q?GtMJ3jebpnsplKcXMf7Tqe7FLIjGQzfwIG1hDIawuhqeiXI/+E6F1ahgyy+3?=
 =?us-ascii?Q?LVtii7gyKXMk9+qo/GpjtKaH9rXKGBsE73HgL31vmig2uz3eBTUZY1wYcqGA?=
 =?us-ascii?Q?8CKSg73Yhaz1MmOfnBvJx+8p8GOBsjjgQCqYaBEPeajnbGy3hF2q8+8/1Le3?=
 =?us-ascii?Q?/uhSTASzgZf8VTjlV9DxoZp9EZh5I0+TQo0PfVXxpiqRdeV3L93uRmh/gdJg?=
 =?us-ascii?Q?dGMW+Hbob8BZBGPp5kN5nFysCnVhobeZEGiEzQ0kZDUwT42Xrn5LTavc6x9E?=
 =?us-ascii?Q?QXC74gCbKwF/n9fD+YD/mlEb4semlXxpU9y4k8KAyZeF4Vwf2EsQaXaEzwth?=
 =?us-ascii?Q?S5Sz4dizb4nsnj1u2Losx9mXtT6PmO+oc5/3etYsd9SurKh/AkcphhMYnEp7?=
 =?us-ascii?Q?UOb8pT140jtd0H46IE1oJm3BVH+7Ba2ly+u45bhadKGbnfbDtXsTBks13VmY?=
 =?us-ascii?Q?4QuSIPemBAvYrOKr2u6hjfbTGcXncr+1K1AOfdHxEBICuVzme3lfxCMPpRdo?=
 =?us-ascii?Q?ZYwA3IeDkd/txZYlwqA4ezi/nyKbXqLblLv+GKFI+iZTtIN3WbfFlR53tPu+?=
 =?us-ascii?Q?uuCxxWoTstkTx5XA/rsvXu6bZR1uYuIEJZ37ZUIZxC16GkLyj4r2ch7PTVbG?=
 =?us-ascii?Q?CJdKUOqn1Avz7zAswst9p0OdP8fhDzP1em2fJFGPUKDVjo5ALF/55X6Q4LXY?=
 =?us-ascii?Q?NWvPfcwpBGrUb9OGGQUAo4DEWLPIVwTIPxLcdzGlC55gGpWvieq+sjc2Efzg?=
 =?us-ascii?Q?L59xhfweguXn1YTSPsDhmVAvW5D9hlnQtH48vkPhNWSEP5jpxSASjsLy7g+t?=
 =?us-ascii?Q?xn4lw9mz/q/If5Kb63OI1PRHmlaVAlXnim0ZiBw3lqhQegdD5LRv0/esSK7A?=
 =?us-ascii?Q?+yzKE7QLIR4jwDloe2kS0qmLKFANL7pumSLtYX6tf1sLKIlijYBEaB352f6u?=
 =?us-ascii?Q?uKVSf+Z2mFDAHQclVD/Diof+UK/1fy47VliRuwY+XPzW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f929b985-eaac-44ba-48b3-08da5ecf101f
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 21:41:05.0260
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Wi4Lo3yboJZ5SGPLQXKvBY0ECjCBKCQRuOZGPFZtjHMJa35VZVR3+H7mldrHH+0ccYZc2X3gdIewMpkUuGdY5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4811
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 05, 2022 at 04:22:02PM +0200, Fabio M. De Francesco wrote:
> zonefs_read_super() acquires a page with alloc_page(GFP_KERNEL). That
> page cannot come from ZONE_HIGHMEM, thus there's no need to map it with
> kmap().
> 
> Therefore, use a plain page_address() on that page.
> 
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
>  fs/zonefs/super.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index 053299758deb..bd4e4be97a68 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -1687,11 +1687,11 @@ static int zonefs_read_super(struct super_block *sb)
>  	if (ret)
>  		goto free_page;
>  
> -	super = kmap(page);
> +	super = page_address(page);
>  
>  	ret = -EINVAL;
>  	if (le32_to_cpu(super->s_magic) != ZONEFS_MAGIC)
> -		goto unmap;
> +		goto free_page;
>  
>  	stored_crc = le32_to_cpu(super->s_crc);
>  	super->s_crc = 0;
> @@ -1699,14 +1699,14 @@ static int zonefs_read_super(struct super_block *sb)
>  	if (crc != stored_crc) {
>  		zonefs_err(sb, "Invalid checksum (Expected 0x%08x, got 0x%08x)",
>  			   crc, stored_crc);
> -		goto unmap;
> +		goto free_page;
>  	}
>  
>  	sbi->s_features = le64_to_cpu(super->s_features);
>  	if (sbi->s_features & ~ZONEFS_F_DEFINED_FEATURES) {
>  		zonefs_err(sb, "Unknown features set 0x%llx\n",
>  			   sbi->s_features);
> -		goto unmap;
> +		goto free_page;
>  	}
>  
>  	if (sbi->s_features & ZONEFS_F_UID) {
> @@ -1714,7 +1714,7 @@ static int zonefs_read_super(struct super_block *sb)
>  				       le32_to_cpu(super->s_uid));
>  		if (!uid_valid(sbi->s_uid)) {
>  			zonefs_err(sb, "Invalid UID feature\n");
> -			goto unmap;
> +			goto free_page;
>  		}
>  	}
>  
> @@ -1723,7 +1723,7 @@ static int zonefs_read_super(struct super_block *sb)
>  				       le32_to_cpu(super->s_gid));
>  		if (!gid_valid(sbi->s_gid)) {
>  			zonefs_err(sb, "Invalid GID feature\n");
> -			goto unmap;
> +			goto free_page;
>  		}
>  	}
>  
> @@ -1732,14 +1732,12 @@ static int zonefs_read_super(struct super_block *sb)
>  
>  	if (memchr_inv(super->s_reserved, 0, sizeof(super->s_reserved))) {
>  		zonefs_err(sb, "Reserved area is being used\n");
> -		goto unmap;
> +		goto free_page;
>  	}
>  
>  	import_uuid(&sbi->s_uuid, super->s_uuid);
>  	ret = 0;
>  
> -unmap:
> -	kunmap(page);
>  free_page:
>  	__free_page(page);
>  
> -- 
> 2.36.1
>