Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Jul 2022 15:06:51 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Gang Li <ligang.bdlg@bytedance.com>,
        Muchun Song <songmuchun@bytedance.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm, hugetlb: skip irrelevant nodes in
 show_free_areas()
Message-ID: <YsS1+w/zWEEwFbOq@monkey>
References: <20220705092120.2158-1-ligang.bdlg@bytedance.com>
 <20220705142547.da3ea5a7383a7eeec3a93665@linux-foundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220705142547.da3ea5a7383a7eeec3a93665@linux-foundation.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ojb/nxm4zZqQbm3x2SD21hKRfuFW2Meptvd/UUfkWaCxAEgHKPXxJmMA1gp0?=
 =?us-ascii?Q?zSncmHXStSoMantghC74LzG/n+nNZ8kZrZMuEltTMYDJPWXCcGhUf5k1vLXp?=
 =?us-ascii?Q?2NnQiMpoMjlIeEGYuaOEke3Ss1TM2P6JsQPXWGAKb/e/6gaKfwN1P8UlKpEO?=
 =?us-ascii?Q?St3oNOrh3bG/Gv39vkp6HURk1HKPgJtlIdUdhjVvfnAacfm8O4gkKU9iaveR?=
 =?us-ascii?Q?0OzY+/Yx22VQ/mVt2cCh02V93ZdaoWqcVuTUmPquevOsRT385zq7t1FPW3tN?=
 =?us-ascii?Q?yEQTxKVWQQY3ZSVvkNNybhr3mB6Uq7Uq5dEzXIZSpQaUAIGpFVPnul5ZLlYA?=
 =?us-ascii?Q?K825siL0FgzRYkAIVyP5cMNDRULWHjekAD8ZdFQetux2IM2ZWQs86gOdkL5v?=
 =?us-ascii?Q?ZkZ1isGLONqyp9wBjuLlfwg/w5CIl9yRXo/vLPySIdjqv8TTGadSaCWpn59D?=
 =?us-ascii?Q?69cZrtxOIQ/c/Ce5I0jfOgdlMIWEa6QM6FKEW4cUJD2k+J05dqJBpnIHowhQ?=
 =?us-ascii?Q?EPNf2FY52oW2z1s1wUHm+eEIcAlqoDYxv6Sufpo97ICkYvsUrWTrKM8ckHnL?=
 =?us-ascii?Q?HFdiTr9+zDko0m6q9egTQrhZSUEEbspnI5u1ola49s3sVwUFKTdPmzOXMqkz?=
 =?us-ascii?Q?ZKq3cWfydwiSOa3dRemGeYj8SJDovtbQi4Q5lkM149gd42cwUEEDV6IEWkQ5?=
 =?us-ascii?Q?UaQEUNKCi6xbyuo/830Rd3W+MG4zd2TtEqYBYycjveURcTab32wXeBlVk83F?=
 =?us-ascii?Q?tOyDAnMLRdz6sHAeurI1KDtjc09FuI2mjQu09AGcCeb6SrdKSagGH4ZMi4sd?=
 =?us-ascii?Q?LCrKFK99cC2cxxkAgq3y8lByyeXyUByhUMuHyOzS5GslnXOKn4GuK5uDgXqb?=
 =?us-ascii?Q?cVV25gJYzlMjPW+9Z/WMnHFFwN/fROC5HnaS6uMoGf+og2lKcgRWxbPWWQFL?=
 =?us-ascii?Q?GiUS4B2xUv8/yC14ondvCmAPDJmziPWuenDFWbcNixM3dLH5c1RpH4P/hkb/?=
 =?us-ascii?Q?7Xlg5wuQ5GbYUAQG7A66WdaD7Tn41ho9cjdi4SRErHF8deKUbmiABkv4agYE?=
 =?us-ascii?Q?aT8O58YXkgDRYysm38MoUo6wxnd58WKnBFjloQcK32qLSHhFBiHpXV0uPOoF?=
 =?us-ascii?Q?BN7konR4IKi1DRBZk4M0mp7lh2AZ4+ou2KFb3EBZReaiANVO83xq9rmwI4Z5?=
 =?us-ascii?Q?AafYduI9x+zOux376UciaRc0rs9JZk+hnw8u+wqTrhOW6X/wrXZsQMFw97Ck?=
 =?us-ascii?Q?2A88I3ebwHkqHa7smRyCaa8pDLdKkeclebUhVvWsFlSEeJSa+BhyEaKuCh5e?=
 =?us-ascii?Q?cMhiHNDx9G8psPc2frLGskKSdLCcBfm0dHKv+eUcnjoLSr81JZQSwChAhUEw?=
 =?us-ascii?Q?ruKN7t6hO19KQgnYqyQMCK+NyPJNF03diMSUB4N1L8qUHdIvqtxYl9jJyrml?=
 =?us-ascii?Q?cG8t2Dmk8UemCsCy9W3V/i+grs4GCfOCwgoJX/LSDq2CbxZ+kJYMq+WfqKFc?=
 =?us-ascii?Q?w+819/umyqjmNai2Iy231XY4Ys6B9vicd5LPW/fpEzCTuZFoJIsLmWPT7NwA?=
 =?us-ascii?Q?ICqKxKYvWbf5+341hxqskoe2aE0l++heSXN3VV7seFDfne154ZZGvAhQxQj8?=
 =?us-ascii?Q?4g=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5db749ea-54a8-4796-5b84-08da5ed2abd0
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 22:06:54.7860
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GmTLd8GkOLSjHOG2FVEoN10y/zSzugEiqE0heF3YOFQMaTc7EHjYY1SEDjEEUdZ5zj4c131SZrvm005Zh2jEIQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5799
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-05_18:2022-06-28,2022-07-05 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0
 adultscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=838
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207050096
X-Proofpoint-GUID: UAMRjOoowIdhtss1gytk7RC8HLb3rCVo
X-Proofpoint-ORIG-GUID: UAMRjOoowIdhtss1gytk7RC8HLb3rCVo
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/05/22 14:25, Andrew Morton wrote:
> On Tue,  5 Jul 2022 17:21:19 +0800 Gang Li <ligang.bdlg@bytedance.com> wrote:
> 
> > show_free_areas() allows to filter out node specific data which is
> > irrelevant to the allocation request. But hugetlb_show_meminfo() still
> > shows hugetlb on all nodes, which is redundant and unnecessary.
> > 
> > Use show_mem_node_skip() to skip irrelevant nodes. And replace
> > hugetlb_show_meminfo() with hugetlb_show_meminfo_node(nid).
> 
> It would be helpful to include before-and-after sample output text in
> the changelog to help others assess the proposed change.
> 
> > --- a/mm/page_alloc.c
> > +++ b/mm/page_alloc.c
> > @@ -6202,7 +6202,11 @@ void show_free_areas(unsigned int filter, nodemask_t *nodemask)
> >  		printk(KERN_CONT "= %lukB\n", K(total));
> >  	}
> >  
> > -	hugetlb_show_meminfo();
> > +	for_each_online_node(nid) {
> > +		if (show_mem_node_skip(filter, nid, nodemask))
> > +			continue;
> > +		hugetlb_show_meminfo_node(nid);
> > +	}
> >  
> 
> Does this mean that potentially useful info about presently-offline
> nodes will no longer be available?
> 

I do not believe that is possible.

IIUC, all memory blocks of a node must be offline for the node to be
marked offline.  To offline a memory block, all hugetlb pages must be
removed from the memory block.  So, an offline node should have no
hugetlb pages.  And, if there are no hugetlb pages it makes no sense to
call hugetlb_show_meminfo_node.

Also, previous code in show_free_areas skips offline nodes.  So, this
new code would be consistent with existing code.
-- 
Mike Kravetz