Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 01:11:12 +0300
From:   Serge Semin <fancer.lancer@gmail.com>
To:     Philipp Zabel <p.zabel@pengutronix.de>
Cc:     Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        Stephen Boyd <sboyd@kernel.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        linux-clk@vger.kernel.org, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH RESEND v5 7/8] clk: baikal-t1: Add DDR/PCIe directly
 controlled resets support
Message-ID: <20220705221112.vix772dpl2ql2ibq@mobilestation>
References: <20220624141853.7417-1-Sergey.Semin@baikalelectronics.ru>
 <20220624141853.7417-8-Sergey.Semin@baikalelectronics.ru>
 <094a0d4e1c1b40f51ce7bec42e410500265d7a6d.camel@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <094a0d4e1c1b40f51ce7bec42e410500265d7a6d.camel@pengutronix.de>
Precedence: bulk

Hi Philipp

On Wed, Jun 29, 2022 at 05:16:56PM +0200, Philipp Zabel wrote:
> Hi Serge,
> 
> On Fr, 2022-06-24 at 17:18 +0300, Serge Semin wrote:
> > Aside with a set of the trigger-like resets Baikal-T1 CCU provides two
> > additional blocks with directly controlled reset signals. In particular it
> > concerns DDR full and initial resets and various PCIe sub-domains resets.
> > Let's add the direct reset assertion/de-assertion of the corresponding
> > flags support into the Baikal-T1 CCU driver then. It will be required at
> > least for the PCIe platform driver. Obviously the DDR controller isn't
> > supposed to be fully reset in the kernel, so the corresponding controls
> > are added just for the sake of the interface implementation completeness.
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
> 

> This looks good to me, the issues with the previous patch still apply.

I see. Let's settle the main question there first then. Further
actions in this patch framework depend on your answer there.

-Sergey

> 
> [...]
> > +static int ccu_rst_set(struct reset_controller_dev *rcdev,
> > +		       unsigned long idx, bool high)
> > +{
> > +	struct ccu_rst *rst;
> > +
> > +	rst = ccu_rst_get_desc(rcdev, idx);
> > +	if (IS_ERR(rst)) {
> > +		pr_err("Invalid reset index %lu specified\n", idx);
> > +		return PTR_ERR(rst);
> > +	}
> 
> e.g. this should not be necessary.
> 
> regards
> Philipp