Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Jul 2022 15:54:25 -0700
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Gang Li <ligang.bdlg@bytedance.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm, hugetlb: skip irrelevant nodes in
 show_free_areas()
Message-ID: <YsTBIWFLiHuc6BRQ@monkey>
References: <20220705092120.2158-1-ligang.bdlg@bytedance.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220705092120.2158-1-ligang.bdlg@bytedance.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nWtHGVKXQoGe7iuhedARBySJpIXCA6KP0bNKFXZRIRikZnfCGNOaXD7QmP7w?=
 =?us-ascii?Q?O/j2KdmBEXhSC7l7B+U5gxL40MgDwxSWC3vheQacLh4Lgdh1enM6zs3HXSRK?=
 =?us-ascii?Q?aKHfmEm6l9lJ7hZ8+uL5KS+GWn1Yx70e0w2as3GzenuzklifiOPZaK9xbfpr?=
 =?us-ascii?Q?wINVVkyKUv2P4ZHyOqBcn0/Ii7EhQiq9OxCMLo7O/a24aQi+S8Bm+igz9g9s?=
 =?us-ascii?Q?ggtLUfGubL6jH1zmELyQ7j6bOOJgWoaM6BOQWDsWhCoru0WopHnFsGdXzgip?=
 =?us-ascii?Q?qV1yJ2ZpTQDekR7KoQaf7ZGcvVpj86rfjkLbJXVIt0ZNTZcrtfTav8Uf0JmP?=
 =?us-ascii?Q?Tw0YGNyAoYfl/fa6f9w37MB9uIINa+yJQviRLG2uJ0JqQfSU4X1a+xrcTTZe?=
 =?us-ascii?Q?aX1DNtGzG9nUlfzwjRLAphmbZGk9x7UOPME3urXwdkkJJ6Q7S2Eb1PHLHiQs?=
 =?us-ascii?Q?AYriJec7M84e0nRjfq7yOCaxAb/E3iSh+p4h3NL3Y9jXV/W0ck0TdohJAyjz?=
 =?us-ascii?Q?whGM1nTxKwLvXhbmO4+ErhIhrYXhbFU8f/p8X6xO4bKoGJOtCDofDKHgRW56?=
 =?us-ascii?Q?prLVXlazpxMe1QmMUl9lEvTHJro9xjT6TfrsWA80n7o/9bOjYLoC82woC2uJ?=
 =?us-ascii?Q?xu+ZDfMcFdG6Feb9tk1O7q8bJeGr5g5dfaGxdW5eqPer4CW09OiQXU2MwLCU?=
 =?us-ascii?Q?ILWzMcY+CXBvzo7T+vsewiX/bF1gAMbWYA53XoUBuEb721gpFfQ7l1VvWvr6?=
 =?us-ascii?Q?7bUer0XERIcDXx4jeGtXaDUQf0FUilJ4Ly56bP51Vxxk6YTikxCaaqJOtZfN?=
 =?us-ascii?Q?7JKF9C+uMq5J4n9NYFu8cf80oaU9+gv6kqaAZSSbtnudM/xgzb6G0IDvD7/C?=
 =?us-ascii?Q?Jo07IBzKG2KOh199+P6BINPsJSS1+BG5KclXoO7nVBPigxbHnBuQvgwIgY2A?=
 =?us-ascii?Q?FRIXu1xw3JcFjzx/tS+YpUKonanMjXGXnAarMU46vR+2sFp0keldBQ8xgEr7?=
 =?us-ascii?Q?5sQ9S8jriKcnuWqu3MeOwVN5O0bEUrc2sYSqaRfV/67wWmPwJI4aOre4LNii?=
 =?us-ascii?Q?PuMFlLW0x4KuEFKm7MlEruAOte9ZVgPTyAUQ2YC09DfzqR99QWBPlgsnDItS?=
 =?us-ascii?Q?V9lLTjbuEHmZDIYUdUEpOb/ONZCd5dLixkV07cr3nILLuhS2PmrMP470aG2r?=
 =?us-ascii?Q?j3tR5bPFA32hIRsPcy/u7XDu038WQm1eagk4xgXlUGOyW+MfWAdpNpF8PEFA?=
 =?us-ascii?Q?mLi9unVCIVy+AGzaF2dRLZRmvn2I6K7gCp+vDxmPo3eAOeXMgFQIQrngaa7T?=
 =?us-ascii?Q?5Rph8IOgSlGGCO4xJSvneEfXPjL+PIsJ2vdvC8S2Z0D/dsZsrJW5hUhVwgn2?=
 =?us-ascii?Q?aSTnPR+JC3Wh02ltHYuvtcPp6oNww2VnT1+7U7s8Q4CTQKjXmJHeHJdLy+lH?=
 =?us-ascii?Q?OgPF1FhoX6H3l/Kxu7Wh0RbKeveydMBrKLZ6nputjJenorIIHp73Q9XCWSCP?=
 =?us-ascii?Q?4aTx7b8kujzQuO4N65Dl/+htRomJbseP30yJ5JO+PItNKaZYistb73SvSvTc?=
 =?us-ascii?Q?Kh/q2Jncdgoa2oP6DP4Vm9guDDL/TfEGNGNwxOeTcjX31GGqTqTU+hMMhB8+?=
 =?us-ascii?Q?PA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c5a71403-63fa-4699-d036-08da5ed9505f
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 22:54:27.6499
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8+Z8KJCLxhl1iWxSR099N4v5/vBxb/7C5H65KAjGpEJdWiiwD+kIwr5YoX6s0C1TLZaI+0oDyzxE4der7KkzkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4869
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-05_18:2022-06-28,2022-07-05 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0
 adultscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207050098
X-Proofpoint-GUID: iwRc7p4mimcqiqXQUTx7U4zhudZulks0
X-Proofpoint-ORIG-GUID: iwRc7p4mimcqiqXQUTx7U4zhudZulks0
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/05/22 17:21, Gang Li wrote:
> show_free_areas() allows to filter out node specific data which is
> irrelevant to the allocation request. But hugetlb_show_meminfo() still
> shows hugetlb on all nodes, which is redundant and unnecessary.
> 
> Use show_mem_node_skip() to skip irrelevant nodes. And replace
> hugetlb_show_meminfo() with hugetlb_show_meminfo_node(nid).
> 
> Signed-off-by: Gang Li <ligang.bdlg@bytedance.com>
> ---
> v3: move for_each_hstate() into hugetlb_show_meminfo_node().
> v2: replace hugetlb_show_meminfo() with hugetlb_show_meminfo_node(nid) to avoid
>     exporting show_mem_node_skip.
> ---
>  include/linux/hugetlb.h |  4 ++--
>  mm/hugetlb.c            | 18 ++++++++----------
>  mm/page_alloc.c         |  8 ++++++--
>  3 files changed, 16 insertions(+), 14 deletions(-)

Thanks.  That should make hugetlb information produced by show_free_areas
consistent with other node specific information.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz