Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 10:30:40 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Robert Foss <robert.foss@linaro.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sam Ravnborg <sam@ravnborg.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Maxime Ripard <maxime@cerno.tech>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] drm/bridge: anx7625: Use
 pm_runtime_force_suspend(resume)
Message-ID: <20220706023040.GB2357796@anxtwsw-Precision-3640-Tower>
References: <20220629160550.433980-1-hsinyi@chromium.org>
 <20220629160550.433980-3-hsinyi@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220629160550.433980-3-hsinyi@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YBL0MKwaQ0tfdyPE0eZY730+uOEXrbSG9C4hCe+FxXPXMJx+VLq8xFildcbp?=
 =?us-ascii?Q?ysC+V1/l0+veVmyBgvQMRtQgeVYgrs/dwA9Hc6bJHmik50qh4C9kQnIMB/sU?=
 =?us-ascii?Q?HV5IvvbXt6WIsyhT7NK+mCS9w+ggfzQYGtaVhgnYEQMMthSE2QLHp4QNqIfh?=
 =?us-ascii?Q?kNLsZm3LsF+WU7eeWtsnfY4eVJmNU7cerwDukroD2RjHEj7W/3bFhAcTr5KH?=
 =?us-ascii?Q?v5MIYD++B2Tx0aKugg46sLQOlRvKYD4RfQLy8uokEvF2BReC+bVgLYsRpNP9?=
 =?us-ascii?Q?725I3tpnep41eku911pXHZAJFQoOcG9npNhTEAWDunuD3pNXq3y4q8Ae6EhM?=
 =?us-ascii?Q?cCqJx+ox4sigdGVsgrUtjgP8Sts8SsHz1EQxLMxEvAhdJWRG5vyUod6bMSNU?=
 =?us-ascii?Q?c8LHaUnNsC9/wnwsKCdNg9ip54HhrNtFPTCJQCuXJeKbVwy9K+Y/ovh6s6oI?=
 =?us-ascii?Q?uX0gxsnK977y5z8dk3OUuDB9qQLFx+Jy0XYYOfFmRse1jLMz+Ao5ig3oMwb7?=
 =?us-ascii?Q?7gwLcsyYU9NNTZa4UpxSMcFZ5uYKAVwsM2mSQZnuna2neZwxOk4Pw/TQ7HoF?=
 =?us-ascii?Q?JwtoL/znWbK+3ExmhakCAdkkO184pNAZLCXl06SnwRuANW4ypNOpfkXPQdnY?=
 =?us-ascii?Q?YZy8J4m2gB1O446+4kOzuVMPsdTt6PKdo7/QW2AS3FK+FYvVcGMn46UxdqL6?=
 =?us-ascii?Q?qmcc3qlt4bV/+guEKYyITQzj372Q0eXzuRbhLM3jkPaGaWwPksrXrrQui/jW?=
 =?us-ascii?Q?F1+wzkfRakpcovpUj30CATbSmyDdx+JuewOBqJC48vHKkzmVQrd/RrqnwtuL?=
 =?us-ascii?Q?aGebXDmMSaLAytnsz4lhvBFatvkNQmksX77KSsiwqfhBrGUF9NCiaG26AsXV?=
 =?us-ascii?Q?kr2BOV/0/FkBG2QM7ycUaoCXF6ZfOA7mPpkwEXJCHSQwZW/hAwxh2+2VKXgi?=
 =?us-ascii?Q?DomTvkWWHR4tWZHektRcWv7uDitErFKC0jiZZrID5oWQ+409XPSrplJjto0s?=
 =?us-ascii?Q?y53NNa3mPqV2B+PrvNGzpqcwh2txTyVBcY9rNEUXlK43vEsotLfCJLivofkh?=
 =?us-ascii?Q?Pt96b1WDawz98HvX6jOj7Z9Ln0WvPEU3aEKZGmO/hCohiUtyRF9hbCGRyTlv?=
 =?us-ascii?Q?bml4nWkMetXkGTfP6qmPhfDH8TKWepQhlzP8NeEfl/WkevU24EkLg2Ayz+Zt?=
 =?us-ascii?Q?soyOs4DOXUkfsPxlNLNYDxqlbXNzSPlFsoGO0dGtRysn2FZZMjpf+QeACbbH?=
 =?us-ascii?Q?Gu/iRljcBAbxDPZwgv2UzcIvXFMa8ZeZfKDtd6MC23MUzNxfia9MeE53kcR1?=
 =?us-ascii?Q?JR/9/QgiU9a5Hl9FiMTLct8wQJWlunbIyYw0vqx5uxNC4NDnyT/UFYOaUhty?=
 =?us-ascii?Q?AcX+6U1gA/+9+BKia3BL/oCisZKH3T0ptmfCRUkamIKXvJHp60lLx4wSTTEu?=
 =?us-ascii?Q?9Be5ZlVavvqYUzf7YmDAQz2SxNE+MBh90QSKIOZKMqggwXj3FX3/D18QC0FP?=
 =?us-ascii?Q?3cVrqgN+mDH6CkZE15E0w8xHt+0cgEyBcOcn0QfalrBP19vkVdg6Adi7+NwY?=
 =?us-ascii?Q?2IcAswM/hh6ZXgooJcuD11kRR/UkTb9X0R7s9MzJ?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 252a6ac8-868a-451e-aa53-08da5ef7873d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 02:30:44.7757
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: rJTh9VXihIwsmvviq8Igmi3auvP3kW95orjwof8DK8/6FIANy1q4VeHdh3YWpCwyiMOIRDDSl/68c60ecWL+/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0401MB3523
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Hsin-Yi, thanks for your patch, looks good to me.

Reviewed-by: Xin Ji <xji@analogixsemi.com>

Thanks,
Xin
On Thu, Jun 30, 2022 at 12:05:48AM +0800, Hsin-Yi Wang wrote:
> There's no need to check for IRQ or disable it in suspend.
> 
> Use pm_runtime_force_suspend(resume) to make sure anx7625 is powered off
> correctly. Make the system suspend/resume and pm runtime suspend/resume
> more consistant.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 33 ++---------------------
>  1 file changed, 2 insertions(+), 31 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index f89e8151475f7..478f5af381c7d 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2504,38 +2504,9 @@ static int __maybe_unused anx7625_runtime_pm_resume(struct device *dev)
>  	return 0;
>  }
>  
> -static int __maybe_unused anx7625_resume(struct device *dev)
> -{
> -	struct anx7625_data *ctx = dev_get_drvdata(dev);
> -
> -	if (!ctx->pdata.intp_irq)
> -		return 0;
> -
> -	if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) {
> -		enable_irq(ctx->pdata.intp_irq);
> -		anx7625_runtime_pm_resume(dev);
> -	}
> -
> -	return 0;
> -}
> -
> -static int __maybe_unused anx7625_suspend(struct device *dev)
> -{
> -	struct anx7625_data *ctx = dev_get_drvdata(dev);
> -
> -	if (!ctx->pdata.intp_irq)
> -		return 0;
> -
> -	if (!pm_runtime_enabled(dev) || !pm_runtime_suspended(dev)) {
> -		anx7625_runtime_pm_suspend(dev);
> -		disable_irq(ctx->pdata.intp_irq);
> -	}
> -
> -	return 0;
> -}
> -
>  static const struct dev_pm_ops anx7625_pm_ops = {
> -	SET_SYSTEM_SLEEP_PM_OPS(anx7625_suspend, anx7625_resume)
> +	SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
> +				pm_runtime_force_resume)
>  	SET_RUNTIME_PM_OPS(anx7625_runtime_pm_suspend,
>  			   anx7625_runtime_pm_resume, NULL)
>  };
> -- 
> 2.37.0.rc0.161.g10f37bed90-goog