Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 10:31:48 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Robert Foss <robert.foss@linaro.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sam Ravnborg <sam@ravnborg.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Maxime Ripard <maxime@cerno.tech>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] drm/bridge: anx7625: Fix NULL pointer crash when
 using edp-panel
Message-ID: <20220706023148.GC2357796@anxtwsw-Precision-3640-Tower>
References: <20220629160550.433980-1-hsinyi@chromium.org>
 <20220629160550.433980-4-hsinyi@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220629160550.433980-4-hsinyi@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2ewWd/b8agBW4Szyo9MFA8ISLL0Y+BUHd7pblhEG8NGsOx62lsnYToZ8ezgm?=
 =?us-ascii?Q?aI1ZXL2hFOFVxwXqr1Fu0b7h1qdZ9vdgznAgrNvoSSQe5osbT2k1zF6cAS8U?=
 =?us-ascii?Q?AuBzN9FrXsAi7hkUT4ikXnANs3JdAQmkT2NZzbB+SMv81IpQQBA5GT11WyVN?=
 =?us-ascii?Q?vxjqiWGV7LIxLAcgxTojkutVo5kx9uqbhIdr7aRreDDs0MlB65qESHP2BA76?=
 =?us-ascii?Q?GGuujpBaoeQS4TamiomndDKvpMja39cm8Pz61vvaWSBWYqYk1Hs8NxSNv2Tk?=
 =?us-ascii?Q?3tOgWg6yqujErijLtXpOFdoR6+gb5yfFgNbF6atPRDa3wn79SAlYytNA0xd5?=
 =?us-ascii?Q?TJ8J47WqsxsuTYUyUXDRfZgSVPtFs2PZ95Tk0mpkXikp8QlZaBaanySO7WD1?=
 =?us-ascii?Q?cc8UiIJxnK/m5wCH9tCkB1tSJNww78Wu01JWhNNJUuUcbr15EgNcb+ju+4Po?=
 =?us-ascii?Q?gbTF2ulMrnGeSisDQV+riaWwmLMk2bvEAWH1VGHXgXWnUrGLTE+HO+UdvtF2?=
 =?us-ascii?Q?Wxi0ei4/syENF+xCCD9FnF9o7xiG0BcNKoQ/yXS3GUpchOrwYVl1qBNexZNj?=
 =?us-ascii?Q?3rGpB3N5fjJ8SRNh+7gZNW9rV1BUQLpTDCSY058dlhGYkoDYGC6ZH2o+8lbC?=
 =?us-ascii?Q?UhDncIqqKFGk+OSuz6WT8LJFSloOG34yeKfWLDf34VmlDwrLte4KCHMTIFm9?=
 =?us-ascii?Q?EcpS9s0R/H8yjr5WuACn8F0UnzzACAtOlpbicXsnF2IzO/lI1V91xkirw3ZD?=
 =?us-ascii?Q?/OgzfnaG9QJs3Hc97ZolefBQzDNS2aKH7Ep0rjibIeO+lq8HvIk10j+1E/Mt?=
 =?us-ascii?Q?ie7oKNARTo+dEwbM+TJwqkSbNXFyyJF2C8PHxY9qj91IZ2znNmGK0uknjO0B?=
 =?us-ascii?Q?Yu2etKoK5fbD/UzMoDCTHuRMOwfam8EbLPYFFMIpTElccf12q16u1Snbhc8O?=
 =?us-ascii?Q?gFA9fPhO6KbL71uJOxNt7JDkX72l4I6iUuL2Jcoo+deWkLmr4SomeelfZ6+i?=
 =?us-ascii?Q?2tagLQ1suVMEMGrYTapiUtcr9W2RTaslk8eBSfWuqutePy1EiJohBMedcWqX?=
 =?us-ascii?Q?rtzK8EaVTdxQznzxiwFz3kWd5v3QfhI3EJi7iu+/S610+7uV+nDo0YtfCyiq?=
 =?us-ascii?Q?DGgoAZwGchN4AY4DDOI8yjhrekulB+nnRLsquJvzWMah5cYMmTSpuYn3mQJu?=
 =?us-ascii?Q?dN8BUiZvNOLFuv+IKDQ7v0yPX+VCzOofYQxReTloE29fNN4U/LTYzaT8T++0?=
 =?us-ascii?Q?YTHDe5FK5mhRLGZy0gYPm4GypAVHTx/eN3nneQwXucOT2JLrEg2GQVjZGzNe?=
 =?us-ascii?Q?xyYrov2igvexspQBXlPRG2+PTYtHqaDtJ50BLnCJaie21RrBb6MAL4F9k01H?=
 =?us-ascii?Q?ysG//qoQZ8bvP0YsC7C61lc4fYQ0L/FcjIaHnp6pUDRPTAYiaYlxo0Q/BVn4?=
 =?us-ascii?Q?dS8Rllpcn2tqijphAFt0/Y7dVRh4ZtcBDd+DHyzXo1CUthC5IygrZU9V46zF?=
 =?us-ascii?Q?jC+plOZo33pyrE6iBg0dSmr+UyVHaH1yi0RhCrrcPrtPLuZe8YjPA/uPxL5d?=
 =?us-ascii?Q?S/HjKg3KxFC+JdUdjIv5o9/PWFrFnod19v+afrv4?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b0ca321-f717-49ec-7b0c-08da5ef7afeb
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 02:31:53.0393
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7qUZDXrsuJQWsMkKaj8yscOEE7gfvS30Y6Qg4V0EFqjr9H8j27B3S3FuGofa5rdIYC5zp4dhLx1XEYpaUypXNA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4224
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Hsin-Yi, thanks for your patch, it looks good to me.

Reviewed-by: Xin Ji <xji@analogixsemi.com>

Thanks,
Xin

On Thu, Jun 30, 2022 at 12:05:49AM +0800, Hsin-Yi Wang wrote:
> Move devm_of_dp_aux_populate_ep_devices() after pm runtime and i2c setup
> to avoid NULL pointer crash.
> 
> edp-panel probe (generic_edp_panel_probe) calls pm_runtime_get_sync() to
> read EDID. At this time, bridge should have pm runtime enabled and i2c
> clients ready.
> 
> Fixes: adca62ec370c ("drm/bridge: anx7625: Support reading edid through aux channel")
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 478f5af381c7d..59ddeba33652b 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2590,14 +2590,6 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>  	platform->aux.dev = dev;
>  	platform->aux.transfer = anx7625_aux_transfer;
>  	drm_dp_aux_init(&platform->aux);
> -	devm_of_dp_aux_populate_ep_devices(&platform->aux);
> -
> -	ret = anx7625_parse_dt(dev, pdata);
> -	if (ret) {
> -		if (ret != -EPROBE_DEFER)
> -			DRM_DEV_ERROR(dev, "fail to parse DT : %d\n", ret);
> -		goto free_wq;
> -	}
>  
>  	if (anx7625_register_i2c_dummy_clients(platform, client) != 0) {
>  		ret = -ENOMEM;
> @@ -2613,6 +2605,15 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>  	if (ret)
>  		goto free_wq;
>  
> +	devm_of_dp_aux_populate_ep_devices(&platform->aux);
> +
> +	ret = anx7625_parse_dt(dev, pdata);
> +	if (ret) {
> +		if (ret != -EPROBE_DEFER)
> +			DRM_DEV_ERROR(dev, "fail to parse DT : %d\n", ret);
> +		goto free_wq;
> +	}
> +
>  	if (!platform->pdata.low_power_mode) {
>  		anx7625_disable_pd_protocol(platform);
>  		pm_runtime_get_sync(dev);
> -- 
> 2.37.0.rc0.161.g10f37bed90-goog