Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 10:29:26 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Robert Foss <robert.foss@linaro.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sam Ravnborg <sam@ravnborg.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Maxime Ripard <maxime@cerno.tech>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] drm/bridge: anx7625: Convert to
 devm_i2c_new_dummy_device()
Message-ID: <20220706022926.GA2357796@anxtwsw-Precision-3640-Tower>
References: <20220629160550.433980-1-hsinyi@chromium.org>
 <20220629160550.433980-2-hsinyi@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220629160550.433980-2-hsinyi@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?f1GDtp9Rr26ZC+W0GNu/3cdXhwa/o94ceD8EJmGa3rRxhWQGiBAVyhjSYDbw?=
 =?us-ascii?Q?1MXXz45XStO4N7jFflbqUuqXJlT+ty7xFew9GWs+LkG4CDF/NdnIDlKaKnbP?=
 =?us-ascii?Q?s8jJsA6SzdYb8XyeVAwuCwgAJ2Qk4pQ8KH8MbC1ADKDYrbagN23LyhuJP9ud?=
 =?us-ascii?Q?ISA+7awgGJOIyL7FPUiMcygpF7v+mmsnxZAtDtUsEXBYU6FihzXZsF+HodJ4?=
 =?us-ascii?Q?RILhVhdqGlmguLZp+2EtM38FIYLctwB0yCZxDdVwPhYEs/TBcLUeRedqrQiO?=
 =?us-ascii?Q?oqa9DbSxQx4F954nQJFw00/4+1JoTsrRpsUM7gGW9WcMymUtL7V89ZHIHRcK?=
 =?us-ascii?Q?x2QpRdWidVLPLdri6QtTO4GZFCvCtAEzDaKEuIEPcv0T/JNBR31rXjEXon9j?=
 =?us-ascii?Q?L2nZ+T4X9kkYrKaHwwEh+OcAHV09/+DvB017ZGmxw3v1+hA5p7Klwe6FpvQ4?=
 =?us-ascii?Q?02KGPhA4naOM7FVb7LqKyRRZpjfZR3oS9tndz/aAUW1WzdQ4j7iodBV5krVI?=
 =?us-ascii?Q?rQucliW0W+jlo++g2QToMraBKHqYUWq1ghc6JNC1VbEKZb/xoilsdOKgc1IX?=
 =?us-ascii?Q?G44tdL1ulsrBZTUP2jO12XN9PtkwAN9jtCb2byQ1gedb5Hby/JQYjmAww7CD?=
 =?us-ascii?Q?BsRFDnuiGaRWXdb7/YUPXUsvVVshqLA4hPaDBbmZVwLJoNagRaOJV34QDMh4?=
 =?us-ascii?Q?+NmRXL9j/74CLMudCDaNzHx+7coioHSTw/bnkpwsIJ3Wy5QfH1cLJ85+3JhK?=
 =?us-ascii?Q?C+grvBDUZS8om1g0CWaI4vXVBBM/cFHVNvEBbVWxJHuhY6/f45/rfWUOvAFm?=
 =?us-ascii?Q?rAI6O0vxZENDaiZ//7+TGJcs+rFGG0lDStjQeYNvtQUM+kAibyr4Q22rGthB?=
 =?us-ascii?Q?PRjNXIum4GA9cpPSQAw4KH3zrcCtv++F5a8tXVRZKrBzzesf4F4eBI3t4pMT?=
 =?us-ascii?Q?yhaw2UHN/szyyys0+wQNu1Q8Y1eC8vrgSXVVHLscLNLAWG2RASUq5Iy+2BJk?=
 =?us-ascii?Q?1RxNxHuhuJwBX966w/XmUWcECJ5oE4mMB8J/v5yq1dMrRlKWw/x6TRz5eP7X?=
 =?us-ascii?Q?+yEwldf+24t9KOJVwkcPhpJp1Xs59mTVmLNU1F+M8ngaP7rojfwKSGLfPVAI?=
 =?us-ascii?Q?DF3NJa7EQh4d5Aufe9J3kj5+Fww/PkrUyKVSN0RiOqnXyHaXdKEsQ0yqNota?=
 =?us-ascii?Q?bae/l+Mo/WHaYlTyzbT3OE1OHauD1YFPVvMSGaWReJUe+UfXXDUBFMzZ3qFU?=
 =?us-ascii?Q?RQ0QShfPVtjFRKX9gm1WPaz+k70wejrxBtfmoujKqSw2r/GeKDiqEJNcF8tV?=
 =?us-ascii?Q?0gShUVxyZIjIHJPWA/OUYBJXoUt9ljakkASdGnD2qK/C6M0sjd+AtgO1HDAV?=
 =?us-ascii?Q?S4Ib0eiSp3jD/npnIrDyj3g8ci8r7cZlklLw4eqeiw7SM34O0+i0JkALIw1n?=
 =?us-ascii?Q?JInPe8m4QiaYzq/C99ca4SJlEm1VtY+OE++NUIfnEJvDIZPr/bzAKFBFEvNt?=
 =?us-ascii?Q?zCir18+wFUhHrNgizSjU4oYYvRlKy12CrIRrrRDl9I4Qz7A7hKKPfJ5VP1rW?=
 =?us-ascii?Q?bFT4+qczU24eo9GV72YiaO846Vl9vzRCbwQUw6FA?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bfbaba0-cc8b-4623-b8e7-08da5ef75db7
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 02:29:35.1569
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: f2QMDFcAczkBiYJQ2iNIuo98qyT0IHoGWqj38f09dgSn9Me4V+nxNk97V5zjOknMZh3IX86g7tgbI9d37iciBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR0401MB3523
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Hsin-Yi, thanks for your patch, looks good to me.

Reviewed-by: Xin Ji <xji@analogixsemi.com>

On Thu, Jun 30, 2022 at 12:05:47AM +0800, Hsin-Yi Wang wrote:
> Simplify the resource management.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 96 +++++++----------------
>  1 file changed, 27 insertions(+), 69 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 3710fa9ee0acd..f89e8151475f7 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -2436,82 +2436,44 @@ static const struct drm_bridge_funcs anx7625_bridge_funcs = {
>  static int anx7625_register_i2c_dummy_clients(struct anx7625_data *ctx,
>  					      struct i2c_client *client)
>  {
> -	int err = 0;
> +	struct device *dev = &ctx->client->dev;
>  
> -	ctx->i2c.tx_p0_client = i2c_new_dummy_device(client->adapter,
> -						     TX_P0_ADDR >> 1);
> +	ctx->i2c.tx_p0_client = devm_i2c_new_dummy_device(dev, client->adapter,
> +						TX_P0_ADDR >> 1);
>  	if (IS_ERR(ctx->i2c.tx_p0_client))
>  		return PTR_ERR(ctx->i2c.tx_p0_client);
>  
> -	ctx->i2c.tx_p1_client = i2c_new_dummy_device(client->adapter,
> -						     TX_P1_ADDR >> 1);
> -	if (IS_ERR(ctx->i2c.tx_p1_client)) {
> -		err = PTR_ERR(ctx->i2c.tx_p1_client);
> -		goto free_tx_p0;
> -	}
> +	ctx->i2c.tx_p1_client = devm_i2c_new_dummy_device(dev, client->adapter,
> +						TX_P1_ADDR >> 1);
> +	if (IS_ERR(ctx->i2c.tx_p1_client))
> +		return PTR_ERR(ctx->i2c.tx_p1_client);
>  
> -	ctx->i2c.tx_p2_client = i2c_new_dummy_device(client->adapter,
> -						     TX_P2_ADDR >> 1);
> -	if (IS_ERR(ctx->i2c.tx_p2_client)) {
> -		err = PTR_ERR(ctx->i2c.tx_p2_client);
> -		goto free_tx_p1;
> -	}
> +	ctx->i2c.tx_p2_client = devm_i2c_new_dummy_device(dev, client->adapter,
> +						TX_P2_ADDR >> 1);
> +	if (IS_ERR(ctx->i2c.tx_p2_client))
> +		return PTR_ERR(ctx->i2c.tx_p2_client);
>  
> -	ctx->i2c.rx_p0_client = i2c_new_dummy_device(client->adapter,
> -						     RX_P0_ADDR >> 1);
> -	if (IS_ERR(ctx->i2c.rx_p0_client)) {
> -		err = PTR_ERR(ctx->i2c.rx_p0_client);
> -		goto free_tx_p2;
> -	}
> +	ctx->i2c.rx_p0_client = devm_i2c_new_dummy_device(dev, client->adapter,
> +						RX_P0_ADDR >> 1);
> +	if (IS_ERR(ctx->i2c.rx_p0_client))
> +		return PTR_ERR(ctx->i2c.rx_p0_client);
>  
> -	ctx->i2c.rx_p1_client = i2c_new_dummy_device(client->adapter,
> -						     RX_P1_ADDR >> 1);
> -	if (IS_ERR(ctx->i2c.rx_p1_client)) {
> -		err = PTR_ERR(ctx->i2c.rx_p1_client);
> -		goto free_rx_p0;
> -	}
> +	ctx->i2c.rx_p1_client = devm_i2c_new_dummy_device(dev, client->adapter,
> +						RX_P1_ADDR >> 1);
> +	if (IS_ERR(ctx->i2c.rx_p1_client))
> +		return PTR_ERR(ctx->i2c.rx_p1_client);
>  
> -	ctx->i2c.rx_p2_client = i2c_new_dummy_device(client->adapter,
> -						     RX_P2_ADDR >> 1);
> -	if (IS_ERR(ctx->i2c.rx_p2_client)) {
> -		err = PTR_ERR(ctx->i2c.rx_p2_client);
> -		goto free_rx_p1;
> -	}
> +	ctx->i2c.rx_p2_client = devm_i2c_new_dummy_device(dev, client->adapter,
> +						RX_P2_ADDR >> 1);
> +	if (IS_ERR(ctx->i2c.rx_p2_client))
> +		return PTR_ERR(ctx->i2c.rx_p2_client);
>  
> -	ctx->i2c.tcpc_client = i2c_new_dummy_device(client->adapter,
> -						    TCPC_INTERFACE_ADDR >> 1);
> -	if (IS_ERR(ctx->i2c.tcpc_client)) {
> -		err = PTR_ERR(ctx->i2c.tcpc_client);
> -		goto free_rx_p2;
> -	}
> +	ctx->i2c.tcpc_client = devm_i2c_new_dummy_device(dev, client->adapter,
> +						TCPC_INTERFACE_ADDR >> 1);
> +	if (IS_ERR(ctx->i2c.tcpc_client))
> +		return PTR_ERR(ctx->i2c.tcpc_client);
>  
>  	return 0;
> -
> -free_rx_p2:
> -	i2c_unregister_device(ctx->i2c.rx_p2_client);
> -free_rx_p1:
> -	i2c_unregister_device(ctx->i2c.rx_p1_client);
> -free_rx_p0:
> -	i2c_unregister_device(ctx->i2c.rx_p0_client);
> -free_tx_p2:
> -	i2c_unregister_device(ctx->i2c.tx_p2_client);
> -free_tx_p1:
> -	i2c_unregister_device(ctx->i2c.tx_p1_client);
> -free_tx_p0:
> -	i2c_unregister_device(ctx->i2c.tx_p0_client);
> -
> -	return err;
> -}
> -
> -static void anx7625_unregister_i2c_dummy_clients(struct anx7625_data *ctx)
> -{
> -	i2c_unregister_device(ctx->i2c.tx_p0_client);
> -	i2c_unregister_device(ctx->i2c.tx_p1_client);
> -	i2c_unregister_device(ctx->i2c.tx_p2_client);
> -	i2c_unregister_device(ctx->i2c.rx_p0_client);
> -	i2c_unregister_device(ctx->i2c.rx_p1_client);
> -	i2c_unregister_device(ctx->i2c.rx_p2_client);
> -	i2c_unregister_device(ctx->i2c.tcpc_client);
>  }
>  
>  static int __maybe_unused anx7625_runtime_pm_suspend(struct device *dev)
> @@ -2723,8 +2685,6 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>  	if (!platform->pdata.low_power_mode)
>  		pm_runtime_put_sync_suspend(&client->dev);
>  
> -	anx7625_unregister_i2c_dummy_clients(platform);
> -
>  free_wq:
>  	if (platform->workqueue)
>  		destroy_workqueue(platform->workqueue);
> @@ -2754,8 +2714,6 @@ static int anx7625_i2c_remove(struct i2c_client *client)
>  	if (!platform->pdata.low_power_mode)
>  		pm_runtime_put_sync_suspend(&client->dev);
>  
> -	anx7625_unregister_i2c_dummy_clients(platform);
> -
>  	if (platform->pdata.audio_en)
>  		anx7625_unregister_audio(platform);
>  
> -- 
> 2.37.0.rc0.161.g10f37bed90-goog