Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 10:32:55 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Robert Foss <robert.foss@linaro.org>,
        Andrzej Hajda <andrzej.hajda@intel.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        Jonas Karlman <jonas@kwiboo.se>,
        Jernej Skrabec <jernej.skrabec@gmail.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sam Ravnborg <sam@ravnborg.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Maxime Ripard <maxime@cerno.tech>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] drm/bridge: anx7625: Add wait_hpd_asserted() callback
Message-ID: <20220706023255.GD2357796@anxtwsw-Precision-3640-Tower>
References: <20220629160550.433980-1-hsinyi@chromium.org>
 <20220629160550.433980-5-hsinyi@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220629160550.433980-5-hsinyi@chromium.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5S01dHVRcf7EEi6fqBQoY00XzMb9h0SKArL1B8Wc8d7Zrh4m6EfpHewKAU5P?=
 =?us-ascii?Q?jkaUezT88EmbmH0CNg0LoY1QIkMiDvuK1avJi4xEmIsibR2QFO/I7/rTDbfs?=
 =?us-ascii?Q?PhUgrsgHwDYRmaWdqckH4o056qAALrrSCB092PhAC+hvECCOl0oHTDHovnLh?=
 =?us-ascii?Q?6SHMvrRjhglzyzgIOOgC3K+9vkluZmBzRY4jF/rVHwLqktg+0vzI3gVW0+62?=
 =?us-ascii?Q?JDZWy5GOOpyAaVsEBFsZJ0u9ankTAGIQ9YGtRQbF5sAYeoP8NSjRBB2Unl0K?=
 =?us-ascii?Q?Twe8VTAbvB1eTTVhirzqqyP1jWdwrhZzVWA4aIo9dxoDBlhuc4JBM/WVVIFg?=
 =?us-ascii?Q?/cxCeYGaC4hFoOiXqusPNdJ9Obe9Zs9CfEdvtMU8v9zn5wVTKtUY8aLdYHk3?=
 =?us-ascii?Q?0aL2p0HaryAj9xoh8cJhuMQantufyr7h0gaevAL5u/BkGHH7h/o8csRo9u1P?=
 =?us-ascii?Q?uD/PpwF42MuGvKon24U6fqRnALmFUmLN8jocGjH0J0YoKvwSr6AKJOVNUxqQ?=
 =?us-ascii?Q?oynY4QhKU3YQihVOoOfCSEYj+EXkHFpsulBfuQIugN/Xi+QZMb9D3TfxOAl1?=
 =?us-ascii?Q?xXyR2KffD7lg0Z3Iw16ddojXD+dTcUC0x86ZUA5I3wsWIvt1Xd+t2bdjFEYv?=
 =?us-ascii?Q?GVJpkLQ2ZMFBAYRDpkJtRxBKtlQEaceENBTLGFBaVCltosCqJxKRdAd7JMxb?=
 =?us-ascii?Q?lZkazS+Kg7tzJWsKdYPZ4N19LM+RQEQ9MYupSPufeblvCSQhC1cLX0LD6xyG?=
 =?us-ascii?Q?V3WkrUZA8iciXjTxu3GZZVmlM8nrr1hsc2sHUlynK5oKiuKxSsQBiq2sPYMG?=
 =?us-ascii?Q?3j+bxovLGHy2xfeZAKTL/8VZdNarYMBemuTEn/JdSS5HktcPXRnlOJMrSNbD?=
 =?us-ascii?Q?z4HXuBGmnDP065DGT0L7zqayFXe5vhRLUXTr+4Yeig+bakWpz2rmyjE9Q9IY?=
 =?us-ascii?Q?8tSmckoKCSV7xHxb8Mdg+8BHEi86O2CND6yDk9QabQZWjCY33Szx03qw1bt3?=
 =?us-ascii?Q?bPsvYZZdNVNG6TUCu9CqUEvK95T71LgQsOMVSzMh4kI3iY36fh3Qjpsfgt/W?=
 =?us-ascii?Q?EOE3LWkTn2+yJTijQIrESHp8JfeNgDCpmW50i3TEKA48vGdzxQKZyGmiAJHj?=
 =?us-ascii?Q?oFlEihn4vEU+y2PamtSmQqf+OTGabS3D/xupkHDaT7FeyA88A5TZDTU3xjys?=
 =?us-ascii?Q?AlKrz0G9f9da3bYCNtioFnrlT3Qinv9Q+/U+jXd6pU3jELJ/jPOl0pxIXxgn?=
 =?us-ascii?Q?kbsuqLfZ+WTYPqiJy8U1Ar8TePKIiq5eBxpRu3IKWNQGUQdixj3NBasQJ0Ra?=
 =?us-ascii?Q?v9ipyOjLhwTj77ADaLll7YM5IoiDxIyNMqXweGYwVqPedPFcS2x7Srh2xoKs?=
 =?us-ascii?Q?yoPtoeLVUPJCf5rJRzoK1RV8q6EfdfATsem9AdDW9kkhyKOBTp0fi1aG3R/y?=
 =?us-ascii?Q?aoPmRu30RhHnw6CE7aWoC06d28k7LXHS4xLuHsQvD7LBql25/Gb0Wa7a9Yb7?=
 =?us-ascii?Q?YfTjVCJk0TVrmh0i9jzwrTVQMAG1coo5hP6r44jJj65pL1rbYSnZBL5y92oN?=
 =?us-ascii?Q?QLOGE7mFCsD+ucl1tz7mSCAVTcaeWUBelQYWRYcJ?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca6347fb-6f94-4aa0-d894-08da5ef7d86c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 02:33:00.8697
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HgwqpVF9P8wlJ/s8h8rCnrVFvr0MEl4SjfDN1mYkZJXfi0NheBVPF7nvSKotx1ukjui74GXoALcDzfIP4wYoWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR04MB1077
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Hsin-Yi, thanks for your patch, it looks good to me.

Reviewed-by: Xin Ji <xji@analogixsemi.com>

Thanks,
Xin

On Thu, Jun 30, 2022 at 12:05:50AM +0800, Hsin-Yi Wang wrote:
> Move hpd polling check into wait_hpd_asserted() callback. For the cases
> that aux transfer function wasn't used, do hpd polling check after pm
> runtime resume, which will power on the bridge.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
>  drivers/gpu/drm/bridge/analogix/anx7625.c | 33 ++++++++++++++++++-----
>  1 file changed, 27 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> index 59ddeba33652b..ea5a0b86fe52a 100644
> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> @@ -1443,23 +1443,24 @@ static int anx7625_read_hpd_status_p0(struct anx7625_data *ctx)
>  	return anx7625_reg_read(ctx, ctx->i2c.rx_p0_client, SYSTEM_STSTUS);
>  }
>  
> -static void anx7625_hpd_polling(struct anx7625_data *ctx)
> +static int _anx7625_hpd_polling(struct anx7625_data *ctx,
> +				 unsigned long wait_us)
>  {
>  	int ret, val;
>  	struct device *dev = &ctx->client->dev;
>  
>  	/* Interrupt mode, no need poll HPD status, just return */
>  	if (ctx->pdata.intp_irq)
> -		return;
> +		return 0;
>  
>  	ret = readx_poll_timeout(anx7625_read_hpd_status_p0,
>  				 ctx, val,
>  				 ((val & HPD_STATUS) || (val < 0)),
> -				 5000,
> -				 5000 * 100);
> +				 wait_us / 100,
> +				 wait_us);
>  	if (ret) {
>  		DRM_DEV_ERROR(dev, "no hpd.\n");
> -		return;
> +		return ret;
>  	}
>  
>  	DRM_DEV_DEBUG_DRIVER(dev, "system status: 0x%x. HPD raise up.\n", val);
> @@ -1472,6 +1473,23 @@ static void anx7625_hpd_polling(struct anx7625_data *ctx)
>  
>  	if (!ctx->pdata.panel_bridge && ctx->bridge_attached)
>  		drm_helper_hpd_irq_event(ctx->bridge.dev);
> +
> +	return 0;
> +}
> +
> +static int anx7625_wait_hpd_asserted(struct drm_dp_aux *aux,
> +				     unsigned long wait_us)
> +{
> +	struct anx7625_data *ctx = container_of(aux, struct anx7625_data, aux);
> +	struct device *dev = &ctx->client->dev;
> +	int ret;
> +
> +	pm_runtime_get_sync(dev);
> +	ret = _anx7625_hpd_polling(ctx, wait_us);
> +	pm_runtime_mark_last_busy(dev);
> +	pm_runtime_put_autosuspend(dev);
> +
> +	return ret;
>  }
>  
>  static void anx7625_remove_edid(struct anx7625_data *ctx)
> @@ -1741,6 +1759,7 @@ static struct edid *anx7625_get_edid(struct anx7625_data *ctx)
>  	}
>  
>  	pm_runtime_get_sync(dev);
> +	_anx7625_hpd_polling(ctx, 5000 * 100);
>  	edid_num = sp_tx_edid_read(ctx, p_edid->edid_raw_data);
>  	pm_runtime_put_sync(dev);
>  
> @@ -2378,6 +2397,7 @@ static void anx7625_bridge_atomic_enable(struct drm_bridge *bridge,
>  	ctx->connector = connector;
>  
>  	pm_runtime_get_sync(dev);
> +	_anx7625_hpd_polling(ctx, 5000 * 100);
>  
>  	anx7625_dp_start(ctx);
>  }
> @@ -2497,7 +2517,6 @@ static int __maybe_unused anx7625_runtime_pm_resume(struct device *dev)
>  	mutex_lock(&ctx->lock);
>  
>  	anx7625_power_on_init(ctx);
> -	anx7625_hpd_polling(ctx);
>  
>  	mutex_unlock(&ctx->lock);
>  
> @@ -2589,6 +2608,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>  	platform->aux.name = "anx7625-aux";
>  	platform->aux.dev = dev;
>  	platform->aux.transfer = anx7625_aux_transfer;
> +	platform->aux.wait_hpd_asserted = anx7625_wait_hpd_asserted;
>  	drm_dp_aux_init(&platform->aux);
>  
>  	if (anx7625_register_i2c_dummy_clients(platform, client) != 0) {
> @@ -2617,6 +2637,7 @@ static int anx7625_i2c_probe(struct i2c_client *client,
>  	if (!platform->pdata.low_power_mode) {
>  		anx7625_disable_pd_protocol(platform);
>  		pm_runtime_get_sync(dev);
> +		_anx7625_hpd_polling(platform, 5000 * 100);
>  	}
>  
>  	/* Add work function */
> -- 
> 2.37.0.rc0.161.g10f37bed90-goog