Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: 63CFAoHyGhzzSDQHagMtnu2ReKoyH3zZvAluyKdIpgYPwSDEEphEnbn4wOmE6+M9UoUineVkXi
 oUl5nz/5kENmo6td+mORQyUaRYvnpr9VGr9JBJ5jNdFR8xg3epfSjRylYmnVpm2uqorzJpAgKE
 Yr4xefFc5rOTI5pzMN6iCXy3a04Il4odKWeYg3Etw0ZrYAqnTJO5sDshGO1LqdmAnhB0mwo9qA
 Vkp1KLEdU3fnlWGF6UKLpRZl1kkIODaUWCv3f5AChAZh0VHIV4W+w0ckVc5JgfSH0WtRgG95sH
 9oMWzt/I5lDTMrvPyiO/R5MK
IronPort-SDR: eSV4xuAWo+hdTfnqnO7G1J2G4J1iTJ/v32GyE7DHK+b/4KLySSMA2qOldO9steFyothqeT2Npo
 VVVLkWR8v3t8JSvIfluHucE26x6Wl80s+im6pbMJQoI3MLhMVgT4yRzOECv49eMUNg7qR0LkLI
 JZ9DNjo5p+76wSctz9AdC1NGS077qRnTpsQ0yGnqygmynGpmUSYcU3TsqLquOwg6Q3rXC8SzMq
 bGv3cFrjjIT7bvc9DqIgqZMKu4VzBYSVxeEq9dFTqfwUxt0JI7yDzQtrr1yY+yjbghQltGoien
 t14=
WDCIronportException: Internal
Message-ID: <53aa543b-a109-046d-beda-91a15ef5a487@opensource.wdc.com>
Date:   Wed, 6 Jul 2022 12:49:47 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 5/5] riscv: dts: canaan: Add k210 topology information
Content-Language: en-US
To:     Conor Dooley <mail@conchuod.ie>, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Daire McNamara <daire.mcnamara@microchip.com>,
        Conor Dooley <conor.dooley@microchip.com>,
        Niklas Cassel <niklas.cassel@wdc.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Zong Li <zong.li@sifive.com>,
        Emil Renner Berthing <kernel@esmil.dk>,
        Jonas Hahnfeld <hahnjo@hahnjo.de>
Cc:     devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
        linux-kernel@vger.kernel.org, Brice Goglin <Brice.Goglin@inria.fr>
References: <20220705190435.1790466-1-mail@conchuod.ie>
 <20220705190435.1790466-6-mail@conchuod.ie>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220705190435.1790466-6-mail@conchuod.ie>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/6/22 04:04, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> The k210 has no cpu-map node, so tools like hwloc cannot correctly
> parse the topology. Add the node using the existing node labels.
> 
> Reported-by: Brice Goglin <Brice.Goglin@inria.fr>
> Link: https://github.com/open-mpi/hwloc/issues/536
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

Looks good to me.

Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>

> ---
>  arch/riscv/boot/dts/canaan/k210.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/riscv/boot/dts/canaan/k210.dtsi b/arch/riscv/boot/dts/canaan/k210.dtsi
> index 44d338514761..ec944d1537dc 100644
> --- a/arch/riscv/boot/dts/canaan/k210.dtsi
> +++ b/arch/riscv/boot/dts/canaan/k210.dtsi
> @@ -65,6 +65,18 @@ cpu1_intc: interrupt-controller {
>  				compatible = "riscv,cpu-intc";
>  			};
>  		};
> +
> +		cpu-map {
> +			cluster0 {
> +				core0 {
> +					cpu = <&cpu0>;
> +				};
> +
> +				core1 {
> +					cpu = <&cpu1>;
> +				};
> +			};
> +		};
>  	};
>  
>  	sram: memory@80000000 {


-- 
Damien Le Moal
Western Digital Research