Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 10:49:38 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>
Cc:     dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] dmaengine: pl330: Fix lockdep warning about
 non-static key
Message-ID: <YsUbasNhhZQKCCOs@matsya>
References: <20220520181432.149904-1-dmitry.osipenko@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220520181432.149904-1-dmitry.osipenko@collabora.com>
Precedence: bulk

On 20-05-22, 21:14, Dmitry Osipenko wrote:
> The DEFINE_SPINLOCK() macro shouldn't be used for dynamically allocated
> spinlocks. The lockdep warns about this and disables locking validator.
> Fix the warning by making lock static.
> 
>  INFO: trying to register non-static key.
>  The code is fine but needs lockdep annotation, or maybe
>  you didn't initialize this object before use?
>  turning off the locking correctness validator.
>  Hardware name: Radxa ROCK Pi 4C (DT)
>  Call trace:
>   dump_backtrace.part.0+0xcc/0xe0
>   show_stack+0x18/0x6c
>   dump_stack_lvl+0x8c/0xb8
>   dump_stack+0x18/0x34
>   register_lock_class+0x4a8/0x4cc
>   __lock_acquire+0x78/0x20cc
>   lock_acquire.part.0+0xe0/0x230
>   lock_acquire+0x68/0x84
>   _raw_spin_lock_irqsave+0x84/0xc4
>   add_desc+0x44/0xc0
>   pl330_get_desc+0x15c/0x1d0
>   pl330_prep_dma_cyclic+0x100/0x270
>   snd_dmaengine_pcm_trigger+0xec/0x1c0
>   dmaengine_pcm_trigger+0x18/0x24
>   ...

Applied, thanks

-- 
~Vinod