Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Subject: Re: [PATCH v3 2/5] dt-bindings: phy: Add ARTPEC-8 PCIe phy
Reply-To: wangseok.lee@samsung.com
Sender: Wangseok Lee <wangseok.lee@samsung.com>
From:   Wangseok Lee <wangseok.lee@samsung.com>
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzk+dt@kernel.org" <krzk+dt@kernel.org>,
        "kishon@ti.com" <kishon@ti.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jesper.nilsson@axis.com" <jesper.nilsson@axis.com>,
        "lars.persson@axis.com" <lars.persson@axis.com>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "kw@linux.com" <kw@linux.com>,
        "linux-arm-kernel@axis.com" <linux-arm-kernel@axis.com>,
        "kernel@axis.com" <kernel@axis.com>
CC:     Moon-Ki Jun <moonki.jun@samsung.com>,
        Sang Min Kim <hypmean.kim@samsung.com>,
        Dongjin Yang <dj76.yang@samsung.com>,
        Yeeun Kim <yeeun119.kim@samsung.com>
In-Reply-To: <43a075c6-ff48-acf2-0be7-634d292daf30@kernel.org>
Message-ID: <20220706052021epcms2p700172d20dbc02303cf9c6f7e66cebfbd@epcms2p7>
Date:   Wed, 06 Jul 2022 14:20:21 +0900
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <43a075c6-ff48-acf2-0be7-634d292daf30@kernel.org>
        <20220620083821epcms2p57a65984523a0f2a3815e4873e8bfc6df@epcms2p5>
        <4b4b08af-887b-89e9-b4a5-93e7d8a03222@kernel.org>
        <20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p7>
        <20220614012916epcms2p5cf8d55e7420dea10bb4a05d91aaf99dd@epcms2p5>
        <20220629071829epcms2p65eab75702495a939f3f6e4ea020181de@epcms2p6>
        <CGME20220614011616epcms2p7dcaa67c53b7df5802dd7a697e2d472d7@epcms2p7>
Precedence: bulk

On=C2=A005/07/2022=C2=A019:59,=C2=A0Krzysztof=20Kozlowski=C2=A0wrote:=0D=0A=
>=20On=C2=A029/06/2022=C2=A009:18,=C2=A0Wangseok=C2=A0Lee=C2=A0wrote:=0D=0A=
>>=C2=A0Just=C2=A0a=C2=A0gentle=C2=A0ping=C2=A0for=C2=A0this=C2=A0patch,=C2=
=A0if=C2=A0any=C2=A0concern=C2=A0on=C2=A0this=C2=A0patch=C2=A0please=C2=A0l=
et=C2=A0me=C2=A0know.=0D=0A>>=C2=A0=0D=0A>=20=0D=0A>=20You=C2=A0received=C2=
=A0comments=C2=A0to=C2=A0fix=C2=A0in=C2=A0this=C2=A0patch.=C2=A0Exactly=C2=
=A0four.=C2=A0Four=C2=A0important=0D=0A>=20points=C2=A0to=C2=A0fix.=C2=A0Th=
erefore=C2=A0what=C2=A0is=C2=A0this=C2=A0ping=C2=A0about?=0D=0A>=20=0D=0A>=
=20Without=C2=A0fixing=C2=A0these=C2=A0items,=C2=A0your=C2=A0patch=C2=A0can=
not=C2=A0be=C2=A0accepted.=C2=A0What=C2=A0is=C2=A0more=0D=0A>=20to=C2=A0pin=
g=C2=A0here?=0D=0A>=20=0D=0A>=20Best=C2=A0regards,=0D=0A>=20Krzysztof=0D=0A=
=0D=0AI=20tried=20to=20receive=20your=20opinion=20about=20the=20fix=20point=
=20.=0D=0AI=20will=20request=20a=20review=20again=20after=20modifying=20it=
=20in=20the=20next=20patch.=0D=0A=0D=0AThank=20you.=0D=0A=0D=0A>>>=20+=0D=
=0A>>>=20+=20=20clocks:=0D=0A>>>=20+=20=20=20=20items:=0D=0A>>>=20+=20=20=
=20=20=20=20-=20description:=20PCIe=20PHY=20reference=20clock=0D=0A>=20=0D=
=0A>=20refer=20to=20sample-schema.yaml,=20even=20if=20the=20clock=20item=20=
is=20single,=0D=0A>=20it=20seems=20to=20be=20used=20as=20follows.=0D=0A>=20=
=0D=0A>=20clocks:=0D=0A>=20=20=20maxItems:=201=0D=0A>=20=0D=0A>=20clock-nam=
es:=0D=0A>=20=20=20items:=0D=0A>=20=20=20=20=20-=20const:=20ref=0D=0A>=20=
=0D=0A>=20If=20only=20=22clocks:=22=20are=20define=20and=20clock-names=20ar=
e=20not=20define,=0D=0A>=20the=20following=20warning=20occurs.=0D=0A>=20=22=
'clock-names'=20does=20not=20match=20any=20of=20the=20regexes=22=0D=0A>=20=
=0D=0A>>>=20+=0D=0A>>>=20+=20=20lcpll-ref-clk:=0D=0A>>>=20+=20=20=20=20cons=
t:=201=0D=0A>>=20=0D=0A>>=20Unknown=20field...=20custom=20properties=20need=
=20vendor=20(axis,),=20type=20(boolean)=0D=0A>>=20and=20description.=0D=0A>=
>=20=0D=0A>=20=0D=0A>=20=22lcpl-ref-clk=22=20has=20an=20enum=20type=20value=
,=20so=20i=20will=20modify=20it=20as=20below.=0D=0A>=20=0D=0A>=20=0D=0A>=20=
axis,lcpll-ref-clk:=0D=0A>=20=20=20description:=0D=0A>=20=20=20=20=20select=
=20the=20reference=20clock=20of=20phy=20and=20initialization=20is=20perform=
ed=0D=0A>=20=20=20=20=20with=20the=20reference=20clock=20according=20to=20t=
he=20selected=20value.=0D=0A>=20=20=20=24ref:=20/schemas/types.yaml=23/defi=
nitions/uint32=0D=0A>=20=20=20enum:=20=5B=200,=201,=202,=203,=204=20=5D=0D=
=0A>=20