Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <91421440-578a-ccd1-21b3-7b8e2e8e2e8d@quicinc.com>
Date:   Wed, 6 Jul 2022 12:00:07 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.0
Subject: Re: [PATCH] PM: QoS: Add check to make sure CPU freq is non-negative
Content-Language: en-US
To:     <rafael@kernel.org>, <len.brown@intel.com>, <pavel@ucw.cz>
CC:     <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20220623064605.2538969-1-quic_kshivnan@quicinc.com>
From:   Shivnandan Kumar <quic_kshivnan@quicinc.com>
In-Reply-To: <20220623064605.2538969-1-quic_kshivnan@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Gentle reminder,

Thanks,

Shivnandan

On 6/23/2022 12:16 PM, Shivnandan Kumar wrote:
> 	CPU frequency should never be non-negative.
> 	If some client driver calls freq_qos_update_request with some
> 	value greater than INT_MAX, then it will set max CPU freq at
> 	fmax but it will add plist node with some negative priority.
> 	plist node has priority from INT_MIN (highest) to INT_MAX
> 	(lowest). Once priority is set as negative, another client
> 	will not be able to reduce max CPU frequency. Adding check
> 	to make sure CPU freq is non-negative will fix this problem.
> Signed-off-by: Shivnandan Kumar <quic_kshivnan@quicinc.com>
>
> ---
>   kernel/power/qos.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/power/qos.c b/kernel/power/qos.c
> index ec7e1e85923e..41e96fe34bfd 100644
> --- a/kernel/power/qos.c
> +++ b/kernel/power/qos.c
> @@ -531,7 +531,8 @@ int freq_qos_add_request(struct freq_constraints *qos,
>   {
>   	int ret;
>   
> -	if (IS_ERR_OR_NULL(qos) || !req)
> +	if (IS_ERR_OR_NULL(qos) || !req || value < FREQ_QOS_MIN_DEFAULT_VALUE
> +		|| value > FREQ_QOS_MAX_DEFAULT_VALUE)
>   		return -EINVAL;
>   
>   	if (WARN(freq_qos_request_active(req),
> @@ -563,7 +564,8 @@ EXPORT_SYMBOL_GPL(freq_qos_add_request);
>    */
>   int freq_qos_update_request(struct freq_qos_request *req, s32 new_value)
>   {
> -	if (!req)
> +	if (!req || new_value < FREQ_QOS_MIN_DEFAULT_VALUE ||
> +		new_value > FREQ_QOS_MAX_DEFAULT_VALUE)
>   		return -EINVAL;
>   
>   	if (WARN(!freq_qos_request_active(req),