Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 06 Jul 2022 08:05:30 +0100
Message-ID: <87fsjen2kl.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Sander Vanheule <sander@svanheule.net>
Cc:     Aleksander Jan Bajkowski <olek2@wp.pl>, tsbogend@alpha.franken.de,
        martin.blumenstingl@googlemail.com, hauke@hauke-m.de,
        git@birger-koblitz.de, linux-mips@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MIPS: smp-mt: enable all hardware interrupts on second VPE
In-Reply-To: <3c9a032edd0fb9b9608ad3ca08d6e3cc38f21464.camel@svanheule.net>
References: <20220702190705.5319-1-olek2@wp.pl>
        <3c9a032edd0fb9b9608ad3ca08d6e3cc38f21464.camel@svanheule.net>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Sun, 03 Jul 2022 19:15:11 +0100,
Sander Vanheule <sander@svanheule.net> wrote:
> 
> Hi Aleksander,
> 
> Since this is IRQ related: +CC Marc Zyngier
> 
> On Sat, 2022-07-02 at 21:07 +0200, Aleksander Jan Bajkowski wrote:
> > This patch is needed to handle interrupts by the second VPE on
> > the Lantiq xRX200, xRX300 and xRX330 SoCs. In these chips, 32 ICU
> > interrupts are connected to each hardware line. The SoC supports
> > a total of 160 interrupts. Currently changing smp_affinity to the
> > second VPE hangs interrupts.
> > 
> > This problem affects multithreaded SoCs with a custom interrupt
> > controller. Chips with 1004Kc core and newer use the MIPS GIC.
> > 
> > Also CC'ed Birger Koblitz and Sander Vanheule. Both are working
> > on support for Realtek RTL930x chips with 34Kc core and Birger
> > has added a patch in OpenWRT that also enables all interrupt
> > lines. So it looks like this patch is useful for more SoCs.
> > 
> > Tested on lantiq xRX200 and xRX330.
> > 
> > Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> 
> Thanks for bringing up this issue. Like you say OpenWrt carries a
> similar patch, and I also carry a patch on my tree to enable all CPU
> IRQ lines.
> 
> Indiscriminately enabling all IRQ lines doesn't sit quite right with
> me though, since I would expect these to be enabled
> on-demand. I.e. when a peripheral requests an IRQ, or when an IRQ
> controller is cascaded into one of the CPU's interrupt lines. If I
> understand correctly, the IRQ mask/unmask functions in
> drivers/irqchip/irq-mips-cpu.c should do this.

But this is only enabling interrupts at the CPU level, right? And the
irqchip is still in control of the masking of the individual
interrupts?

If both assertions are true, then this patch seems OK. If it just let
any interrupt through without any control, then this is wrong.

So which one is it?

	M.

-- 
Without deviation from the norm, progress is not possible.