Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220705191327.1684277-1-robimarko@gmail.com> <20220705191327.1684277-3-robimarko@gmail.com>
In-Reply-To: <20220705191327.1684277-3-robimarko@gmail.com>
From:   Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date:   Wed, 6 Jul 2022 11:39:44 +0300
Message-ID: <CAA8EJpqLy71fzr9Rn-quTzZXsc20PbcOp56djeHY-cApBJ4Xeg@mail.gmail.com>
Subject: Re: [PATCH v5 3/3] arm64: dts: ipq8074: add APCS node
To:     Robert Marko <robimarko@gmail.com>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org,
        konrad.dybcio@somainline.org, jassisinghbrar@gmail.com,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 5 Jul 2022 at 22:13, Robert Marko <robimarko@gmail.com> wrote:
>
> APCS now has support for providing the APSS clocks as the child device
> for IPQ8074.
>
> So, add the required DT node for it as it will later be used as the CPU
> clocksource.
>
> Signed-off-by: Robert Marko <robimarko@gmail.com>

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---
> Changes in v3:
> * Node does not currently exist in the upstream kernel, so add it instead
> of modifying.
> ---
>  arch/arm64/boot/dts/qcom/ipq8074.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> index b4ae13f16398..76707b9f9845 100644
> --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi
> @@ -886,5 +886,13 @@ IRQ_TYPE_LEVEL_HIGH>, /* int_c */
>                                       "axi_m_sticky";
>                         status = "disabled";
>                 };
> +
> +               apcs_glb: mailbox@b111000 {
> +                       compatible = "qcom,ipq8074-apcs-apps-global";
> +                       reg = <0x0b111000 0x6000>;
> +
> +                       #clock-cells = <1>;
> +                       #mbox-cells = <1>;
> +               };
>         };
>  };
> --
> 2.36.1
>


-- 
With best wishes
Dmitry