Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d860aca2-442a-8583-e39a-1fdc2a5945b5@denx.de>
Date:   Wed, 6 Jul 2022 10:28:26 +0200
MIME-Version: 1.0
Subject: Re: [PATCH v3] dmaengine: altera-msgdma: Fixed some inconsistent
 function name descriptions
Content-Language: en-US
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        olivierdautricourt@gmail.com
Cc:     vkoul@kernel.org, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220706082605.114907-1-jiapeng.chong@linux.alibaba.com>
From:   Stefan Roese <sr@denx.de>
In-Reply-To: <20220706082605.114907-1-jiapeng.chong@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 06.07.22 10:26, Jiapeng Chong wrote:
> Inconsistent function names describing msgdma_chan_remove() and
> msgdma_dma_remove are modified to msgdma_dev_remove() and msgdma_remove().
> 
> Remove some warnings found by running scripts/kernel-doc, which is caused
> by using 'make W=1'.
> 
> drivers/dma/altera-msgdma.c:927: warning: expecting prototype for msgdma_dma_remove(). Prototype was for msgdma_remove() instead.
> drivers/dma/altera-msgdma.c:758: warning: expecting prototype for msgdma_chan_remove(). Prototype was for msgdma_dev_remove() instead.
> 
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> Changes in v3:
>    -Modified the commit title and message.
> 
>   drivers/dma/altera-msgdma.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/altera-msgdma.c b/drivers/dma/altera-msgdma.c
> index 6f56dfd375e3..4153c2edb049 100644
> --- a/drivers/dma/altera-msgdma.c
> +++ b/drivers/dma/altera-msgdma.c
> @@ -749,7 +749,7 @@ static irqreturn_t msgdma_irq_handler(int irq, void *data)
>   }
>   
>   /**
> - * msgdma_chan_remove - Channel remove function
> + * msgdma_dev_remove() - Device remove function
>    * @mdev: Pointer to the Altera mSGDMA device structure
>    */
>   static void msgdma_dev_remove(struct msgdma_device *mdev)
> @@ -918,7 +918,7 @@ static int msgdma_probe(struct platform_device *pdev)
>   }
>   
>   /**
> - * msgdma_dma_remove - Driver remove function
> + * msgdma_remove() - Driver remove function
>    * @pdev: Pointer to the platform_device structure
>    *
>    * Return: Always '0'

Viele Grüße,
Stefan Roese

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de