Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 06 Jul 2022 10:57:33 +0200
From:   Michael Walle <michael@walle.cc>
To:     Claudiu.Beznea@microchip.com
Cc:     robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
        Cristian.Birsan@microchip.com,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port
In-Reply-To: <32a2193f-aea1-6237-a993-d0ba89cce431@microchip.com>
References: <20220705130637.1386120-1-michael@walle.cc>
 <20220705130637.1386120-2-michael@walle.cc>
 <32a2193f-aea1-6237-a993-d0ba89cce431@microchip.com>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <1747f5d89ca65a9e54d95e7dd77c4709@walle.cc>
Precedence: bulk

Hi Claudiu,

Am 2022-07-06 10:41, schrieb Claudiu.Beznea@microchip.com:
> On 05.07.2022 16:06, Michael Walle wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
>> the content is safe
>> 
>> Now that there is driver support for the USB device, enable it.
>> 
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>>  arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi 
>> b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> index 5a6c5f7c371a..d0d26e136c38 100644
>> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> @@ -200,6 +200,11 @@ &switch {
>>         status = "okay";
>>  };
>> 
>> +&udc {
>> +       atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
> 
> Can you also add pinctrl to avoid issues described in:

Do I need a pinctrl node even if I just use it as a gpio?
Isn't that handled automatically by the
.gpio_request_enable op?

-michael