Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8f9651b2-ca9a-413c-d94f-9ecf3717343c@linaro.org>
Date:   Wed, 6 Jul 2022 12:04:49 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 1/2] [V1,1/2] arm64: dts: qcom: Add LTE SKUs for
 sc7280-villager family
Content-Language: en-US
To:     Jimmy Chen <jinghung.chen3@hotmail.com>
Cc:     agross@kernel.org, alan-huang@quanta.corp-partner.google.com,
        bjorn.andersson@linaro.org, devicetree@vger.kernel.org,
        dianders@chromium.org, konrad.dybcio@somainline.org,
        krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org, robh+dt@kernel.org
References: <cfc2c27a-444d-8bd8-84a7-b6b1f99258f9@linaro.org>
 <SG2PR03MB5006AB4C7E356CE321F628D9CC809@SG2PR03MB5006.apcprd03.prod.outlook.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <SG2PR03MB5006AB4C7E356CE321F628D9CC809@SG2PR03MB5006.apcprd03.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 06/07/2022 11:36, Jimmy Chen wrote:
> To keep the consistency of the format for Chromebook items,
> we basically add these items based on the rules discussed in the previous patch series here
> https://lore.kernel.org/all/20220520143502.v4.1.I71e42c6174f1cec17da3024c9f73ba373263b9b6@changeid/.
> 
> We are little configured with “one entry - one enum “. Do you mean something like below example?
> We suggest keep items separated as it is more readable.
> 
>       - description: Google Villager
>         items:
>           - const: google,villager-rev0
>           - const: google,villager
>           - const: google,villager-rev0-sku0
>           - const: google,villager-sku0
>           - const: qcom,sc7280
> 

Is this a reply to something we discussed? There is no quote here, but I
remember pointing out some issues with one of Google patches recently.
Unfortunately my mailbox receives like 300 mails per day, so this does
not help...

Best regards,
Krzysztof