Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62c56658.1c69fb81.87c41.6b07@mx.google.com>
Date:   Wed, 6 Jul 2022 12:22:43 +0200
From:   Christian Marangi <ansuelsmth@gmail.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] ARM: dts: qcom: add pxo/cxo clock-output-names for
 ipq8064
References: <20220705202837.667-1-ansuelsmth@gmail.com>
 <20220705202837.667-5-ansuelsmth@gmail.com>
 <CAA8EJppTCZRpi8EqmRSJQiSmaANr=5+q5Rb5KsMYZROSNGpGqA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAA8EJppTCZRpi8EqmRSJQiSmaANr=5+q5Rb5KsMYZROSNGpGqA@mail.gmail.com>
Precedence: bulk

On Wed, Jul 06, 2022 at 11:29:09AM +0300, Dmitry Baryshkov wrote:
> On Tue, 5 Jul 2022 at 23:56, Christian Marangi <ansuelsmth@gmail.com> wrote:
> >
> > Drivers expect to call pxo/cxo_board clock as pxo/cxo.
> > Use clock-output-names to set the correct naming for these fixed clock
> > to save drivers that are migrating to parent_data and still use
> > parent_names.
> 
> Please no. There is no reason to add these names. Let's follow the
> example of other platforms.
>

Okok... just don't like the '_board' suffix but will drop...

> >
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > ---
> >  arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > index 1425a4e4283f..720e27e29627 100644
> > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > @@ -302,12 +302,14 @@ cxo_board: cxo_board {
> >                         compatible = "fixed-clock";
> >                         #clock-cells = <0>;
> >                         clock-frequency = <25000000>;
> > +                       clock-output-names = "cxo";
> >                 };
> >
> >                 pxo_board: pxo_board {
> >                         compatible = "fixed-clock";
> >                         #clock-cells = <0>;
> >                         clock-frequency = <25000000>;
> > +                       clock-output-names = "pxo";
> >                 };
> >
> >                 sleep_clk: sleep_clk {
> > --
> > 2.36.1
> >
> 
> 
> -- 
> With best wishes
> Dmitry

-- 
	Ansuel