Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62c569df.1c69fb81.9be2b.0cd0@mx.google.com>
Date:   Wed, 6 Jul 2022 12:37:46 +0200
From:   Christian Marangi <ansuelsmth@gmail.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jonathan McDowell <noodles@earth.li>
Subject: Re: [PATCH 09/13] ARM: dts: qcom: add smem node for ipq8064
References: <20220705133917.8405-1-ansuelsmth@gmail.com>
 <20220705133917.8405-10-ansuelsmth@gmail.com>
 <c5bf6246-a350-8a87-71bc-bc13d502a8af@linaro.org>
 <62c56477.1c69fb81.8ec4c.f1ac@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <62c56477.1c69fb81.8ec4c.f1ac@mx.google.com>
Precedence: bulk

On Wed, Jul 06, 2022 at 12:14:42PM +0200, Christian Marangi wrote:
> On Wed, Jul 06, 2022 at 10:39:16AM +0200, Krzysztof Kozlowski wrote:
> > On 05/07/2022 15:39, Christian Marangi wrote:
> > > Add missing smem node for ipq8064.
> > > 
> > > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > > Tested-by: Jonathan McDowell <noodles@earth.li>
> > > ---
> > >  arch/arm/boot/dts/qcom-ipq8064.dtsi | 18 ++++++++++++++++++
> > >  1 file changed, 18 insertions(+)
> > > 
> > > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > > index b5aede3d7ccf..98527a7d885e 100644
> > > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > > @@ -908,6 +908,11 @@ lcc: clock-controller@28000000 {
> > >  			#reset-cells = <1>;
> > >  		};
> > >  
> > > +		sfpb_mutex_block: syscon@1200600 {
> > > +			compatible = "syscon";
> > 
> > syscon alone is not allowed.
> >
> 
> Mh... This is problematic. How this should be handled?
> This should be put in sfpb_mutex and change the driver to use regs if
> present instead of syscon?
>

Found an alternative solution used in ipq807x so I can drop the syscon
only node.

> > > +			reg = <0x01200600 0x100>;
> > > +		};
> > > +
> > >  		pcie0: pci@1b500000 {
> > >  			compatible = "qcom,pcie-ipq8064";
> > >  			reg = <0x1b500000 0x1000
> > > @@ -1332,4 +1337,17 @@ sdcc3: mmc@12180000 {
> > >  			};
> > >  		};
> > >  	};
> > > +
> > > +	sfpb_mutex: sfpb-mutex {
> > 
> > Generic node names, so hwlock
> > 
> > > +		compatible = "qcom,sfpb-mutex";
> > > +		syscon = <&sfpb_mutex_block 4 4>;
> > > +
> > > +		#hwlock-cells = <1>;
> > > +	};
> > > +
> > > +	smem {
> > > +		compatible = "qcom,smem";
> > > +		memory-region = <&smem>;
> > > +		hwlocks = <&sfpb_mutex 3>;
> > > +	};
> > >  };
> > 
> > 
> > Best regards,
> > Krzysztof
> 
> -- 
> 	Ansuel

-- 
	Ansuel