Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <47be7e87-b688-05a6-1297-8e26f5b84274@amd.com>
Date:   Wed, 6 Jul 2022 12:36:41 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v3 1/3] drm/amdgpu: fix for coding style issues
Content-Language: en-US
To:     Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
        dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org
Cc:     Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, zhuning@everest-semi.com,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20220706102851.2451164-1-Vijendar.Mukunda@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220706102851.2451164-1-Vijendar.Mukunda@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnZTUjRjbzJaQnRRci96RVNvbFprOGdsSkQxUXRUcnV3cnBSdm9sRGtOU0kz?=
 =?utf-8?B?OFdHVmFhc2xpdEJyNHhTeW5oUnJQRllNQU9KSUlJQ2hEejBjSFNvOGpacGlt?=
 =?utf-8?B?cUkwUHlBS280S0wvWENMTUJuMnFRSmZ6bG1hTGtTT0ZlYzV5WWpGd1RJTUJY?=
 =?utf-8?B?czJ3Ti9pU3RGLzAvcEVZRnRrVytiTG9xRTBOUUgxL1hFZm1qa0VPbXNqZHdq?=
 =?utf-8?B?enZVaDlWL2NKVThoMnBGWkNqS3ZVRzY0UXRLanluN0RkaVBlUzVpSW95QlVO?=
 =?utf-8?B?dGN4eUhSMDh2TUhIL2d6MG5TUXVFWTlhdlZzRVFBVUEweFpwcFdYUGliVFB2?=
 =?utf-8?B?MkQ3Z3ZyL295ZEIrQ2NzZkI1THE5YVRCczdzWEZkT2ppVXlkTC9PUmdtOXFp?=
 =?utf-8?B?ZFdNZ1Ezb3hMYjRVOFY5ZXhNRTBUbU1EZVpoRWlCWlpYV3dzNTZLRStuSG9B?=
 =?utf-8?B?OXprbWJWR3BPNnIySDh1Yjc5SHNBYjZia3FGRkpYcG4vWlBkbjFjL2NCTWFQ?=
 =?utf-8?B?bkhFekpwWGhDODdxZnR5djAxK3hjdE8yOTFsN0VQNUluWHIwVWR5akRXdWl1?=
 =?utf-8?B?UVUzazZQS0MyZFo5dnhreFhsWE1NSTRwVWZicUZtVFp5WEp3dXFjUFRmY2pn?=
 =?utf-8?B?cUlvNW5Xb3FKSHlWekl1aVlWUkIvK1N6ZzAyTDRkcXAwTTZic05MdlQyY05E?=
 =?utf-8?B?Q2JBUndyb1dCYmFLVXRyWVZvL1BiZTQzNENiWThmUjQrbVhDRjNtVUEwbFVl?=
 =?utf-8?B?WTFQSy91OERBM1ZKb2ttZUF5MTlPSkNZaDAvZGlZZWJ0ZGlvQXc4Q3B0L1Jh?=
 =?utf-8?B?SHdZVXhPQmZMaStoRnBjZE9kWTkxOFZ0ZkNScHJBUUMrdzMzZERSdDZZZ1Ru?=
 =?utf-8?B?QXhlM2ZRZjJtQnpqOXhIRk5BRFlDRjZYb2l2MDlhSGs5Ukh5LytrRngxOWpo?=
 =?utf-8?B?QUZDbFY1M3JiQ0d1alkxZGh0Q2VOcjJKWjBRa2QwcXdxeE1GWGVrKy9wUXpF?=
 =?utf-8?B?dEJUWHR2VW8zWk1Hcy9Seldxamd0ajBCNTVjOXRiUDcwVEhrY1hvdWVIaHQv?=
 =?utf-8?B?cTRtaStnOHVJcXZ4eldqRjRQOE12djIzVUxYWFUxWjVJNitqY1U3VkFsVVU5?=
 =?utf-8?B?UnpSNlRZOHc1YW56ZGhhR3E2SXlxNStxaWVaa1hIY1paVHRSazI5WGFPcEZS?=
 =?utf-8?B?TGxHT0dGdUFZNFF0TFlaZy9GbS90OW1rakExWHhTaWV6RldmR0RmQ2lwZmVm?=
 =?utf-8?B?Z1pQZjh6ZHBEM0VoMHh0L3p4YWhEY3VabHNSTlhnc0lyTjFLaUR5SlVwNGtF?=
 =?utf-8?B?elZxbVdmbCtSNmtqa2ExcXlmU2YxRzVEUFBnN3hRL1ZmNzFiSUFlR3FmeElo?=
 =?utf-8?B?S3NSdU1oOHp0VUJzd1ZLTk0zY0d2UHdMNG9MWXY1KzU4TGNaeTBUc0J6MVVM?=
 =?utf-8?B?V01JYW9EWkh6L0o2U1lRNis3Rk9YQXcrZS9HUzJLVFpBNUsybXlIb0JCZ0V6?=
 =?utf-8?B?MTBxVDhNZzJ6cWp0MElmYjhvd1EzWk5kYmZzVm1GdGs2cDZnbkwxQ0w1TkNy?=
 =?utf-8?B?QmszRHFlZGhSZS8yK01IcEVxT09Wd2I4bHJrN3hlM05JVVAvd0E1MnpVQ2E5?=
 =?utf-8?B?di93djZWSFNOSDBNR2xHSWM2NE1JeGJDWDBaK1JCdURKTmhGb0E3RjRhbjk1?=
 =?utf-8?B?VFhZRVQ2aVFMVnJQZFUyeXphSWpYM3dMWFpUVWl5Zmw3eVA2SVZ6MTI0ek9p?=
 =?utf-8?B?dFk2amxZS2psQnAySnpFVHIxV1o2bTd6WW1GRkhSYVpRRzloSjFESGtZSWgv?=
 =?utf-8?B?cHpGNmRpT0VIam9ISFNlQnQ0Rmphd1ZFNjdFdnVOS3NaTUxOWXdZTW16TTFm?=
 =?utf-8?B?dVFPZVExU1ZCNHpCeG9hcTJjU0lKQUpMSE5SYmNhRFE2ZUZUZ2xEcGk2ZTFu?=
 =?utf-8?B?c1luM0Rsa25rdTU5V0RXRUgyRkh2UVFtbzlnaEJvNkJoSjh0d1daYlVDR0wv?=
 =?utf-8?B?ZEZOeHpMczNHZ3dkNXJ4NkFRdUtUZDJmZTVGRkVTK2UzRUtaLzJjNjBIQXB6?=
 =?utf-8?B?ZjhQc0RpTWV4eDl6bEVQOWlaVVNFdW5KQUxDSGFNcHVDdkNST2haZWtSeWJn?=
 =?utf-8?B?aVFaMjZnbnlzbGJWbEhDZlFOamxNaTljaVJBclRueXFvMDEzVWEyVTMyNkxH?=
 =?utf-8?Q?LV7hs4Z8t0NxEpvScghwz+1ZfRzGluU0soan78ml/VBU?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2c696c93-8857-49ae-a222-08da5f3b6e11
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 10:36:48.1954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vvz2IljyAxAPZsX9V1sQxZ96UC3hyraSFjOl6cwZHaxBQMHgZdsn3OF72ETxz48R
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1873
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 06.07.22 um 12:28 schrieb Vijendar Mukunda:
> Fixed below checkpatch warnings and errors
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:131: CHECK: Comparison to NULL could be written "apd"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:150: CHECK: Comparison to NULL could be written "apd"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:196: CHECK: Prefer kernel type 'u64' over 'uint64_t'
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:224: CHECK: Please don't use multiple blank lines
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:226: CHECK: Comparison to NULL could be written "!adev->acp.acp_genpd"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:233: CHECK: Please don't use multiple blank lines
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:239: CHECK: Alignment should match open parenthesis
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:241: CHECK: Comparison to NULL could be written "!adev->acp.acp_cell"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:247: CHECK: Comparison to NULL could be written "!adev->acp.acp_res"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:253: CHECK: Comparison to NULL could be written "!i2s_pdata"
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:350: CHECK: Alignment should match open parenthesis
> drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:550: ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

>
> ---
> changes since v2:
>            - Removed Null check for apd structure
>            - Modified commit message
> changes since v1:
>             - Modified commit label as drm/amdgpu
>
>   drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 35 +++++++++----------------
>   1 file changed, 12 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
> index cc9c9f8b23b2..ceda19152c77 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c
> @@ -128,16 +128,14 @@ static int acp_poweroff(struct generic_pm_domain *genpd)
>   	struct amdgpu_device *adev;
>   
>   	apd = container_of(genpd, struct acp_pm_domain, gpd);
> -	if (apd != NULL) {
> -		adev = apd->adev;
> +	adev = apd->adev;
>   	/* call smu to POWER GATE ACP block
>   	 * smu will
>   	 * 1. turn off the acp clock
>   	 * 2. power off the acp tiles
>   	 * 3. check and enter ulv state
>   	 */
> -		amdgpu_dpm_set_powergating_by_smu(adev, AMD_IP_BLOCK_TYPE_ACP, true);
> -	}
> +	amdgpu_dpm_set_powergating_by_smu(adev, AMD_IP_BLOCK_TYPE_ACP, true);
>   	return 0;
>   }
>   
> @@ -147,16 +145,14 @@ static int acp_poweron(struct generic_pm_domain *genpd)
>   	struct amdgpu_device *adev;
>   
>   	apd = container_of(genpd, struct acp_pm_domain, gpd);
> -	if (apd != NULL) {
> -		adev = apd->adev;
> +	adev = apd->adev;
>   	/* call smu to UNGATE ACP block
>   	 * smu will
>   	 * 1. exit ulv
>   	 * 2. turn on acp clock
>   	 * 3. power on acp tiles
>   	 */
> -		amdgpu_dpm_set_powergating_by_smu(adev, AMD_IP_BLOCK_TYPE_ACP, false);
> -	}
> +	amdgpu_dpm_set_powergating_by_smu(adev, AMD_IP_BLOCK_TYPE_ACP, false);
>   	return 0;
>   }
>   
> @@ -193,7 +189,7 @@ static int acp_genpd_remove_device(struct device *dev, void *data)
>   static int acp_hw_init(void *handle)
>   {
>   	int r;
> -	uint64_t acp_base;
> +	u64 acp_base;
>   	u32 val = 0;
>   	u32 count = 0;
>   	struct i2s_platform_data *i2s_pdata = NULL;
> @@ -220,37 +216,32 @@ static int acp_hw_init(void *handle)
>   		return -EINVAL;
>   
>   	acp_base = adev->rmmio_base;
> -
> -
>   	adev->acp.acp_genpd = kzalloc(sizeof(struct acp_pm_domain), GFP_KERNEL);
> -	if (adev->acp.acp_genpd == NULL)
> +	if (!adev->acp.acp_genpd)
>   		return -ENOMEM;
>   
>   	adev->acp.acp_genpd->gpd.name = "ACP_AUDIO";
>   	adev->acp.acp_genpd->gpd.power_off = acp_poweroff;
>   	adev->acp.acp_genpd->gpd.power_on = acp_poweron;
> -
> -
>   	adev->acp.acp_genpd->adev = adev;
>   
>   	pm_genpd_init(&adev->acp.acp_genpd->gpd, NULL, false);
>   
> -	adev->acp.acp_cell = kcalloc(ACP_DEVS, sizeof(struct mfd_cell),
> -							GFP_KERNEL);
> +	adev->acp.acp_cell = kcalloc(ACP_DEVS, sizeof(struct mfd_cell), GFP_KERNEL);
>   
> -	if (adev->acp.acp_cell == NULL) {
> +	if (!adev->acp.acp_cell) {
>   		r = -ENOMEM;
>   		goto failure;
>   	}
>   
>   	adev->acp.acp_res = kcalloc(5, sizeof(struct resource), GFP_KERNEL);
> -	if (adev->acp.acp_res == NULL) {
> +	if (!adev->acp.acp_res) {
>   		r = -ENOMEM;
>   		goto failure;
>   	}
>   
>   	i2s_pdata = kcalloc(3, sizeof(struct i2s_platform_data), GFP_KERNEL);
> -	if (i2s_pdata == NULL) {
> +	if (!i2s_pdata) {
>   		r = -ENOMEM;
>   		goto failure;
>   	}
> @@ -346,8 +337,7 @@ static int acp_hw_init(void *handle)
>   	adev->acp.acp_cell[3].platform_data = &i2s_pdata[2];
>   	adev->acp.acp_cell[3].pdata_size = sizeof(struct i2s_platform_data);
>   
> -	r = mfd_add_hotplug_devices(adev->acp.parent, adev->acp.acp_cell,
> -								ACP_DEVS);
> +	r = mfd_add_hotplug_devices(adev->acp.parent, adev->acp.acp_cell, ACP_DEVS);
>   	if (r)
>   		goto failure;
>   
> @@ -546,8 +536,7 @@ static const struct amd_ip_funcs acp_ip_funcs = {
>   	.set_powergating_state = acp_set_powergating_state,
>   };
>   
> -const struct amdgpu_ip_block_version acp_ip_block =
> -{
> +const struct amdgpu_ip_block_version acp_ip_block = {
>   	.type = AMD_IP_BLOCK_TYPE_ACP,
>   	.major = 2,
>   	.minor = 2,