Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220706013222.5323-1-zeming@nfschina.com>
In-Reply-To: <20220706013222.5323-1-zeming@nfschina.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Wed, 6 Jul 2022 12:31:36 +0200
Message-ID: <CAJZ5v0i4vuH7V-8UUESTOaC5MKuKycLUeC+MsR-Mwq-KE8-d9w@mail.gmail.com>
Subject: Re: [PATCH] acpi/sbshc: Add header file macro definition
To:     Li zeming <zeming@nfschina.com>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kernel@nfschina.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jul 6, 2022 at 3:34 AM Li zeming <zeming@nfschina.com> wrote:
>
> Add header file macro definition.

Please explain why you want to make this change.

> Signed-off-by: Li zeming <zeming@nfschina.com>
> ---
>  drivers/acpi/sbshc.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/acpi/sbshc.h b/drivers/acpi/sbshc.h
> index 695c390e2884..22b11a1655d2 100644
> --- a/drivers/acpi/sbshc.h
> +++ b/drivers/acpi/sbshc.h
> @@ -1,4 +1,7 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _SBSHC_H
> +#define _SBSHC_H
> +
>  struct acpi_smb_hc;
>  enum acpi_smb_protocol {
>         SMBUS_WRITE_QUICK = 2,
> @@ -30,3 +33,4 @@ extern int acpi_smbus_write(struct acpi_smb_hc *hc, u8 protocol, u8 slave_addres
>  extern int acpi_smbus_register_callback(struct acpi_smb_hc *hc,
>                 smbus_alarm_callback callback, void *context);
>  extern int acpi_smbus_unregister_callback(struct acpi_smb_hc *hc);
> +#endif
> --
> 2.18.2
>