Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp2355074imw; Wed, 6 Jul 2022 04:42:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tRNAEDMBn9la25C9vbY2pAZcjNFv6jZWbC1u6c+ZwJ0PvTu3UIOkqXNQ96TrlzPmG9Mzns X-Received: by 2002:a17:90a:8044:b0:1ef:7a95:9910 with SMTP id e4-20020a17090a804400b001ef7a959910mr26772379pjw.165.1657107746852; Wed, 06 Jul 2022 04:42:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657107746; cv=none; d=google.com; s=arc-20160816; b=LGqTr9Uy21yc9GGIAkp/r31h3Ljki3ePOcz5W1Xuc+sqY+OzS9UNe25yKy4M/ePcC9 Vk7cQHo416WBLZ/OXKZsdaGzthqNjGaAxlILtXLhlIF+S74mjgsM1dtr3Gfsg5OMAexc /PhIOpdRLjolYR0JE/e7TKQFg1R88uvS5wiXiuWJwQguKQyKcdEez03wMHmvvgYnaa47 kaCsPetWwDFqFk4TRk6d9LjS/BDXSlfKhH9GFCd6W5mu/r1/YvS3QtX36cANRPo1xpXK xyb8UIwxQK7AcszSFQ29i1QgX7PGCtrC+gxpNT7RRJZ1eAoQPAFR+FfoF4N7XoycZF5h DCZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=wgFoZK7zWHvKMSVlkG5wG+pHfOg8A37FdaiX3b0w3RE=; b=F0AybnUcbYlpMjVhguMY9PEnunirKjBOXSZVnIh00K/sEpZq891m+g8DlhrFnor2rQ tM+Fw9JPREGdfwyUYndosTH6HNbcZ+oQKeRY/4zP5LZfCBdGRP4qEqXTi2T3m93dXwxJ kQov9z1ctZ6rI7MxdYOKZ9CVK5n77SoNKV/x0VplM/CfnncLJ/YPf5nVLmwaORA6yIUP swLv++aqhzDHpiMjOvRJidCtHKeIUeKCS08h7fzVMMzqKSWxm++s4vO8wV8ZxIQOcZus SCPUOvK3uFZLko3b25eHtb5k/x/PWv2NmlNAogkM4EKkKEC4xeBx2iSu9cmkHlqhnlEd DB1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id me6-20020a17090b17c600b001ec79814550si17994982pjb.12.2022.07.06.04.42.14; Wed, 06 Jul 2022 04:42:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231508AbiGFLik (ORCPT + 99 others); Wed, 6 Jul 2022 07:38:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbiGFLij (ORCPT ); Wed, 6 Jul 2022 07:38:39 -0400 Received: from theia.8bytes.org (8bytes.org [81.169.241.247]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBB5114024 for ; Wed, 6 Jul 2022 04:38:38 -0700 (PDT) Received: by theia.8bytes.org (Postfix, from userid 1000) id 4018F4CC; Wed, 6 Jul 2022 13:38:37 +0200 (CEST) Date: Wed, 6 Jul 2022 13:38:36 +0200 From: Joerg Roedel To: Bo Liu Cc: will@kernel.org, suravee.suthikulpanit@amd.com, iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/amd: Handle return of iommu_device_sysfs_add Message-ID: References: <20220701062008.6988-1-liubo03@inspur.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701062008.6988-1-liubo03@inspur.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 01, 2022 at 02:20:08AM -0400, Bo Liu wrote: > As iommu_device_sysfs_add() can fail, we should check the return value. > > Signed-off-by: Bo Liu > --- > drivers/iommu/amd/init.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Applied, thanks.