Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp2386446imw; Wed, 6 Jul 2022 05:12:34 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sqoXs5fyl8b97km2NJ+yhqjlXXStThq/rVRu9QnruY0o97SQyEAVmAP2e2RsFyaeO53NKp X-Received: by 2002:a17:907:868c:b0:72a:facd:c062 with SMTP id qa12-20020a170907868c00b0072afacdc062mr2588411ejc.727.1657109554593; Wed, 06 Jul 2022 05:12:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657109554; cv=none; d=google.com; s=arc-20160816; b=tApuUItw7xix7Qp5h40Vl6kDP97PcyPC7ii/MG7a2McRgg3SuVoNz+Crq0wRMEO9Mn xGPZmQiTSkOy7BPBDfeB3cAYfqs/rXN77CJ0PysUZqxvB5Q8v6tbnb9SRET9iGQaW/l2 SFYtssaGuyIk6DJRGHmdhpmvNAd33PaVQblbs6DSDkV+DZ88KfSsmDhQJE3Jms5hgA9X 0G72b0NZaOjNx3lJ264WIIPMfxNLlVk6vwQJ9I/2WLHQluasijMd1w3GgnAg+clCAA0N u0wDh0EmThuylF2oOuBOK0Uj18ye7jnDWi0jhWdiivqblCIH3S3JhkGbHwwjdB3H9OHj DZ2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:subject:user-agent:mime-version:date:message-id; bh=yYb9T/wg4W2nu9rnDWwxyUPWQt9dNavr3HLwx60GlO0=; b=WfVfl8sJwKRikvoI91WZ63b3h2yVMt9spAd9EJIEAdfSDFQ/Ei/u1162x5XJQ0/36+ 1PHe6jY3JLj6MFNUnn2Jk/2mHDxAD6jaLYw745Qa9BHG/aZqrsiZIHX2nZoH0/hYh+48 AHsGms2ndH5ahTEntwBKEwbDsC9CaQr3KeyA46bLey/Jyn2Us6qdTogbqcQzxnCgjE8X PY6D1+A4XlVe0ki4exsduzbVCHFbDsnkBR21iuY22XlVIY8UsMll6rQTmWahFrbyg8N3 HcngHjKx8p737hW9uPqnCD+r+eogub6sMFemhI8WvbfjJRqEz7N+uP7k7Mebn4LLS2/V suHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hj1-20020a1709069fc100b0072a4bc2162asi14635206ejc.272.2022.07.06.05.12.08; Wed, 06 Jul 2022 05:12:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232508AbiGFMDw (ORCPT + 99 others); Wed, 6 Jul 2022 08:03:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231713AbiGFMDu (ORCPT ); Wed, 6 Jul 2022 08:03:50 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 473166584 for ; Wed, 6 Jul 2022 05:03:48 -0700 (PDT) Received: from fraeml701-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4LdJ673vf3z6H7lp; Wed, 6 Jul 2022 20:01:03 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml701-chm.china.huawei.com (10.206.15.50) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2375.24; Wed, 6 Jul 2022 14:03:45 +0200 Received: from [10.126.171.66] (10.126.171.66) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 6 Jul 2022 13:03:44 +0100 Message-ID: <5ab934ff-0b16-0b55-e0f1-36366cd33e84@huawei.com> Date: Wed, 6 Jul 2022 13:03:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH RESEND v5 1/5] iommu: Refactor iommu_group_store_type() To: Will Deacon CC: , , , , , , , , , , References: <1649071634-188535-1-git-send-email-john.garry@huawei.com> <1649071634-188535-2-git-send-email-john.garry@huawei.com> <20220706120059.GE2403@willie-the-truck> From: John Garry In-Reply-To: <20220706120059.GE2403@willie-the-truck> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.126.171.66] X-ClientProxiedBy: lhreml732-chm.china.huawei.com (10.201.108.83) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/07/2022 13:00, Will Deacon wrote: > On Mon, Apr 04, 2022 at 07:27:10PM +0800, John Garry wrote: >> Function iommu_group_store_type() supports changing the default domain >> of an IOMMU group. >> >> Many conditions need to be satisfied and steps taken for this action to be >> successful. >> >> Satisfying these conditions and steps will be required for setting other >> IOMMU group attributes, so factor into a common part and a part specific >> to update the IOMMU group attribute. >> >> No functional change intended. >> >> Some code comments are tidied up also. >> >> Signed-off-by: John Garry >> --- >> drivers/iommu/iommu.c | 96 ++++++++++++++++++++++++++++--------------- >> 1 file changed, 62 insertions(+), 34 deletions(-) > Acked-by: Will Deacon > Thanks, but currently I have no plans to progress this series, in favour of this https://lore.kernel.org/linux-iommu/1656590892-42307-1-git-send-email-john.garry@huawei.com/T/#me0e806913050c95f6e6ba2c7f7d96d51ce191204 cheers