Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220705171835.4923-1-brgl@bgdev.pl>
In-Reply-To: <20220705171835.4923-1-brgl@bgdev.pl>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 6 Jul 2022 13:48:26 +0200
Message-ID: <CAHp75Ve3sPhFOZhL=_2p+1avuo96CP995KD+bi+Pn3gyj1F9TA@mail.gmail.com>
Subject: Re: [PATCH] gpio: pxa: schedule a devm action for the clock struct
To:     Bartosz Golaszewski <brgl@bgdev.pl>,
        Stephen Boyd <swboyd@chromium.org>
Cc:     Robert Jarzmik <robert.jarzmik@free.fr>,
        Linus Walleij <linus.walleij@linaro.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Hulk Robot <hulkci@huawei.com>,
        "Signed-off-by : Yuan Can" <yuancan@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 5, 2022 at 7:29 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
> The clock is never released after probe(). Schedule devm actions for
> putting and disabling the clock.

...

> Reported-by: Signed-off-by: Yuan Can <yuancan@huawei.com>

Me puzzled.


...

> +       ret = devm_add_action_or_reset(&pdev->dev, pxa_gpio_clk_put, clk);
> +       if (ret)
> +               return ret;
> +
>         ret = clk_prepare_enable(clk);
> +       if (ret)
> +               return ret;
> +
> +       ret = devm_add_action_or_reset(&pdev->dev,
> +                                      pxa_gpio_clk_disable_unprepare, clk);
> +       if (ret)
>                 return ret;

Can we use recently introduced clk APIs for that? Maybe Stephen has an
immutable branch you may reuse?

-- 
With Best Regards,
Andy Shevchenko