Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Alan Maguire <alan.maguire@oracle.com>
To:     ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net
Cc:     kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org, jolsa@kernel.org,
        mhiramat@kernel.org, akpm@linux-foundation.org, void@manifault.com,
        swboyd@chromium.org, ndesaulniers@google.com,
        9erthalion6@gmail.com, kennyyu@fb.com, geliang.tang@suse.com,
        kuniyu@amazon.co.jp, bpf@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH v4 bpf-next 0/2] bpf: add a ksym BPF iterator
Date:   Wed,  6 Jul 2022 14:16:29 +0100
Message-Id: <1657113391-5624-1-git-send-email-alan.maguire@oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RaDKAMyrqm+qwfNHqRlBHpPcERLSt21DfVK7i635Br4cIzr3hv8UIcnkn09g?=
 =?us-ascii?Q?QhLyDltTVgwz6auVDRYENIUaRnq1ABGjYl4mo3JrE2OokLTi3QDQcqiAW2Gn?=
 =?us-ascii?Q?qWU8iQKYrHqBq2EehZUuMOVolcWLD/68UcGARiI49Ks1iAD+oe0mNBkmhvVR?=
 =?us-ascii?Q?Zx3Z9/jhQgxkOR9BWyb9L8QJjDaC2aG7lOVqnCpPRzsT89HHzoKFoN7c1uXl?=
 =?us-ascii?Q?7mKF5HA+rpKZSo9D1TDJMIrf6RZlHYyUBPH9tzFmoZ1l3zzkvyCN8tzTkQgi?=
 =?us-ascii?Q?CrWHX/Q9j8EskVCdzHv68mIfbbOhITu44c+BcD0FXK2Pxse7qnHWc4Okx5jc?=
 =?us-ascii?Q?udFxE5mObEGuq39JHZf2lEqsfCJ7+IDcNEBf2XwXrOiSGXwkuVutJUFcUOps?=
 =?us-ascii?Q?HMcd7JXhgpGSAYqzJzO2UyzoJ6rAI/Xu+wWBdGEdBbnfshTM8StYlx+5b9Fz?=
 =?us-ascii?Q?GAgmXgky9/ZNWC4J3B28HAiXtJy3GxhOIVijICrU71I5deXSr44aUCh8Talp?=
 =?us-ascii?Q?M5K6x3v038qEC4FeYyvEmH9m/JgrCALUGv1E6F81LyYEjQuSoNJR9cIW7HnD?=
 =?us-ascii?Q?JjGSU4AieMfG6YYfi25rF5VsAxD7TZ+4vZ92V7ZOVM6Rs6XseKaSQM+amJvx?=
 =?us-ascii?Q?tIwYGnZ1IuiTdJO+62WgmgA80GHT0B1SCfR7/7o+ZexT06n31aRItEJ0yVZI?=
 =?us-ascii?Q?zOwP21uvl6sO4qQcxrcAIow2g21TVcWyL8Gvwv0D+YK3t3SBN8XZjmpENg4c?=
 =?us-ascii?Q?6+Xbg2ysW4DBC5IL7CJaL++q6hF32+g/nryi0DwcR/eGRtn3DX+MPLUjIivU?=
 =?us-ascii?Q?KuIRhjqiE0Idj58L74pLdWz5gcZUwVwxnEY0OXkmxwf3kQ7p7iwA6zfku+Zc?=
 =?us-ascii?Q?EBJ0klbDKPgoCcKmS/k7EAITFFWsHyO3vLIQNFP4GqkBYsVNNJP5L4r+IYfy?=
 =?us-ascii?Q?+mdR5YCTyMOFSeTyszA4ESKqPtMsx4XOgiVAdTFtfH0C8kiS8WiCqdyuf6Z/?=
 =?us-ascii?Q?ibFJ+xPWcvoWnZbCFRV3W/B8W3xWYLiDyYWP+L9XJD8ZL6GrXCWOF9P6V5yp?=
 =?us-ascii?Q?4XVK4KQCjLNpBnI2m1pyaMaszoMPr4UHi318RR24lZaPUMEZJyh4Oa7UpfSg?=
 =?us-ascii?Q?z8Q4Z2Fd0JloxqpBrZPiN1BNHvWYeHWnejbegvTJVFQ//Ih0qgyCYku6d4vj?=
 =?us-ascii?Q?Ee2B+fxLrUc2fCV4J/kAXwuKUXxwZgtIKESuk+8TPTLe2vEfwK9FzD+9tNqD?=
 =?us-ascii?Q?IIpZyPV+af7CziSKevIouv3FBD7Qx1lKjC3vgxU8HiyzJqZvQxzuBqthkdcq?=
 =?us-ascii?Q?sfZUXOjVrOuYLtW7WElOU/MsewtB2Rr95rc5/BBGeZPbvAWFLDDZZcomQ4pS?=
 =?us-ascii?Q?oUtCwoT+AXjAGa6fuV7+UcwrIkjDXM9UCWYhZgV/aMbAJGopF4fhuEYb+0X2?=
 =?us-ascii?Q?/VFjWWqCMC63DpqwQxRxinZwB7jKkYQEr6QfpoDlIisDHh8tMWVSPFrCUKCp?=
 =?us-ascii?Q?PRNG1/XRUwukdeggw6nAtLRivwR2LlfYF8QN52/qaR9GWEuSJ258bnbgvT1e?=
 =?us-ascii?Q?r0FLsHVoaomq3cbtGyHPltO6T8aOC6Cb6bfLEQfZ?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe8bfb84-47d3-4ee0-35af-08da5f51c17f
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5267.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 13:16:37.2487
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ldI6HV/+UspNUDiLVZajxvqIC8VoDCW3nirKNdZPgTb403fiRwZOyyVtCZpRtyFLQP2ngn4Kcd1f7ZMJ98BMKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2163
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-06_08:2022-06-28,2022-07-06 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 phishscore=0
 adultscore=0 malwarescore=0 mlxscore=0 spamscore=0 mlxlogscore=904
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207060052
X-Proofpoint-ORIG-GUID: xdK5r0cwZKZ5XTiGcDX3plfjn3NejOkx
X-Proofpoint-GUID: xdK5r0cwZKZ5XTiGcDX3plfjn3NejOkx
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

a ksym BPF iterator would be useful as it would allow more flexible
interactions with kernel symbols than are currently supported; it could
for example create more efficient map representations for lookup,
speed up symbol resolution etc.

The idea was initially discussed here [1].

Changes since v3 [2]:

- use late_initcall() to register iter; means we are both consistent
  with other iters and can encapsulate all iter-specific code in
  kallsyms.c in CONFIG_BPF_SYSCALL (Alexei, Yonghong, patch 1).

Changes since v2 [3]:

- set iter->show_value on initialization based on current creds
  and use it in selftest to determine if we show values
  (Yonghong, patches 1/2)
- inline iter registration into kallsyms_init (Yonghong, patch 1)

Changes since RFC [4]:

- change name of iterator (and associated structures/fields) to "ksym"
  (Andrii, patches 1, 2)
- remove dependency on CONFIG_PROC_FS; it was used for other BPF
  iterators, and I assumed it was needed because of seq ops but I
  don't think it is required on digging futher (Andrii, patch 1)

[1] https://lore.kernel.org/all/YjRPZj6Z8vuLeEZo@krava/
[2] https://lore.kernel.org/bpf/1656942916-13491-1-git-send-email-alan.maguire@oracle.com
[3] https://lore.kernel.org/bpf/1656667620-18718-1-git-send-email-alan.maguire@oracle.com/
[4] https://lore.kernel.org/all/1656089118-577-1-git-send-email-alan.maguire@oracle.com/

Alan Maguire (2):
  bpf: add a ksym BPF iterator
  selftests/bpf: add a ksym iter subtest

 kernel/kallsyms.c                                 | 95 +++++++++++++++++++++++
 tools/testing/selftests/bpf/prog_tests/bpf_iter.c | 16 ++++
 tools/testing/selftests/bpf/progs/bpf_iter_ksym.c | 74 ++++++++++++++++++
 3 files changed, 185 insertions(+)
 create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_ksym.c

-- 
1.8.3.1