Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62c58a60.1c69fb81.25b26.e72a@mx.google.com>
Date:   Wed, 6 Jul 2022 14:56:27 +0200
From:   Christian Marangi <ansuelsmth@gmail.com>
To:     Konrad Dybcio <konrad.dybcio@somainline.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jonathan McDowell <noodles@earth.li>
Subject: Re: [PATCH 04/13] ARM: dts: qcom: disable smb208 regulators for
 ipq8064-rb3011
References: <20220705133917.8405-1-ansuelsmth@gmail.com>
 <20220705133917.8405-5-ansuelsmth@gmail.com>
 <8a394fa3-92fb-d162-b4ee-df010a09aed0@somainline.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8a394fa3-92fb-d162-b4ee-df010a09aed0@somainline.org>
Precedence: bulk

On Wed, Jul 06, 2022 at 03:03:32PM +0200, Konrad Dybcio wrote:
> 
> 
> On 5.07.2022 15:39, Christian Marangi wrote:
> > Mikrotik RB3011 have a special configuration where the regulators are
> > not the common smb208 controlled by RPM but they use a TPS563900
> > controlled via i2c. Disable the smb208 for this specific device.
> Ok, so that answers my question from the previous email.
> Please define the SMB208 regulators only in the DTs of
> boards that actually use it, as it is not a SoC component as
> far as I can tell.
> 
> Konrad

This was already discuessed, rb3011 is the exception, qcom for ipq8064
recommends to use smb208 but gives the option to implement it in their
own way. So again we have 28 device with smb208 and 1 device that use
its own special way...

Wonder if a separate dtsi can be used for this if we really can't put
smb208 in ipq8064 dtsi?

> > 
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > Reviewed-by: Jonathan McDowell <noodles@earth.li>
> > Tested-by: Jonathan McDowell <noodles@earth.li>
> > ---
> >  arch/arm/boot/dts/qcom-ipq8064-rb3011.dts | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> > index 9034f00f2bd8..f651e813d75a 100644
> > --- a/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> > +++ b/arch/arm/boot/dts/qcom-ipq8064-rb3011.dts
> > @@ -218,6 +218,10 @@ led@7 {
> >  	};
> >  };
> >  
> > +&smb208_regulators {
> > +	status = "disabled";
> > +};
> > +
> >  &adm_dma {
> >  	status = "okay";
> >  };

-- 
	Ansuel