Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62c59118.1c69fb81.9c3f3.ac43@mx.google.com>
Date:   Wed, 6 Jul 2022 15:25:07 +0200
From:   Christian Marangi <ansuelsmth@gmail.com>
To:     Konrad Dybcio <konrad.dybcio@somainline.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, Jonathan McDowell <noodles@earth.li>
Subject: Re: [PATCH 04/13] ARM: dts: qcom: disable smb208 regulators for
 ipq8064-rb3011
References: <20220705133917.8405-1-ansuelsmth@gmail.com>
 <20220705133917.8405-5-ansuelsmth@gmail.com>
 <8a394fa3-92fb-d162-b4ee-df010a09aed0@somainline.org>
 <62c58a60.1c69fb81.25b26.e72a@mx.google.com>
 <36a68a0b-0c18-deb5-609c-2128aa3fc21f@somainline.org>
 <62c58fca.1c69fb81.76f6a.15f4@mx.google.com>
 <43572937-8505-ddf0-1fe0-99ddfe486c11@somainline.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <43572937-8505-ddf0-1fe0-99ddfe486c11@somainline.org>
Precedence: bulk

On Wed, Jul 06, 2022 at 03:37:36PM +0200, Konrad Dybcio wrote:
> 
> 
> On 6.07.2022 15:19, Christian Marangi wrote:
> > On Wed, Jul 06, 2022 at 03:31:55PM +0200, Konrad Dybcio wrote:
> >>
> >>
> >> On 6.07.2022 14:56, Christian Marangi wrote:
> >>> On Wed, Jul 06, 2022 at 03:03:32PM +0200, Konrad Dybcio wrote:
> >>>>
> >>>>
> >>>> On 5.07.2022 15:39, Christian Marangi wrote:
> >>>>> Mikrotik RB3011 have a special configuration where the regulators are
> >>>>> not the common smb208 controlled by RPM but they use a TPS563900
> >>>>> controlled via i2c. Disable the smb208 for this specific device.
> >>>> Ok, so that answers my question from the previous email.
> >>>> Please define the SMB208 regulators only in the DTs of
> >>>> boards that actually use it, as it is not a SoC component as
> >>>> far as I can tell.
> >>>>
> >>>> Konrad
> >>>
> >>> This was already discuessed,
> >> Yeah sorry, I didn't notice earlier and started reviewing patches
> >> that were already reviewed by others.
> >>
> > 
> > Np, thanks for the review.
> > 
> >>
> >> rb3011 is the exception, qcom for ipq8064
> >>> recommends to use smb208 but gives the option to implement it in their
> >>> own way. So again we have 28 device with smb208 and 1 device that use
> >>> its own special way...
> >>>
> >>> Wonder if a separate dtsi can be used for this if we really can't put
> >>> smb208 in ipq8064 dtsi?
> >> There's msm8916-pm8916.dtsi. You can follow.
> > 
> > Ok, will put the smb208 definition to a separate dtsi, something like
> > ipq8064-smb208.dtsi? or ipq8064-rpm-smb208.dtsi? Looks also cleaner that
> > way.
> You can create ipq8064-smb208.dtsi that will also contain every ipq8064-plus-smb208-specific
> configuration, such as regulator assignemnts to in-SoC components (like PHYs, SDHCIs etc.).

Just for reference there regulators are used only for cpu voltage, l2
cache and special ubi32 cores that are not supported currently, nothing
more.

>
> Konrad
> > 
> >>
> >> Konrad
> >>
> >> [...]
> > 

-- 
	Ansuel