Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753430AbXE3Il6 (ORCPT ); Wed, 30 May 2007 04:41:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751362AbXE3Ilu (ORCPT ); Wed, 30 May 2007 04:41:50 -0400 Received: from pythagoras.zen.co.uk ([212.23.3.140]:48295 "EHLO pythagoras.zen.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751310AbXE3Ilt (ORCPT ); Wed, 30 May 2007 04:41:49 -0400 Message-ID: <465D38CA.5050805@gmail.com> Date: Wed, 30 May 2007 09:41:46 +0100 From: Matt Keenan User-Agent: Thunderbird 1.5.0.10 (X11/20070403) MIME-Version: 1.0 To: Linus Torvalds CC: Robert Hancock , linux-kernel , Andrew Morton , Jesse Barnes Subject: Re: [PATCH -mm] 1/2: MMCONFIG: validate against ACPI motherboard resources References: <465CF794.1070406@shaw.ca> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Originating-Pythagoras-IP: [82.69.27.224] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1646 Lines: 45 Linus Torvalds wrote: > On Tue, 29 May 2007, Robert Hancock wrote: > >> This path adds validation of the MMCONFIG table against the ACPI reserved >> motherboard resources. >> > > Please fix the formatting of your code. > > [snip snip] > Same goes for this thing: > > + if((pci_probe & PCI_PROBE_CONF1) && > + e820_all_mapped(cfg->address, > + cfg->address + size - 1, > + E820_RESERVED)) > + printk(KERN_NOTICE "PCI: MCFG area at %Lx reserved in E820\n", > + cfg->address); > + else > + goto reject; > > there really is *not* a highly coveted prize for having the most different > indentation in the fewest possible lines of code! > > That looks like standard lisp style indenting (yes I realise that C != lisp). At a guess I would say that code was written in emacs (which can be fixed by the necessary changes in your ~/.emacs). Grand parent post should check out these resources, they may help... http://www.bloomington.in.us/~brutt/emacs-c-dev.html http://lug.umbc.edu/tutorials/adv-emacs.html or if you are really gung ho the CC-mode documentation http://www.chemie.fu-berlin.de/chemnet/use/info/cc-mode/cc-mode_6.html Matt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/