Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1c4bc0cf-6665-3fe6-28d8-8e9613e3f9d4@linux.microsoft.com>
Date:   Wed, 6 Jul 2022 19:59:09 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] scsi: storvsc: Prevent running tasklet for long
Content-Language: en-US
To:     Saurabh Singh Sengar <ssengar@linux.microsoft.com>
Cc:     kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com,
        wei.liu@kernel.org, decui@microsoft.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, linux-hyperv@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        ssengar@microsoft.com, mikelley@microsoft.com
References: <1657035141-2132-1-git-send-email-ssengar@linux.microsoft.com>
 <b4fea161-41c5-a03e-747b-316c74eb986c@linux.microsoft.com>
 <20220706095358.GA3320@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
From:   Praveen Kumar <kumarpraveen@linux.microsoft.com>
In-Reply-To: <20220706095358.GA3320@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06-07-2022 15:23, Saurabh Singh Sengar wrote:
> On Wed, Jul 06, 2022 at 02:44:42PM +0530, Praveen Kumar wrote:
>> On 05-07-2022 21:02, Saurabh Sengar wrote:
>>> There can be scenarios where packets in ring buffer are continuously
>>> getting queued from upper layer and dequeued from storvsc interrupt
>>> handler, such scenarios can hold the foreach_vmbus_pkt loop (which is
>>> executing as a tasklet) for a long duration. Theoretically its possible
>>> that this loop executes forever. Add a condition to limit execution of
>>> this tasklet for finite amount of time to avoid such hazardous scenarios.
>>>
>>> Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
>>> ---
>>>  drivers/scsi/storvsc_drv.c | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
>>> index fe000da..0c428cb 100644
>>> --- a/drivers/scsi/storvsc_drv.c
>>> +++ b/drivers/scsi/storvsc_drv.c
>>> @@ -60,6 +60,9 @@
>>>  #define VMSTOR_PROTO_VERSION_WIN8_1	VMSTOR_PROTO_VERSION(6, 0)
>>>  #define VMSTOR_PROTO_VERSION_WIN10	VMSTOR_PROTO_VERSION(6, 2)
>>>  
>>> +/* channel callback timeout in ms */
>>> +#define CALLBACK_TIMEOUT		5
>>
>> If I may, it would be good if we have the CALLBACK_TIMEOUT configurable based upon user's requirement with default value to '5'.
>> I assume, this value '5' fits best to the use-case which we are trying to resolve here. Thanks.
> 
> Agree, how about adding a sysfs entry for this parameter
> 

Sounds good to me. Thanks.

Regards,

~Praveen.