Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220630071013.1710594-1-o.rempel@pengutronix.de>
In-Reply-To: <20220630071013.1710594-1-o.rempel@pengutronix.de>
From:   Vladimir Oltean <olteanv@gmail.com>
Date:   Wed, 6 Jul 2022 17:43:59 +0300
Message-ID: <CA+h21hrTxNM93M34iusYAO+L=37o-BJ33o7UXW0rwyKk2EOoKw@mail.gmail.com>
Subject: Re: [PATCH net-next v1 1/1] net: dsa: sja1105: silent spi_device_id warnings
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Andrew Lunn <andrew@lunn.ch>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Oleksij,

On Thu, 30 Jun 2022 at 10:10, Oleksij Rempel <o.rempel@pengutronix.de> wrote:
> Add spi_device_id entries to silent following warnings:
>  SPI driver sja1105 has no spi_device_id for nxp,sja1105e
>  SPI driver sja1105 has no spi_device_id for nxp,sja1105t
>  SPI driver sja1105 has no spi_device_id for nxp,sja1105p
>  SPI driver sja1105 has no spi_device_id for nxp,sja1105q
>  SPI driver sja1105 has no spi_device_id for nxp,sja1105r
>  SPI driver sja1105 has no spi_device_id for nxp,sja1105s
>  SPI driver sja1105 has no spi_device_id for nxp,sja1110a
>  SPI driver sja1105 has no spi_device_id for nxp,sja1110b
>  SPI driver sja1105 has no spi_device_id for nxp,sja1110c
>  SPI driver sja1105 has no spi_device_id for nxp,sja1110d
>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---

This was marked as "Changes Requested" in patchwork. Could you please
slap a Fixes: tag onto it and resend to net?
Also, would you mind applying the same treatment to
vitesse-vsc73xx-spi.c so that we get rid of the warnings for all DSA
drivers?
You can blame the spi.c commit that introduced the warning.

Thanks!