Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 15:59:56 +0100
From:   Mark Brown <broonie@kernel.org>
To:     "Srikandan, Nandhini" <nandhini.srikandan@intel.com>
Cc:     "fancer.lancer@gmail.com" <fancer.lancer@gmail.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "mgross@linux.intel.com" <mgross@linux.intel.com>,
        "Pan, Kris" <kris.pan@intel.com>,
        "Demakkanavar, Kenchappa" <kenchappa.demakkanavar@intel.com>,
        "Zhou, Furong" <furong.zhou@intel.com>,
        "Sangannavar, Mallikarjunappa" 
        <mallikarjunappa.sangannavar@intel.com>,
        "Vaidya, Mahesh R" <mahesh.r.vaidya@intel.com>,
        "A, Rashmi" <rashmi.a@intel.com>
Subject: Re: [PATCH v5 1/4] spi: dw: Fix IP-core versions macro
Message-ID: <YsWjbPKsXJ1c5XAv@sirena.org.uk>
References: <20220706042039.5763-1-nandhini.srikandan@intel.com>
 <20220706042039.5763-2-nandhini.srikandan@intel.com>
 <YsV4yU42in8qqQrw@sirena.org.uk>
 <SJ0PR11MB5816A2F6C1F517E2E332778885809@SJ0PR11MB5816.namprd11.prod.outlook.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="b9zIUXi3ZquH2FrJ"
Content-Disposition: inline
In-Reply-To: <SJ0PR11MB5816A2F6C1F517E2E332778885809@SJ0PR11MB5816.namprd11.prod.outlook.com>
Precedence: bulk


--b9zIUXi3ZquH2FrJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jul 06, 2022 at 02:56:30PM +0000, Srikandan, Nandhini wrote:

> > wrote:
> > > From: Nandhini Srikandan <nandhini.srikandan@intel.com>
> > >
> > > Fixes: 2cc8d9227bbb ("spi: dw: Introduce Synopsys IP-core versions
> > interface")
> > > Signed-off-by: Nandhini Srikandan <nandhini.srikandan@intel.com>

> > What is the problem and how does this patch fix it?

> The macro was introduced by Serge Semin in the patch set (2cc8d9227bbb) b=
ut it was unused.
> It is used by one of the patches in the current patchset and without the =
fix it leads to compilation error. I had included this in v4 and Serge Semi=
n had asked me to add the "Fixes: 2cc8d9227bbb" tag and keep it at the top =
of the series. So, I have kept it as first patch in this patchset series.=
=20

This is information that ought to be in the changelog.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

--b9zIUXi3ZquH2FrJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmLFo2sACgkQJNaLcl1U
h9D2bQf8DuxNzwllw5VZK9szYInYDDLmW17HvwgCa9gGQMuP3DmOjytIxlYEaDK0
gdtnIFda84uJ6c6Cx3TkJoWO0JcSbWCAY/DUCFfh6RJrPqO+Qnjrkom5/rBgD8Pz
mdM0IQYHGKRflT+p4LNaw8HkpDU2YQg89GzhCYAhQRIn/HoLGlAs8u6W0ry5wVJe
sBpRgnoTlt4X+f/Z1tMGZlmdPpu+81wzKkZzQAYx+R3cqqlxorfXstTmxQ76o/sj
BznKJa25OUdegYJQRJUqwHhf7T7hHzFtHfWF84NsIXYs/ZOuUuqBHV1tn9MHI2h1
ZER6KX2lOlk/HeZPupqjgNpersZduw==
=UTmw
-----END PGP SIGNATURE-----

--b9zIUXi3ZquH2FrJ--