Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 09:07:26 -0600
From:   Rob Herring <robh@kernel.org>
To:     Pali =?iso-8859-1?Q?Roh=E1r?= <pali@kernel.org>
Cc:     Wim Van Sebroeck <wim@linux-watchdog.org>,
        Guenter Roeck <linux@roeck-us.net>,
        linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: watchdog: max63xx: Add GPIO binding
Message-ID: <20220706150726.GA40600-robh@kernel.org>
References: <20220705001023.14660-1-pali@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220705001023.14660-1-pali@kernel.org>
Precedence: bulk

On Tue, Jul 05, 2022 at 02:10:22AM +0200, Pali Roh?r wrote:
> GPIO is optional and used for WDI logic.
> 
> Signed-off-by: Pali Roh?r <pali@kernel.org>
> ---
> Changes in v3:
> * Extend description
> ---
>  Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> index ab9641e845db..a0cf9e6c371d 100644
> --- a/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/maxim,max63xx.yaml
> @@ -27,6 +27,10 @@ properties:
>      description: This is a 1-byte memory-mapped address
>      maxItems: 1
>  
> +  gpios:

As I said before, add a name prefix: wdi-gpios

> +    description: Optional GPIO used for controlling WDI (watchdog input) when WDI bit is not mapped to memory

Wrap lines at 80 unless wrapping at 100 provides some benefit.

yamllint is set to 110 because I don't want to fix everyone's line wrap, 
not because that's the standard.


> +    maxItems: 1
> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.20.1
> 
>