Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7a1f5139-fe5d-2b9b-7738-d2283599cdfb@paragon-software.com>
Date:   Wed, 6 Jul 2022 19:10:10 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] fs/ntfs3/indx: Remove unnecessary 'NULL' values from
 Pointer
Content-Language: en-US
To:     Li kunyu <kunyu@nfschina.com>
CC:     <ntfs3@lists.linux.dev>, <linux-kernel@vger.kernel.org>
References: <20220704103113.5529-1-kunyu@nfschina.com>
From:   Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
In-Reply-To: <20220704103113.5529-1-kunyu@nfschina.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/4/22 13:31, Li kunyu wrote:
> Pointer variables allocate memory first, and then judge. There is no
> need to initialize the assignment.
> 
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>   fs/ntfs3/index.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 6f81e3a49abf..b5c92b6ce01c 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -1685,8 +1685,8 @@ indx_insert_into_buffer(struct ntfs_index *indx, struct ntfs_inode *ni,
>   {
>   	int err;
>   	const struct NTFS_DE *sp;
> -	struct NTFS_DE *e, *de_t, *up_e = NULL;
> -	struct indx_node *n2 = NULL;
> +	struct NTFS_DE *e, *de_t, *up_e;
> +	struct indx_node *n2;
>   	struct indx_node *n1 = fnd->nodes[level];
>   	struct INDEX_HDR *hdr1 = &n1->index->ihdr;
>   	struct INDEX_HDR *hdr2;

Thanks for patch, applied!