Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752550AbXE3JzH (ORCPT ); Wed, 30 May 2007 05:55:07 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751249AbXE3Jy4 (ORCPT ); Wed, 30 May 2007 05:54:56 -0400 Received: from hellhawk.shadowen.org ([80.68.90.175]:3513 "EHLO hellhawk.shadowen.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751104AbXE3Jyz (ORCPT ); Wed, 30 May 2007 05:54:55 -0400 Message-ID: <465D49F3.7010005@shadowen.org> Date: Wed, 30 May 2007 10:54:59 +0100 From: Andy Whitcroft User-Agent: Icedove 1.5.0.9 (X11/20061220) MIME-Version: 1.0 To: Andrew Morton CC: "Maciej W. Rozycki" , linux-mips@linux-mips.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zs: Move to the serial subsystem References: <20070530011224.bf36d2df.akpm@linux-foundation.org> In-Reply-To: <20070530011224.bf36d2df.akpm@linux-foundation.org> X-Enigmail-Version: 0.94.2.0 OpenPGP: url=http://www.shadowen.org/~apw/public-key Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1015 Lines: 28 Andrew Morton wrote: > On Tue, 29 May 2007 14:03:54 +0100 (BST) "Maciej W. Rozycki" wrote: > Hey, you have volatiles and checkpatch.pl didn't complain. Andy, a > reference to Documentation/volatile-considered-harmful.txt would suit. > > (That's > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc2/2.6.22-rc2-mm1/broken-out/volatile-considered-harmful-take-3.patch) Added ... Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt PATCH: XXX.eml:374: FILE: linux-2.6.22-rc2/drivers/serial/zs.c:131: + volatile void __iomem *control = zport->port.membase + [...] I will batch up any changes to checkpatch.pl and send you them as a blob when they get "interesting" if that suits. -apw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/