Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 13:48:26 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Nicolin Chen <nicolinc@nvidia.com>
Cc:     kwankhede@nvidia.com, corbet@lwn.net, hca@linux.ibm.com,
        gor@linux.ibm.com, agordeev@linux.ibm.com,
        borntraeger@linux.ibm.com, svens@linux.ibm.com,
        zhenyuw@linux.intel.com, zhi.a.wang@intel.com,
        jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
        rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com,
        airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com,
        mjrosato@linux.ibm.com, pasic@linux.ibm.com, vneethv@linux.ibm.com,
        oberpar@linux.ibm.com, freude@linux.ibm.com,
        akrowiak@linux.ibm.com, jjherne@linux.ibm.com,
        alex.williamson@redhat.com, cohuck@redhat.com,
        kevin.tian@intel.com, hch@infradead.org, jchrist@linux.ibm.com,
        kvm@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org,
        intel-gvt-dev@lists.freedesktop.org,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [RFT][PATCH v2 2/9] vfio/ap: Pass in physical address of ind to
 ap_aqic()
Message-ID: <20220706164826.GI693670@nvidia.com>
References: <20220706062759.24946-1-nicolinc@nvidia.com>
 <20220706062759.24946-3-nicolinc@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220706062759.24946-3-nicolinc@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ZGCnwihkDqbwISy5V0SvlKFprj1rBBZZac7EEzKsoRlRJsBug4tkQMmXx8yI?=
 =?us-ascii?Q?EZrXikGQpHMONgG4h9hk/l2zK2gSPGI+W2FzajYwi1g5zOm/ss5ejLSxS0WS?=
 =?us-ascii?Q?W8Rt7PUY4pv/xvRZBir4L2iNys9CWqogK1bp0Ab9ZPsmQtjb8rfTwzzP1Ifv?=
 =?us-ascii?Q?6sBAnBabhgwRipOhNEfNJH590ja2McYmPOWXbUkMh8fGO7zNgggeRD89rBiO?=
 =?us-ascii?Q?+7DmVuCJ8pnf3zbu8yXG3o+s60bnSadyX5a+/NXGCfDXVC13CjxKb/4wdwXn?=
 =?us-ascii?Q?vMqGLA8VXm0dvJaqNDDebXq11OJNCBQdx23Ol5LMl+VLIelk6TGecj0sJn18?=
 =?us-ascii?Q?KsUPoBII4LhtFTn3jrXmPywE465+xfFAI9VLjynqJe+4v4tnzkH0fTGjZ+ol?=
 =?us-ascii?Q?T6/TZpcitGGjvd4IQ/3qXR5QWVQ1/AuZu1eSc+eapi/kXrRrQiv1F4VREgon?=
 =?us-ascii?Q?ZAAu5SP25N0zfOI0Q9bSNqeuQ1b4GULDUvsc4YUFRSWXoNrx26lRepw5S/RC?=
 =?us-ascii?Q?cSpcgDTwCjzKniZpmp5YZqLckwXP2Kiorwew/0NqD5MVrWUbURAfWcn4BTFH?=
 =?us-ascii?Q?wkeRQ+PrLiDx9VbZKMOhBtyB+N3TrfguQ/d0T0tTH7Vp0OkRECWbAnHmzI15?=
 =?us-ascii?Q?lL/aDmh/8OvbIJBCMU5UnbJrCDpRW7Chh3J7wmjBRZiPf7LGiDMWjBzflh/h?=
 =?us-ascii?Q?5wxQsqeTcUuDnxlh5rSmrFIobbfcTSrSrZjOUO5b/4ZVFgCtm/aAOcObWN4u?=
 =?us-ascii?Q?GPvyRE0OQw8DbBQVwcRy+70kkhV02EWNvlaKPZ++zLemJ7lSSezumzxi/Bo2?=
 =?us-ascii?Q?9OVcZatN+/BvNMW5c8yDWUacA0N6SdjMYI2887NE6X1lAekLAgOtPn2jKNCh?=
 =?us-ascii?Q?azRsuyvXWN04FzpI1AeHuwmZ7V+S2cd+6sZFw8v/Tk9QnDhlgxalzwRARDpg?=
 =?us-ascii?Q?URVeaI0XpCv/c4LG7oiDwkPCi8thPXvbxh1CLdVfNbfy7Ukj8k45AgJ/vFku?=
 =?us-ascii?Q?PMvswf+Iya1CWRkr9VNWWsleEJx9fAL1UO5B6B0hyrwmbLhiMLqxcJygs0Dl?=
 =?us-ascii?Q?/Yy4YPIg2tfhnFOgnG1gbl2oxqpI6tWPsSCrWoN3dk59vwOFQIQQxZSJZtVe?=
 =?us-ascii?Q?/t1tjGSK86/d6x6agxfo6J/91788qVBJoBmPlA1O4mYz9367QOGCJrdsPSyp?=
 =?us-ascii?Q?GnluSOtCQ1hIzbSGtqx+5+KBKBPeeqbFeJchwbtop3+KXAfp2UO21pAfawDJ?=
 =?us-ascii?Q?AmRJMtoJeAtg5i6/3Ujy3+nAhHsXCCmBih+66+obmWSPPCGCpWsNa60xDqjq?=
 =?us-ascii?Q?QzHsNJs59ZHh5S4P+cXkLAr3b7KNRCk2crR8MpiRvVv4PAhDQF1dvgFA0bcq?=
 =?us-ascii?Q?efjfLTqQ7eM3OdpH0urLoRQvQXLepJM0dpt1H4TjsQ2iML+OHf+VBb1vM9uG?=
 =?us-ascii?Q?igXDymVqQGNB0ZTI/ES3dU5bs0NXIwVSCLXyCXVInU+e0uRkfPj0DDRSmVzC?=
 =?us-ascii?Q?Dfiu3s3TxjkMSGs+g7mMsdExCOfKCLgVBjpCHhsZvir4yrxRrVS/sx6HRs7A?=
 =?us-ascii?Q?LYM9Dn16p/y8FlngDHrm++hql7Eq+MSaMOyiJKoj?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 15b60f44-8f5c-453f-ae38-08da5f6f5986
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 16:48:28.0615
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: bGW6N3rIhZO39L15t6TLrAgijjJaea6q1dbARNqAPducAPChX1vJIHp24Eejm8T9
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1201MB0226
X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 05, 2022 at 11:27:52PM -0700, Nicolin Chen wrote:
> The ap_aqic() is called by vfio_ap_irq_enable() where it passes in a
> virt value that's casted from a physical address "h_nib". Inside the
> ap_aqic(), it does virt_to_phys() again.
> 
> Since ap_aqic() needs a physical address, let's just pass in a pa of
> ind directly. So change the "ind" to "pa_ind".
> 
> Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
> Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> ---
>  arch/s390/include/asm/ap.h        | 6 +++---
>  drivers/s390/crypto/ap_queue.c    | 2 +-
>  drivers/s390/crypto/vfio_ap_ops.c | 7 ++++---
>  3 files changed, 8 insertions(+), 7 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason