Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 6 Jul 2022 18:23:35 +0200
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>
To:     Rob Herring <robh@kernel.org>
Cc:     Pavel Machek <pavel@ucw.cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Marek =?utf-8?B?QmVow7pu?= <kabel@kernel.org>,
        linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: leds: register-bit-led: Add value
 property
Message-ID: <20220706162335.2eewgf7l3xghdjtr@pali>
References: <20220706112828.27278-1-pali@kernel.org>
 <20220706162111.GA145516-robh@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220706162111.GA145516-robh@kernel.org>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Wednesday 06 July 2022 10:21:11 Rob Herring wrote:
> On Wed, Jul 06, 2022 at 01:28:27PM +0200, Pali Rohár wrote:
> > Allow to define inverted logic (0 - enable LED, 1 - disable LED) via value
> > property. This property name is already used by other syscon drivers, e.g.
> > syscon-reboot.
> 
> Yes, but those are potentially multi-bit values. This is a single bit 
> value, and the only value that's ever needed is 0. Why not just use 
> 'active-low' here?

Just because to have uniform definitions across more syscon nodes.

> > 
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> >  .../devicetree/bindings/leds/register-bit-led.yaml    | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/register-bit-led.yaml b/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> > index 79b8fc0f9d23..d6054a3f9087 100644
> > --- a/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> > +++ b/Documentation/devicetree/bindings/leds/register-bit-led.yaml
> > @@ -43,6 +43,17 @@ properties:
> >          0x100000, 0x200000, 0x400000, 0x800000, 0x1000000, 0x2000000, 0x4000000,
> >          0x8000000, 0x10000000, 0x20000000, 0x40000000, 0x80000000 ]
> >  
> > +  value:
> > +    description:
> > +      bit value of ON state for the bit controlling this LED in the register
> > +      when not specified it is same as the mask
> > +    $ref: /schemas/types.yaml#/definitions/uint32
> > +    enum:
> > +      [ 0x0, 0x1, 0x2, 0x4, 0x8, 0x10, 0x20, 0x40, 0x80, 0x100, 0x200, 0x400, 0x800,
> > +        0x1000, 0x2000, 0x4000, 0x8000, 0x10000, 0x20000, 0x40000, 0x80000,
> > +        0x100000, 0x200000, 0x400000, 0x800000, 0x1000000, 0x2000000, 0x4000000,
> > +        0x8000000, 0x10000000, 0x20000000, 0x40000000, 0x80000000 ]
> > +
> >    offset:
> >      description:
> >        register offset to the register controlling this LED
> > -- 
> > 2.20.1
> > 
> >